[PATCH 1/1] Add sbc cap null case while GST AVDTP Signaling.

[PATCH 1/1] Add sbc cap null case while GST AVDTP Signaling.

[chanyeol.park]

From: Chan-yeol Park <chanyeol.park@samsung.com>

Due to RF condition or headset malfunctioning, gst audio plug-in
could not get sbc(mandatory codec) information.
---
 audio/gstavdtpsink.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
index b448d57..1d50914 100644
--- a/audio/gstavdtpsink.c
+++ b/audio/gstavdtpsink.c
@@ -1121,6 +1121,11 @@ static gboolean gst_avdtp_sink_update_caps(GstAvdtpSink *self)
 	sbc = (void *) gst_avdtp_find_caps(self, BT_A2DP_SBC_SINK);
 	mpeg = (void *) gst_avdtp_find_caps(self, BT_A2DP_MPEG12_SINK);
 
+	if(!sbc) {
+		GST_ERROR_OBJECT(self, "Failed to find sbc(mandatory codec)");
+		return FALSE;
+	}
+
 	sbc_structure = gst_avdtp_sink_parse_sbc_caps(self, sbc);
 	mpeg_structure = gst_avdtp_sink_parse_mpeg_caps(self, mpeg);
 
-- 
1.7.5.4

Re: [PATCH 1/1] Add sbc cap null case while GST AVDTP Signaling.

[Marcel Holtmann]

Hi Chan-yeol,

> Due to RF condition or headset malfunctioning, gst audio plug-in
> could not get sbc(mandatory codec) information.
> ---
>  audio/gstavdtpsink.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
> index b448d57..1d50914 100644
> --- a/audio/gstavdtpsink.c
> +++ b/audio/gstavdtpsink.c
> @@ -1121,6 +1121,11 @@ static gboolean gst_avdtp_sink_update_caps(GstAvdtpSink *self)
>  	sbc = (void *) gst_avdtp_find_caps(self, BT_A2DP_SBC_SINK);
>  	mpeg = (void *) gst_avdtp_find_caps(self, BT_A2DP_MPEG12_SINK);
>  
> +	if(!sbc) {

space before brackets are not not option. Please follow the coding style
and fix this.

> +		GST_ERROR_OBJECT(self, "Failed to find sbc(mandatory codec)");

And please use proper error messages aka "Failed to find mandatory SBC
sink".

> +		return FALSE;
> +	}
> +
>  	sbc_structure = gst_avdtp_sink_parse_sbc_caps(self, sbc);
>  	mpeg_structure = gst_avdtp_sink_parse_mpeg_caps(self, mpeg);
>  

Regards

Marcel

[PATCH 1/1] Add sbc cap null case while GST AVDTP Signaling.

[chanyeol.park]

From: Chan-yeol Park <chanyeol.park@samsung.com>

Due to RF condition or headset malfunctioning, gst audio plug-in
could not get sbc(mandatory codec) information.
---
 audio/gstavdtpsink.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
index b448d57..af04a56 100644
--- a/audio/gstavdtpsink.c
+++ b/audio/gstavdtpsink.c
@@ -1121,6 +1121,11 @@ static gboolean gst_avdtp_sink_update_caps(GstAvdtpSink *self)
 	sbc = (void *) gst_avdtp_find_caps(self, BT_A2DP_SBC_SINK);
 	mpeg = (void *) gst_avdtp_find_caps(self, BT_A2DP_MPEG12_SINK);
 
+	if (!sbc) {
+		GST_ERROR_OBJECT(self, "Failed to find mandatory SBC sink");
+		return FALSE;
+	}
+
 	sbc_structure = gst_avdtp_sink_parse_sbc_caps(self, sbc);
 	mpeg_structure = gst_avdtp_sink_parse_mpeg_caps(self, mpeg);
 
-- 
1.7.5.4

Re: [PATCH 1/1] Add sbc cap null case while GST AVDTP Signaling.

[Johan Hedberg]

Hi Chan-yeol,

On Mon, Apr 16, 2012, chanyeol.park@samsung.com wrote:
> Due to RF condition or headset malfunctioning, gst audio plug-in
> could not get sbc(mandatory codec) information.
> ---
>  audio/gstavdtpsink.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Applied. Thanks.

Also, please use v2, v3 etc in the future. It makes it easier for me to
track new patches vs new revisions of existing ones.

Johan