* [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl
@ 2012-04-14 9:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2012-04-14 9:48 UTC (permalink / raw)
To: Ian Kent; +Cc: kernel-janitors, autofs, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Free param as done in the other error-handling code.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
fs/autofs4/dev-ioctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 9dacb85..f99c2ce 100644
--- a/fs/autofs4/dev-ioctl.c
+++ b/fs/autofs4/dev-ioctl.c
@@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
fn = lookup_dev_ioctl(cmd);
if (!fn) {
AUTOFS_WARN("unknown command 0x%08x", command);
- return -ENOTTY;
+ err = -ENOTTY;
+ goto out;
}
fp = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl
@ 2012-04-14 9:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2012-04-14 9:48 UTC (permalink / raw)
To: Ian Kent; +Cc: kernel-janitors, autofs, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Free param as done in the other error-handling code.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
fs/autofs4/dev-ioctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 9dacb85..f99c2ce 100644
--- a/fs/autofs4/dev-ioctl.c
+++ b/fs/autofs4/dev-ioctl.c
@@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
fn = lookup_dev_ioctl(cmd);
if (!fn) {
AUTOFS_WARN("unknown command 0x%08x", command);
- return -ENOTTY;
+ err = -ENOTTY;
+ goto out;
}
fp = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl
2012-04-14 9:48 ` Julia Lawall
@ 2012-04-16 1:19 ` Ian Kent
-1 siblings, 0 replies; 4+ messages in thread
From: Ian Kent @ 2012-04-16 1:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, autofs, linux-kernel
On Sat, 2012-04-14 at 11:48 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Free param as done in the other error-handling code.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Oops!
Acked-by: Ian Kent <raven@themaw.net>
>
> ---
> fs/autofs4/dev-ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
> index 9dacb85..f99c2ce 100644
> --- a/fs/autofs4/dev-ioctl.c
> +++ b/fs/autofs4/dev-ioctl.c
> @@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
> fn = lookup_dev_ioctl(cmd);
> if (!fn) {
> AUTOFS_WARN("unknown command 0x%08x", command);
> - return -ENOTTY;
> + err = -ENOTTY;
> + goto out;
> }
>
> fp = NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe autofs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl
@ 2012-04-16 1:19 ` Ian Kent
0 siblings, 0 replies; 4+ messages in thread
From: Ian Kent @ 2012-04-16 1:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, autofs, linux-kernel
On Sat, 2012-04-14 at 11:48 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Free param as done in the other error-handling code.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Oops!
Acked-by: Ian Kent <raven@themaw.net>
>
> ---
> fs/autofs4/dev-ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
> index 9dacb85..f99c2ce 100644
> --- a/fs/autofs4/dev-ioctl.c
> +++ b/fs/autofs4/dev-ioctl.c
> @@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
> fn = lookup_dev_ioctl(cmd);
> if (!fn) {
> AUTOFS_WARN("unknown command 0x%08x", command);
> - return -ENOTTY;
> + err = -ENOTTY;
> + goto out;
> }
>
> fp = NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe autofs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-16 1:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-14 9:48 [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl Julia Lawall
2012-04-14 9:48 ` Julia Lawall
2012-04-16 1:19 ` Ian Kent
2012-04-16 1:19 ` Ian Kent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.