All of lore.kernel.org
 help / color / mirror / Atom feed
From: lost.distance@yahoo.com (Paul Parsons)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: pxa: Set PXA GPIO irq_chip IRQCHIP_SKIP_SET_WAKE flag
Date: Wed, 18 Apr 2012 20:34:44 +0100 (BST)	[thread overview]
Message-ID: <1334777684.34148.YahooMailClassic@web29014.mail.ird.yahoo.com> (raw)
In-Reply-To: <87bomohpdl.fsf@free.fr>

--- On Wed, 18/4/12, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> > Just to clarify, the generic pxa/gpio suspend/resume
> support does
> > seem to work OK; the hx4700 patches are platform
> specific, apart
> > from this SKIP_SET_WAKE patch to fix the Unbalanced IRQ
> warnings.
> 
> OK, I'll check.
> 
> My platform is mioa701. In my case, the suspend/resume is
> working for RTC
> wakeup, but not for GPIO0. This code was working before
> (that's vague, I know, I
> suspect 3.0 was working), and is not working anymore. The
> gpio_keys_button
> structure has still its 'wakeup' field ...
> 
> > Consequently it seems likely that your problem is also
> platform
> > specific.
> OK. So you confirm that on hx4700, pressing PowerButton
> while in suspend to ram
> brings back to life your device ?

Yes.

I had a quick look at arch/arm/mach-pxa/mioa701.c and
noticed that it didn't call gpio_set_wake() for GPIO0.
Does this help:

diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
index 061d570..23190bf 100644
--- a/arch/arm/mach-pxa/mioa701.c
+++ b/arch/arm/mach-pxa/mioa701.c
@@ -726,6 +726,7 @@ static void __init mioa701_machine_init(void)
 
 
 	pxa2xx_mfp_config(ARRAY_AND_SIZE(mioa701_pin_config));
+	gpio_set_wake(GPIO0_KEY_POWER, 1);
 	pxa_set_ffuart_info(NULL);
 	pxa_set_btuart_info(NULL);
 	pxa_set_stuart_info(NULL);

Regards,
Paul

  reply	other threads:[~2012-04-18 19:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 14:06 [PATCH] gpio: pxa: Set PXA GPIO irq_chip IRQCHIP_SKIP_SET_WAKE flag Paul Parsons
2012-04-12 18:07 ` Paul Parsons
2012-04-17 21:28   ` Robert Jarzmik
2012-04-18  1:04     ` Paul Parsons
2012-04-18 10:58       ` Paul Parsons
2012-04-18 18:21         ` Robert Jarzmik
2012-04-18 19:34           ` Paul Parsons [this message]
2012-04-18 20:59             ` Robert Jarzmik
2012-04-18 22:40               ` Paul Parsons
2012-04-19 19:40                 ` Robert Jarzmik
2012-04-20  0:55                   ` Haojian Zhuang
2012-04-22 11:37                     ` [PATCH] arm/pxa: fix gpio wakeup setting Robert Jarzmik
2012-04-24 17:46                       ` Robert Jarzmik
2012-04-27  2:52                         ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334777684.34148.YahooMailClassic@web29014.mail.ird.yahoo.com \
    --to=lost.distance@yahoo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.