All of lore.kernel.org
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: pxa: Set PXA GPIO irq_chip IRQCHIP_SKIP_SET_WAKE flag
Date: Thu, 19 Apr 2012 21:40:05 +0200	[thread overview]
Message-ID: <87vckvfr3e.fsf@free.fr> (raw)
In-Reply-To: <1334788817.8003.YahooMailClassic@web29002.mail.ird.yahoo.com> (Paul Parsons's message of "Wed, 18 Apr 2012 23:40:17 +0100 (BST)")


Haojian,

I feel there's some change in PXA gpio wakeup handling that's weird.

The effect : gpio_keys driver can't wakeup from suspend to RAM on GPIO0
activation

A quick analysis (thanks Paul for direction) :
 - gpio_keys() calls irq_set_wake(96, 1) (ie. gpio0)
 - gpio-pxa driver doesn't care (as it doesn't have any irq_set_wake function)
   (see in [1])

Now if I'm directing the mail at is because you're the only one who commited
between v3.2 and v3.3 in gpio-pxa driver ([2]).

Could you tell me if removing irq_set_wake() was intentional ?

Cheers.

-- 
Robert

[1]
rj at beldin:~/mio_linux/kernel$ git show v3.2:drivers/gpio/gpio-pxa.c | grep set_wake
void __init pxa_init_gpio(int mux_irq, int start, int end, set_wake_t fn)
	pxa_muxed_gpio_chip.irq_set_wake = fn;
rj at beldin:~/mio_linux/kernel$ git show v3.3:drivers/gpio/gpio-pxa.c | grep set_wake
rj at beldin:~/mio_linux/kernel$ 

[2]
rj at beldin:~/mio_linux/kernel$ git log v3.3 ^v3.2 --pretty=format:%an drivers/gpio/gpio-pxa.c | sort -u
Haojian Zhuang

  reply	other threads:[~2012-04-19 19:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 14:06 [PATCH] gpio: pxa: Set PXA GPIO irq_chip IRQCHIP_SKIP_SET_WAKE flag Paul Parsons
2012-04-12 18:07 ` Paul Parsons
2012-04-17 21:28   ` Robert Jarzmik
2012-04-18  1:04     ` Paul Parsons
2012-04-18 10:58       ` Paul Parsons
2012-04-18 18:21         ` Robert Jarzmik
2012-04-18 19:34           ` Paul Parsons
2012-04-18 20:59             ` Robert Jarzmik
2012-04-18 22:40               ` Paul Parsons
2012-04-19 19:40                 ` Robert Jarzmik [this message]
2012-04-20  0:55                   ` Haojian Zhuang
2012-04-22 11:37                     ` [PATCH] arm/pxa: fix gpio wakeup setting Robert Jarzmik
2012-04-24 17:46                       ` Robert Jarzmik
2012-04-27  2:52                         ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vckvfr3e.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.