* [PATCH] libata: clear error mask of old error history
@ 2012-04-20 1:38 Lin Ming
2012-04-20 10:29 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Lin Ming @ 2012-04-20 1:38 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, Martin Mokrejs
The old error history was cleared in ata_ering_clear().
It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared.
So ata_ering_map() still iterates the old error history.
This causes problem, for example, wrong probe trials count were returned in
ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed down
to 1.5Gbps.
Reported-and-tested-by: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
Hi Jeff,
This patch fixes an old regression introduced in 2.6.37-rc1
of commit d902747.
So it should be included into stable releases since 2.6.37.
drivers/ata/libata-eh.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index c61316e..4c6f49b 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -419,9 +419,10 @@ int ata_ering_map(struct ata_ering *ering,
return rc;
}
-int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg)
+static int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg)
{
ent->eflags |= ATA_EFLAG_OLD_ER;
+ ent->err_mask = 0;
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libata: clear error mask of old error history
2012-04-20 1:38 [PATCH] libata: clear error mask of old error history Lin Ming
@ 2012-04-20 10:29 ` Sergei Shtylyov
2012-04-23 1:09 ` Lin Ming
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2012-04-20 10:29 UTC (permalink / raw)
To: Lin Ming; +Cc: Jeff Garzik, linux-ide, Martin Mokrejs
Hello.
On 20-04-012 5:38, Lin Ming wrote:
> The old error history was cleared in ata_ering_clear().
> It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared.
> So ata_ering_map() still iterates the old error history.
> This causes problem, for example, wrong probe trials count were returned in
> ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed down
> to 1.5Gbps.
> Reported-and-tested-by: Martin Mokrejs<mmokrejs@fold.natur.cuni.cz>
> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
> ---
> Hi Jeff,
> This patch fixes an old regression introduced in 2.6.37-rc1
> of commit d902747.
> So it should be included into stable releases since 2.6.37.
You should have included:
Cc: stable@vger.kernel.org # 2.6.37+
after your signoff in this case.
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libata: clear error mask of old error history
2012-04-20 10:29 ` Sergei Shtylyov
@ 2012-04-23 1:09 ` Lin Ming
0 siblings, 0 replies; 3+ messages in thread
From: Lin Ming @ 2012-04-23 1:09 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Jeff Garzik, linux-ide, Martin Mokrejs
On Fri, Apr 20, 2012 at 6:29 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
>
> On 20-04-012 5:38, Lin Ming wrote:
>
>> The old error history was cleared in ata_ering_clear().
>> It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared.
>> So ata_ering_map() still iterates the old error history.
>
>
>> This causes problem, for example, wrong probe trials count were returned
>> in
>> ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed
>> down
>> to 1.5Gbps.
>
>
>> Reported-and-tested-by: Martin Mokrejs<mmokrejs@fold.natur.cuni.cz>
>> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
>> ---
>
>
>> Hi Jeff,
>
>
>> This patch fixes an old regression introduced in 2.6.37-rc1
>> of commit d902747.
>
>
>> So it should be included into stable releases since 2.6.37.
>
>
> You should have included:
>
> Cc: stable@vger.kernel.org # 2.6.37+
>
> after your signoff in this case.
Re-send with stable CCed.
Thanks.
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-23 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-20 1:38 [PATCH] libata: clear error mask of old error history Lin Ming
2012-04-20 10:29 ` Sergei Shtylyov
2012-04-23 1:09 ` Lin Ming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.