All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing
@ 2012-04-21 22:48 ` Eldad Zack
  0 siblings, 0 replies; 4+ messages in thread
From: Eldad Zack @ 2012-04-21 22:48 UTC (permalink / raw)
  To: Brett Rudley, Roland Vossen, Arend van Spriel, Kan Yan, John W. Linville
  Cc: linux-wireless, netdev, linux-kernel, Eldad Zack

I keep getting the following messages on the log buffer:
[ 2167.097507] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.331305] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.332539] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.876605] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.877354] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2462.280756] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2615.651689] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU

>From the code comment I understand that this something that can - and does, quite frequently - happen.
This patch demotes the message to the trace level.

Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
 drivers/net/wireless/brcm80211/brcmsmac/main.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 231ddf4..2fc5956 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -847,8 +847,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
 	 */
 	if (!(txs->status & TX_STATUS_AMPDU)
 	    && (txs->status & TX_STATUS_INTERMEDIATE)) {
-		wiphy_err(wlc->wiphy, "%s: INTERMEDIATE but not AMPDU\n",
-			  __func__);
+		BCMMSG(wlc->wiphy, "INTERMEDIATE but not AMPDU\n");
 		return false;
 	}
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing
@ 2012-04-21 22:48 ` Eldad Zack
  0 siblings, 0 replies; 4+ messages in thread
From: Eldad Zack @ 2012-04-21 22:48 UTC (permalink / raw)
  To: Brett Rudley, Roland Vossen, Arend van Spriel, Kan Yan, John W. Linville
  Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Eldad Zack

I keep getting the following messages on the log buffer:
[ 2167.097507] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.331305] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.332539] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.876605] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.877354] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2462.280756] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2615.651689] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU

>From the code comment I understand that this something that can - and does, quite frequently - happen.
This patch demotes the message to the trace level.

Signed-off-by: Eldad Zack <eldad-v6AqZgAe4C4dvzyIwGCCOg@public.gmane.org>
---
 drivers/net/wireless/brcm80211/brcmsmac/main.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 231ddf4..2fc5956 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -847,8 +847,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
 	 */
 	if (!(txs->status & TX_STATUS_AMPDU)
 	    && (txs->status & TX_STATUS_INTERMEDIATE)) {
-		wiphy_err(wlc->wiphy, "%s: INTERMEDIATE but not AMPDU\n",
-			  __func__);
+		BCMMSG(wlc->wiphy, "INTERMEDIATE but not AMPDU\n");
 		return false;
 	}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing
@ 2012-04-23 17:43   ` Franky Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Franky Lin @ 2012-04-23 17:43 UTC (permalink / raw)
  To: Eldad Zack, John W. Linville
  Cc: Brett Rudley, Roland Vossen, Arend van Spriel, Kan Yan,
	linux-wireless, netdev, linux-kernel

On 04/21/2012 03:48 PM, Eldad Zack wrote:
>  From the code comment I understand that this something that can - and does, quite frequently - happen.
> This patch demotes the message to the trace level.
>
> Signed-off-by: Eldad Zack<eldad@fogrefinery.com>

Thx Eldad,

Acked-by: Franky Lin<frankyl@broadcom.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing
@ 2012-04-23 17:43   ` Franky Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Franky Lin @ 2012-04-23 17:43 UTC (permalink / raw)
  To: Eldad Zack, John W. Linville
  Cc: Brett Rudley, Roland Vossen, Arend van Spriel, Kan Yan,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On 04/21/2012 03:48 PM, Eldad Zack wrote:
>  From the code comment I understand that this something that can - and does, quite frequently - happen.
> This patch demotes the message to the trace level.
>
> Signed-off-by: Eldad Zack<eldad-v6AqZgAe4C4dvzyIwGCCOg@public.gmane.org>

Thx Eldad,

Acked-by: Franky Lin<frankyl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-23 17:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-21 22:48 [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing Eldad Zack
2012-04-21 22:48 ` Eldad Zack
2012-04-23 17:43 ` Franky Lin
2012-04-23 17:43   ` Franky Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.