* [PATCH] ASoC: dapm: Fix x86_64 build warning.
@ 2012-04-23 9:31 Liam Girdwood
2012-04-23 12:16 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Liam Girdwood @ 2012-04-23 9:31 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood
Fixes the following build warning on x86_64.
In file included from include/trace/ftrace.h:567:0,
from include/trace/define_trace.h:86,
from include/trace/events/asoc.h:410,
from sound/soc/soc-core.c:45:
include/trace/events/asoc.h: In function 'ftrace_raw_event_snd_soc_dapm_output_path':
include/trace/events/asoc.h:246:1: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
include/trace/events/asoc.h: In function 'ftrace_raw_event_snd_soc_dapm_input_path':
include/trace/events/asoc.h:275:1: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Signed-off-by: Liam Girdwood <lrg@ti.com>
---
include/trace/events/asoc.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h
index 6d8efb1..5fc2dcd 100644
--- a/include/trace/events/asoc.h
+++ b/include/trace/events/asoc.h
@@ -263,7 +263,7 @@ TRACE_EVENT(snd_soc_dapm_output_path,
__assign_str(pname, path->name ? path->name : DAPM_DIRECT);
__assign_str(psname, path->sink->name);
__entry->path_connect = path->connect;
- __entry->path_sink = (int)path->sink;
+ __entry->path_sink = (long)path->sink;
),
TP_printk("%c%s -> %s -> %s\n",
@@ -292,7 +292,7 @@ TRACE_EVENT(snd_soc_dapm_input_path,
__assign_str(pname, path->name ? path->name : DAPM_DIRECT);
__assign_str(psname, path->source->name);
__entry->path_connect = path->connect;
- __entry->path_source = (int)path->source;
+ __entry->path_source = (long)path->source;
),
TP_printk("%c%s <- %s <- %s\n",
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: dapm: Fix x86_64 build warning.
2012-04-23 9:31 [PATCH] ASoC: dapm: Fix x86_64 build warning Liam Girdwood
@ 2012-04-23 12:16 ` Mark Brown
2012-04-23 12:22 ` Vinod Koul
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-04-23 12:16 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 128 bytes --]
On Mon, Apr 23, 2012 at 10:31:15AM +0100, Liam Girdwood wrote:
> Fixes the following build warning on x86_64.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: dapm: Fix x86_64 build warning.
2012-04-23 12:16 ` Mark Brown
@ 2012-04-23 12:22 ` Vinod Koul
2012-04-23 12:28 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2012-04-23 12:22 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood
On Mon, 2012-04-23 at 13:16 +0100, Mark Brown wrote:
> On Mon, Apr 23, 2012 at 10:31:15AM +0100, Liam Girdwood wrote:
> > Fixes the following build warning on x86_64.
>
> Applied, thanks.
Just wondering, do we have a x86-64 system running asoc?
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: dapm: Fix x86_64 build warning.
2012-04-23 12:22 ` Vinod Koul
@ 2012-04-23 12:28 ` Mark Brown
2012-04-23 15:34 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-04-23 12:28 UTC (permalink / raw)
To: Vinod Koul; +Cc: alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 709 bytes --]
On Mon, Apr 23, 2012 at 05:52:34PM +0530, Vinod Koul wrote:
> On Mon, 2012-04-23 at 13:16 +0100, Mark Brown wrote:
> > On Mon, Apr 23, 2012 at 10:31:15AM +0100, Liam Girdwood wrote:
> > > Fixes the following build warning on x86_64.
> > Applied, thanks.
> Just wondering, do we have a x86-64 system running asoc?
We should do though we don't currently - see the recent discussion about
the ice drivers. There are some PC sound cards (mostly high end or old
ones, or tuner cards) which have a setup like ASoC where there's a CODEC
on an I2C bus and a "platform" which in this case is a PCI type device.
At a high level they look the same as embedded hardware with several
chips glued together in software.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: dapm: Fix x86_64 build warning.
2012-04-23 12:28 ` Mark Brown
@ 2012-04-23 15:34 ` Takashi Iwai
2012-04-23 16:10 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2012-04-23 15:34 UTC (permalink / raw)
To: Mark Brown; +Cc: Vinod Koul, alsa-devel, Liam Girdwood
At Mon, 23 Apr 2012 13:28:44 +0100,
Mark Brown wrote:
>
> On Mon, Apr 23, 2012 at 05:52:34PM +0530, Vinod Koul wrote:
> > On Mon, 2012-04-23 at 13:16 +0100, Mark Brown wrote:
> > > On Mon, Apr 23, 2012 at 10:31:15AM +0100, Liam Girdwood wrote:
> > > > Fixes the following build warning on x86_64.
>
> > > Applied, thanks.
>
> > Just wondering, do we have a x86-64 system running asoc?
>
> We should do though we don't currently - see the recent discussion about
> the ice drivers. There are some PC sound cards (mostly high end or old
> ones, or tuner cards) which have a setup like ASoC where there's a CODEC
> on an I2C bus and a "platform" which in this case is a PCI type device.
> At a high level they look the same as embedded hardware with several
> chips glued together in software.
Right. In near future, we'd need to move up/down some ASoC code
pieces into ALSA core so that people won't misunderstand.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: dapm: Fix x86_64 build warning.
2012-04-23 15:34 ` Takashi Iwai
@ 2012-04-23 16:10 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-04-23 16:10 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Vinod Koul, alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 974 bytes --]
On Mon, Apr 23, 2012 at 05:34:36PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > We should do though we don't currently - see the recent discussion about
> > the ice drivers. There are some PC sound cards (mostly high end or old
> > ones, or tuner cards) which have a setup like ASoC where there's a CODEC
> > on an I2C bus and a "platform" which in this case is a PCI type device.
> > At a high level they look the same as embedded hardware with several
> > chips glued together in software.
> Right. In near future, we'd need to move up/down some ASoC code
> pieces into ALSA core so that people won't misunderstand.
I think from a code structure point of view we're probably mostly fine
as is (in that ASoC is sitting in parallel with more integrated sound
card architectures) - except for DAPM mostly ASoC is just thin wrappers
for the core which split things up for multiple devices. We'd need to
deal with that layering somehow if we were merging stuff in.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-23 18:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-23 9:31 [PATCH] ASoC: dapm: Fix x86_64 build warning Liam Girdwood
2012-04-23 12:16 ` Mark Brown
2012-04-23 12:22 ` Vinod Koul
2012-04-23 12:28 ` Mark Brown
2012-04-23 15:34 ` Takashi Iwai
2012-04-23 16:10 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.