[PATCH 1/1] drm: Store vendor IDs directly in the EDID quirk structure

[PATCH 1/1] drm: Store vendor IDs directly in the EDID quirk structure

[Ian Pilcher]

EDID vendor IDs are always 3 characters long (4 with the terminating
0).  It doesn't make any sense to have a (possibly 8-byte) pointer
to the ID string in the quirk structure.

Signed-off-by: Ian Pilcher <arequipeno@gmail.com>
---
 drivers/gpu/drm/drm_edid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 5a18b0d..8c27395 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -81,7 +81,7 @@ struct detailed_mode_closure {
 #define LEVEL_CVT	3
 
 static struct edid_quirk {
-	char *vendor;
+	char vendor[4];
 	int product_id;
 	u32 quirks;
 } edid_quirk_list[] = {
-- 
1.7.7.6

Re: [PATCH 1/1] drm: Store vendor IDs directly in the EDID quirk structure

[Adam Jackson]

[-- Attachment #1.1: Type: text/plain, Size: 355 bytes --]

On Sun, 2012-04-22 at 11:40 -0500, Ian Pilcher wrote:
> EDID vendor IDs are always 3 characters long (4 with the terminating
> 0).  It doesn't make any sense to have a (possibly 8-byte) pointer
> to the ID string in the quirk structure.
> 
> Signed-off-by: Ian Pilcher <arequipeno@gmail.com>

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel