From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: create macros to handle masked bits
Date: Tue, 24 Apr 2012 14:24:33 +0100 [thread overview]
Message-ID: <1335273904_37656@CP5-2952> (raw)
In-Reply-To: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... and put them to so good use.
>
> Note that there's functional change in vlv clock gating code, we now
> no longer spuriously read back the current value of the bit. According
> to Bspec the high bits should always read zeror, so ORing this in
s/zeror/zero/
> should have no effect.
>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
The transforms here look fine, just a moment of concern for not
repeating the MODE twiddling in init_render_ring after reset.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-24 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 12:04 [PATCH] drm/i915: create macros to handle masked bits Daniel Vetter
2012-04-24 13:24 ` Chris Wilson [this message]
2012-04-24 13:45 ` Daniel Vetter
2012-04-24 13:46 ` Eugeni Dodonov
2012-04-24 16:12 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335273904_37656@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.