All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: santosh.shilimkar@ti.com, jean.pihet@newoldbits.com,
	khilman@ti.com, tony@atomide.com
Cc: linux-omap@vger.kernel.org, linaro-dev@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: [PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time
Date: Tue, 24 Apr 2012 16:05:26 +0200	[thread overview]
Message-ID: <1335276339-11135-6-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1335276339-11135-1-git-send-email-daniel.lezcano@linaro.org>

We initialize the omap4_idle_data variable at compile time allowing us
to remove in the next patch the initialization done at boot time.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Jean Pihet <j-pihet@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/mach-omap2/cpuidle44xx.c |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index 38ecd27..9e3effa 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -31,9 +31,24 @@ struct omap4_idle_statedata {
 	u32 mpu_state;
 };
 
-#define OMAP4_NUM_STATES 3
+static struct omap4_idle_statedata omap4_idle_data[] = {
+	{
+		.cpu_state = PWRDM_POWER_ON,
+		.mpu_state = PWRDM_POWER_ON,
+		.mpu_logic_state = PWRDM_POWER_RET,
+	},
+	{
+		.cpu_state = PWRDM_POWER_OFF,
+		.mpu_state = PWRDM_POWER_RET,
+		.mpu_logic_state = PWRDM_POWER_RET,
+	},
+	{
+		.cpu_state = PWRDM_POWER_OFF,
+		.mpu_state = PWRDM_POWER_RET,
+		.mpu_logic_state = PWRDM_POWER_OFF,
+	},
+};
 
-static struct omap4_idle_statedata omap4_idle_data[OMAP4_NUM_STATES];
 static struct powerdomain *mpu_pd, *cpu0_pd, *cpu1_pd;
 
 /**
@@ -152,7 +167,7 @@ struct cpuidle_driver omap4_idle_driver = {
 			.desc = "MPUSS OSWR",
 		},
 	},
-	.state_count = OMAP4_NUM_STATES,
+	.state_count = ARRAY_SIZE(omap4_idle_data),
 	.safe_state_index = 0,
 };
 
-- 
1.7.5.4


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time
Date: Tue, 24 Apr 2012 16:05:26 +0200	[thread overview]
Message-ID: <1335276339-11135-6-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1335276339-11135-1-git-send-email-daniel.lezcano@linaro.org>

We initialize the omap4_idle_data variable at compile time allowing us
to remove in the next patch the initialization done at boot time.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Jean Pihet <j-pihet@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/mach-omap2/cpuidle44xx.c |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index 38ecd27..9e3effa 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -31,9 +31,24 @@ struct omap4_idle_statedata {
 	u32 mpu_state;
 };
 
-#define OMAP4_NUM_STATES 3
+static struct omap4_idle_statedata omap4_idle_data[] = {
+	{
+		.cpu_state = PWRDM_POWER_ON,
+		.mpu_state = PWRDM_POWER_ON,
+		.mpu_logic_state = PWRDM_POWER_RET,
+	},
+	{
+		.cpu_state = PWRDM_POWER_OFF,
+		.mpu_state = PWRDM_POWER_RET,
+		.mpu_logic_state = PWRDM_POWER_RET,
+	},
+	{
+		.cpu_state = PWRDM_POWER_OFF,
+		.mpu_state = PWRDM_POWER_RET,
+		.mpu_logic_state = PWRDM_POWER_OFF,
+	},
+};
 
-static struct omap4_idle_statedata omap4_idle_data[OMAP4_NUM_STATES];
 static struct powerdomain *mpu_pd, *cpu0_pd, *cpu1_pd;
 
 /**
@@ -152,7 +167,7 @@ struct cpuidle_driver omap4_idle_driver = {
 			.desc = "MPUSS OSWR",
 		},
 	},
-	.state_count = OMAP4_NUM_STATES,
+	.state_count = ARRAY_SIZE(omap4_idle_data),
 	.safe_state_index = 0,
 };
 
-- 
1.7.5.4

  parent reply	other threads:[~2012-04-24 14:05 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 14:05 [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-24 14:05 ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 01/18][V3] ARM: OMAP4: cpuidle - Remove unused valid field Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 02/18][V3] ARM: OMAP4: cpuidle - Declare the states with the driver declaration Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 03/18][V3] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 04/18][V3] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` Daniel Lezcano [this message]
2012-04-24 14:05   ` [PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time Daniel Lezcano
2012-04-24 14:05 ` [PATCH 06/18][V3] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 07/18][V3] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 08/18][V3] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 09/18][V3] ARM: OMAP3: define cpuidle statically Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 10/18][V3] ARM: OMAP3: cpuidle - remove errata check in the init function Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-05-03 20:19   ` Kevin Hilman
2012-05-03 20:19     ` Kevin Hilman
2012-05-03 20:29     ` Daniel Lezcano
2012-05-03 20:29       ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 12/18][V3] ARM: OMAP3: cpuidle - remove cpuidle_params_table Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 13/18][V3] ARM: OMAP3: define statically the omap3_idle_data Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 14/18][V3] ARM: OMAP3: cpuidle - use omap3_idle_data directly Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
     [not found] ` <1335276339-11135-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-04-24 14:05   ` [PATCH 15/18][V3] ARM: OMAP3: cpuidle - simplify next_valid_state Daniel Lezcano
2012-04-24 14:05     ` Daniel Lezcano
2012-04-24 14:05   ` [PATCH 16/18][V3] ARM: OMAP3: set omap3_idle_data as static Daniel Lezcano
2012-04-24 14:05     ` Daniel Lezcano
2012-04-24 14:05   ` [PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile Daniel Lezcano
2012-04-24 14:05     ` Daniel Lezcano
2012-05-03 20:34     ` Kevin Hilman
2012-05-03 20:34       ` Kevin Hilman
2012-05-03 23:03       ` Daniel Lezcano
2012-05-03 23:03         ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static Daniel Lezcano
2012-04-24 14:05   ` Daniel Lezcano
2012-05-03 20:26   ` Kevin Hilman
2012-05-03 20:26     ` Kevin Hilman
2012-05-03 23:02     ` Daniel Lezcano
2012-05-03 23:02       ` Daniel Lezcano
2012-04-25 22:00 ` [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-25 22:00   ` Daniel Lezcano
2012-04-30 22:58   ` Kevin Hilman
2012-04-30 22:58     ` Kevin Hilman
2012-05-01  8:16     ` Daniel Lezcano
2012-05-01  8:16       ` Daniel Lezcano
     [not found]       ` <4F9F9BC1.9020908-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-01  9:25         ` Amit Kucheria
2012-05-01  9:25           ` Amit Kucheria
2012-05-01  9:55         ` Shilimkar, Santosh
2012-05-01 10:20           ` Daniel Lezcano
2012-05-01 10:20             ` Daniel Lezcano
2012-05-02  6:20             ` Shilimkar, Santosh
2012-05-02  6:20               ` Shilimkar, Santosh
2012-05-03 20:39 ` Kevin Hilman
2012-05-03 20:39   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335276339-11135-6-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@ti.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.