* [PATCH] OMAP4: panda: add statics to remove warnings
@ 2012-04-23 7:39 Tomi Valkeinen
2012-04-24 17:16 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2012-04-23 7:39 UTC (permalink / raw)
To: tony, linux-omap; +Cc: Tomi Valkeinen
Add statics to board-omap4-panda.c's internal functions and data
structures to remove warnings.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-omap4panda.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index 1b782ba..8216e5f 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -231,7 +231,7 @@ static struct platform_device omap_vwlan_device = {
},
};
-struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
+static struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
/* PANDA ref clock is 38.4 MHz */
.board_ref_clock = 2,
};
@@ -438,7 +438,7 @@ static struct panel_dvi_platform_data omap4_dvi_panel = {
.i2c_bus_num = 3,
};
-struct omap_dss_device omap4_panda_dvi_device = {
+static struct omap_dss_device omap4_panda_dvi_device = {
.type = OMAP_DISPLAY_TYPE_DPI,
.name = "dvi",
.driver_name = "dvi",
@@ -448,7 +448,7 @@ struct omap_dss_device omap4_panda_dvi_device = {
.channel = OMAP_DSS_CHANNEL_LCD2,
};
-int __init omap4_panda_dvi_init(void)
+static int __init omap4_panda_dvi_init(void)
{
int r;
@@ -509,7 +509,7 @@ static struct omap_dss_board_info omap4_panda_dss_data = {
.default_device = &omap4_panda_dvi_device,
};
-void __init omap4_panda_display_init(void)
+static void __init omap4_panda_display_init(void)
{
int r;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: panda: add statics to remove warnings
2012-04-23 7:39 [PATCH] OMAP4: panda: add statics to remove warnings Tomi Valkeinen
@ 2012-04-24 17:16 ` Tony Lindgren
2012-04-25 12:29 ` Tomi Valkeinen
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2012-04-24 17:16 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap
* Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> Add statics to board-omap4-panda.c's internal functions and data
> structures to remove warnings.
Care to update with the warnings produced?
Tony
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 1b782ba..8216e5f 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -231,7 +231,7 @@ static struct platform_device omap_vwlan_device = {
> },
> };
>
> -struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
> +static struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
> /* PANDA ref clock is 38.4 MHz */
> .board_ref_clock = 2,
> };
> @@ -438,7 +438,7 @@ static struct panel_dvi_platform_data omap4_dvi_panel = {
> .i2c_bus_num = 3,
> };
>
> -struct omap_dss_device omap4_panda_dvi_device = {
> +static struct omap_dss_device omap4_panda_dvi_device = {
> .type = OMAP_DISPLAY_TYPE_DPI,
> .name = "dvi",
> .driver_name = "dvi",
> @@ -448,7 +448,7 @@ struct omap_dss_device omap4_panda_dvi_device = {
> .channel = OMAP_DSS_CHANNEL_LCD2,
> };
>
> -int __init omap4_panda_dvi_init(void)
> +static int __init omap4_panda_dvi_init(void)
> {
> int r;
>
> @@ -509,7 +509,7 @@ static struct omap_dss_board_info omap4_panda_dss_data = {
> .default_device = &omap4_panda_dvi_device,
> };
>
> -void __init omap4_panda_display_init(void)
> +static void __init omap4_panda_display_init(void)
> {
> int r;
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: panda: add statics to remove warnings
2012-04-24 17:16 ` Tony Lindgren
@ 2012-04-25 12:29 ` Tomi Valkeinen
2012-05-04 19:29 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Tomi Valkeinen @ 2012-04-25 12:29 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap
[-- Attachment #1: Type: text/plain, Size: 2624 bytes --]
On Tue, 2012-04-24 at 10:16 -0700, Tony Lindgren wrote:
> * Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> > Add statics to board-omap4-panda.c's internal functions and data
> > structures to remove warnings.
>
> Care to update with the warnings produced?
Ah, sure. Updated patch below:
From e96ddeb7d783d48a15a32f8ef5a7bae3089f66b9 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date: Wed, 28 Mar 2012 11:38:58 +0300
Subject: [PATCH] OMAP4: panda: add statics to remove warnings
Add statics to board-omap4-panda.c's internal functions and data
structures to remove sparse warnings:
arch/arm/mach-omap2/board-omap4panda.c:234:29: warning: symbol
'omap_panda_wlan_data' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap4panda.c:441:24: warning: symbol
'omap4_panda_dvi_device' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap4panda.c:451:12: warning: symbol
'omap4_panda_dvi_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap4panda.c:512:13: warning: symbol
'omap4_panda_display_init' was not declared. Should it be static?
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-omap4panda.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index 1b782ba..8216e5f 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -231,7 +231,7 @@ static struct platform_device omap_vwlan_device = {
},
};
-struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
+static struct wl12xx_platform_data omap_panda_wlan_data __initdata = {
/* PANDA ref clock is 38.4 MHz */
.board_ref_clock = 2,
};
@@ -438,7 +438,7 @@ static struct panel_dvi_platform_data omap4_dvi_panel = {
.i2c_bus_num = 3,
};
-struct omap_dss_device omap4_panda_dvi_device = {
+static struct omap_dss_device omap4_panda_dvi_device = {
.type = OMAP_DISPLAY_TYPE_DPI,
.name = "dvi",
.driver_name = "dvi",
@@ -448,7 +448,7 @@ struct omap_dss_device omap4_panda_dvi_device = {
.channel = OMAP_DSS_CHANNEL_LCD2,
};
-int __init omap4_panda_dvi_init(void)
+static int __init omap4_panda_dvi_init(void)
{
int r;
@@ -509,7 +509,7 @@ static struct omap_dss_board_info omap4_panda_dss_data = {
.default_device = &omap4_panda_dvi_device,
};
-void __init omap4_panda_display_init(void)
+static void __init omap4_panda_display_init(void)
{
int r;
--
1.7.4.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: panda: add statics to remove warnings
2012-04-25 12:29 ` Tomi Valkeinen
@ 2012-05-04 19:29 ` Tony Lindgren
2012-05-11 12:55 ` Tomi Valkeinen
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2012-05-04 19:29 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap
* Tomi Valkeinen <tomi.valkeinen@ti.com> [120425 05:32]:
> On Tue, 2012-04-24 at 10:16 -0700, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> > > Add statics to board-omap4-panda.c's internal functions and data
> > > structures to remove warnings.
> >
> > Care to update with the warnings produced?
>
> Ah, sure. Updated patch below:
>
> From e96ddeb7d783d48a15a32f8ef5a7bae3089f66b9 Mon Sep 17 00:00:00 2001
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Date: Wed, 28 Mar 2012 11:38:58 +0300
> Subject: [PATCH] OMAP4: panda: add statics to remove warnings
>
> Add statics to board-omap4-panda.c's internal functions and data
> structures to remove sparse warnings:
>
> arch/arm/mach-omap2/board-omap4panda.c:234:29: warning: symbol
> 'omap_panda_wlan_data' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:441:24: warning: symbol
> 'omap4_panda_dvi_device' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:451:12: warning: symbol
> 'omap4_panda_dvi_init' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:512:13: warning: symbol
> 'omap4_panda_display_init' was not declared. Should it be static?
Thanks adding to fixes-non-critical.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP4: panda: add statics to remove warnings
2012-05-04 19:29 ` Tony Lindgren
@ 2012-05-11 12:55 ` Tomi Valkeinen
0 siblings, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2012-05-11 12:55 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap
[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]
On Fri, 2012-05-04 at 12:29 -0700, Tony Lindgren wrote:
> * Tomi Valkeinen <tomi.valkeinen@ti.com> [120425 05:32]:
> > On Tue, 2012-04-24 at 10:16 -0700, Tony Lindgren wrote:
> > > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> > > > Add statics to board-omap4-panda.c's internal functions and data
> > > > structures to remove warnings.
> > >
> > > Care to update with the warnings produced?
> >
> > Ah, sure. Updated patch below:
> >
> > From e96ddeb7d783d48a15a32f8ef5a7bae3089f66b9 Mon Sep 17 00:00:00 2001
> > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Date: Wed, 28 Mar 2012 11:38:58 +0300
> > Subject: [PATCH] OMAP4: panda: add statics to remove warnings
> >
> > Add statics to board-omap4-panda.c's internal functions and data
> > structures to remove sparse warnings:
> >
> > arch/arm/mach-omap2/board-omap4panda.c:234:29: warning: symbol
> > 'omap_panda_wlan_data' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:441:24: warning: symbol
> > 'omap4_panda_dvi_device' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:451:12: warning: symbol
> > 'omap4_panda_dvi_init' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:512:13: warning: symbol
> > 'omap4_panda_display_init' was not declared. Should it be static?
>
> Thanks adding to fixes-non-critical.
It seems this patch is obsolete, as there's already one in linux-next:
commit 8c3d4534a8da0dc6a2d52b61585e61f7e8143096
Author: Paul Walmsley <paul@pwsan.com>
Date: Fri Apr 13 06:34:26 2012 -0600
ARM: OMAP2+: declare file-local functions as static
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-11 12:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-23 7:39 [PATCH] OMAP4: panda: add statics to remove warnings Tomi Valkeinen
2012-04-24 17:16 ` Tony Lindgren
2012-04-25 12:29 ` Tomi Valkeinen
2012-05-04 19:29 ` Tony Lindgren
2012-05-11 12:55 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.