* [PATCH] Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003"
@ 2012-04-28 6:28 Rajkumar Manoharan
2012-04-30 18:22 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Rajkumar Manoharan @ 2012-04-28 6:28 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Rajkumar Manoharan, Madhan Jaganathan, Kai Shi
This reverts commit a844adfd7bee4edc66d337de6c33b348e83552a8.
spur_freq_sd (for self-corr in AGC) is defined with respect to the
center of each 20MHz channel while spur_phase_delta (for self-corr
in Rx and spur data filter) is defined with respect to the center
of current RF channel.
So in short, we need to subtract spur_freq_sd (for self-corr in AGC)
by the offset between the center of primary20 and the center of RF
channel in SW. This offset could be +/10 MHz for dynamic 40.
Cc: Madhan Jaganathan <madhanj@qca.qualcomm.com>
Signed-off-by: Kai Shi <kaishi@qca.qualcomm.com>
Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/ar9003_phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index 5358553..11abb97 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -373,7 +373,7 @@ static void ar9003_hw_spur_ofdm_work(struct ath_hw *ah,
else
spur_subchannel_sd = 0;
- spur_freq_sd = (freq_offset << 9) / 11;
+ spur_freq_sd = ((freq_offset + 10) << 9) / 11;
} else {
if (REG_READ_FIELD(ah, AR_PHY_GEN_CTRL,
@@ -382,7 +382,7 @@ static void ar9003_hw_spur_ofdm_work(struct ath_hw *ah,
else
spur_subchannel_sd = 1;
- spur_freq_sd = (freq_offset << 9) / 11;
+ spur_freq_sd = ((freq_offset - 10) << 9) / 11;
}
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003"
2012-04-28 6:28 [PATCH] Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003" Rajkumar Manoharan
@ 2012-04-30 18:22 ` John W. Linville
2012-05-01 3:21 ` Rajkumar Manoharan
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2012-04-30 18:22 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linux-wireless, Madhan Jaganathan, Kai Shi
On Sat, Apr 28, 2012 at 11:58:41AM +0530, Rajkumar Manoharan wrote:
> This reverts commit a844adfd7bee4edc66d337de6c33b348e83552a8.
>
> spur_freq_sd (for self-corr in AGC) is defined with respect to the
> center of each 20MHz channel while spur_phase_delta (for self-corr
> in Rx and spur data filter) is defined with respect to the center
> of current RF channel.
>
> So in short, we need to subtract spur_freq_sd (for self-corr in AGC)
> by the offset between the center of primary20 and the center of RF
> channel in SW. This offset could be +/10 MHz for dynamic 40.
>
> Cc: Madhan Jaganathan <madhanj@qca.qualcomm.com>
> Signed-off-by: Kai Shi <kaishi@qca.qualcomm.com>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
What actual bug is this causing? Should this be applied to 3.4?
> ---
> drivers/net/wireless/ath/ath9k/ar9003_phy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> index 5358553..11abb97 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> @@ -373,7 +373,7 @@ static void ar9003_hw_spur_ofdm_work(struct ath_hw *ah,
> else
> spur_subchannel_sd = 0;
>
> - spur_freq_sd = (freq_offset << 9) / 11;
> + spur_freq_sd = ((freq_offset + 10) << 9) / 11;
>
> } else {
> if (REG_READ_FIELD(ah, AR_PHY_GEN_CTRL,
> @@ -382,7 +382,7 @@ static void ar9003_hw_spur_ofdm_work(struct ath_hw *ah,
> else
> spur_subchannel_sd = 1;
>
> - spur_freq_sd = (freq_offset << 9) / 11;
> + spur_freq_sd = ((freq_offset - 10) << 9) / 11;
>
> }
>
> --
> 1.7.10
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003"
2012-04-30 18:22 ` John W. Linville
@ 2012-05-01 3:21 ` Rajkumar Manoharan
0 siblings, 0 replies; 3+ messages in thread
From: Rajkumar Manoharan @ 2012-05-01 3:21 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Madhan Jaganathan, Kai Shi
On Mon, Apr 30, 2012 at 02:22:01PM -0400, John W. Linville wrote:
> On Sat, Apr 28, 2012 at 11:58:41AM +0530, Rajkumar Manoharan wrote:
> > This reverts commit a844adfd7bee4edc66d337de6c33b348e83552a8.
> >
> > spur_freq_sd (for self-corr in AGC) is defined with respect to the
> > center of each 20MHz channel while spur_phase_delta (for self-corr
> > in Rx and spur data filter) is defined with respect to the center
> > of current RF channel.
> >
> > So in short, we need to subtract spur_freq_sd (for self-corr in AGC)
> > by the offset between the center of primary20 and the center of RF
> > channel in SW. This offset could be +/10 MHz for dynamic 40.
> >
> > Cc: Madhan Jaganathan <madhanj@qca.qualcomm.com>
> > Signed-off-by: Kai Shi <kaishi@qca.qualcomm.com>
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
>
> What actual bug is this causing? Should this be applied to 3.4?
>
The original commmit is causing low rate's sensitivity degrade in ht40
mode. Will send v2 patch with updated commit log. And yes it should be
applied to 3.4.
-Rajkumar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-01 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-28 6:28 [PATCH] Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003" Rajkumar Manoharan
2012-04-30 18:22 ` John W. Linville
2012-05-01 3:21 ` Rajkumar Manoharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.