* [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again.
@ 2012-04-29 11:57 Hans Verkuil
2012-04-29 23:51 ` Andy Walls
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2012-04-29 11:57 UTC (permalink / raw)
To: linux-media; +Cc: andrea.merello
Hi all,
I managed to get hold of a cpia2-based Hanse USB microscope almost a year
ago after reports from Andrea that the driver didn't work properly.
I finally had time to take a really good look at the driver and it was
broken in many respects. This patch brings the driver up to speed with
respect to the v4l2 framework and it now works as expected, including
disconnect handling and suspend/resume handling.
The only thing left to do some day is to convert it to the videobuf2
framework.
Regards,
Hans
The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
[media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git cpia2
for you to fetch changes up to 14a3d232eb5d25c768f40fbd6a87db48a249a391:
cpia2: major overhaul to get it in a working state again. (2012-04-29 13:44:44 +0200)
----------------------------------------------------------------
Hans Verkuil (1):
cpia2: major overhaul to get it in a working state again.
drivers/media/video/cpia2/cpia2.h | 34 ++-
drivers/media/video/cpia2/cpia2_core.c | 142 +++---------
drivers/media/video/cpia2/cpia2_usb.c | 78 +++++--
drivers/media/video/cpia2/cpia2_v4l.c | 846 +++++++++++++++++++++------------------------------------------------
drivers/media/video/cpia2/cpia2dev.h | 50 -----
5 files changed, 363 insertions(+), 787 deletions(-)
delete mode 100644 drivers/media/video/cpia2/cpia2dev.h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again.
2012-04-29 11:57 [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again Hans Verkuil
@ 2012-04-29 23:51 ` Andy Walls
2012-04-30 5:55 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Andy Walls @ 2012-04-29 23:51 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, andrea.merello
On Sun, 2012-04-29 at 13:57 +0200, Hans Verkuil wrote:
> Hi all,
>
> I managed to get hold of a cpia2-based Hanse USB microscope almost a year
> ago after reports from Andrea that the driver didn't work properly.
>
> I finally had time to take a really good look at the driver and it was
> broken in many respects. This patch brings the driver up to speed with
> respect to the v4l2 framework and it now works as expected, including
> disconnect handling and suspend/resume handling.
>
> The only thing left to do some day is to convert it to the videobuf2
> framework.
Hans,
cpia2_s_ctrl() doesn't seem to have a case for V4L2_CID_ILLUMINATORS_2.
Does control cluster magic take care of that?
Regards,
Andy
> Regards,
>
> Hans
>
> The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
>
> [media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300)
>
> are available in the git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git cpia2
>
> for you to fetch changes up to 14a3d232eb5d25c768f40fbd6a87db48a249a391:
>
> cpia2: major overhaul to get it in a working state again. (2012-04-29 13:44:44 +0200)
>
> ----------------------------------------------------------------
> Hans Verkuil (1):
> cpia2: major overhaul to get it in a working state again.
>
> drivers/media/video/cpia2/cpia2.h | 34 ++-
> drivers/media/video/cpia2/cpia2_core.c | 142 +++---------
> drivers/media/video/cpia2/cpia2_usb.c | 78 +++++--
> drivers/media/video/cpia2/cpia2_v4l.c | 846 +++++++++++++++++++++------------------------------------------------
> drivers/media/video/cpia2/cpia2dev.h | 50 -----
> 5 files changed, 363 insertions(+), 787 deletions(-)
> delete mode 100644 drivers/media/video/cpia2/cpia2dev.h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again.
2012-04-29 23:51 ` Andy Walls
@ 2012-04-30 5:55 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2012-04-30 5:55 UTC (permalink / raw)
To: Andy Walls; +Cc: linux-media, andrea.merello
On Monday, April 30, 2012 01:51:20 Andy Walls wrote:
> On Sun, 2012-04-29 at 13:57 +0200, Hans Verkuil wrote:
> > Hi all,
> >
> > I managed to get hold of a cpia2-based Hanse USB microscope almost a year
> > ago after reports from Andrea that the driver didn't work properly.
> >
> > I finally had time to take a really good look at the driver and it was
> > broken in many respects. This patch brings the driver up to speed with
> > respect to the v4l2 framework and it now works as expected, including
> > disconnect handling and suspend/resume handling.
> >
> > The only thing left to do some day is to convert it to the videobuf2
> > framework.
>
> Hans,
>
> cpia2_s_ctrl() doesn't seem to have a case for V4L2_CID_ILLUMINATORS_2.
> Does control cluster magic take care of that?
Correct, the two illuminator controls are clustered so only the 'master
control' (ILLUMINATORS_1) shows up in the switch.
Regards,
Hans
>
> Regards,
> Andy
>
> > Regards,
> >
> > Hans
> >
> > The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
> >
> > [media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300)
> >
> > are available in the git repository at:
> >
> > git://linuxtv.org/hverkuil/media_tree.git cpia2
> >
> > for you to fetch changes up to 14a3d232eb5d25c768f40fbd6a87db48a249a391:
> >
> > cpia2: major overhaul to get it in a working state again. (2012-04-29 13:44:44 +0200)
> >
> > ----------------------------------------------------------------
> > Hans Verkuil (1):
> > cpia2: major overhaul to get it in a working state again.
> >
> > drivers/media/video/cpia2/cpia2.h | 34 ++-
> > drivers/media/video/cpia2/cpia2_core.c | 142 +++---------
> > drivers/media/video/cpia2/cpia2_usb.c | 78 +++++--
> > drivers/media/video/cpia2/cpia2_v4l.c | 846 +++++++++++++++++++++------------------------------------------------
> > drivers/media/video/cpia2/cpia2dev.h | 50 -----
> > 5 files changed, 363 insertions(+), 787 deletions(-)
> > delete mode 100644 drivers/media/video/cpia2/cpia2dev.h
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-30 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-29 11:57 [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again Hans Verkuil
2012-04-29 23:51 ` Andy Walls
2012-04-30 5:55 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.