* [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit
@ 2012-05-01 15:19 Guenter Roeck
2012-05-01 15:58 ` Jean Delvare
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-05-01 15:19 UTC (permalink / raw)
To: lm-sensors
CPU core ID is used to index the core_data[] array. The core ID is, however, not
sequential; 10-core CPUS can have a core ID as high as 25. Increase the limit to
32 to be able to deal with current CPUs.
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: stable@vger.kernel.org # 3.0+
---
drivers/hwmon/coretemp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 54a70fe..b9d5123 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
#define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
-#define NUM_REAL_CORES 16 /* Number of Real cores per cpu */
+#define NUM_REAL_CORES 32 /* Number of Real cores per cpu */
#define CORETEMP_NAME_LENGTH 17 /* String Length of attrs */
#define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
#define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
--
1.7.9.48.g85da4d
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit
2012-05-01 15:19 [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit Guenter Roeck
@ 2012-05-01 15:58 ` Jean Delvare
2012-05-01 16:00 ` R, Durgadoss
2012-05-01 16:14 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2012-05-01 15:58 UTC (permalink / raw)
To: lm-sensors
On Tue, 1 May 2012 08:19:53 -0700, Guenter Roeck wrote:
> CPU core ID is used to index the core_data[] array. The core ID is, however, not
> sequential; 10-core CPUS can have a core ID as high as 25. Increase the limit to
> 32 to be able to deal with current CPUs.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> Cc: stable@vger.kernel.org # 3.0+
> ---
> drivers/hwmon/coretemp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 54a70fe..b9d5123 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
> MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
>
> #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
> -#define NUM_REAL_CORES 16 /* Number of Real cores per cpu */
> +#define NUM_REAL_CORES 32 /* Number of Real cores per cpu */
> #define CORETEMP_NAME_LENGTH 17 /* String Length of attrs */
> #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
> #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
Acked-by: Jean Delvare <khali@linux-fr.org>
Looking forward, it would be great if we could get rid of this
arbitrary limit.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit
2012-05-01 15:19 [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit Guenter Roeck
2012-05-01 15:58 ` Jean Delvare
@ 2012-05-01 16:00 ` R, Durgadoss
2012-05-01 16:14 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: R, Durgadoss @ 2012-05-01 16:00 UTC (permalink / raw)
To: lm-sensors
Thanks for the Nice, Quick Fix Guenter.
> -----Original Message-----
> From: lm-sensors-bounces@lm-sensors.org [mailto:lm-sensors-bounces@lm-
> sensors.org] On Behalf Of Guenter Roeck
> Sent: Tuesday, May 01, 2012 8:50 PM
> To: lm-sensors
> Subject: [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit
>
> CPU core ID is used to index the core_data[] array. The core ID is, however, not
> sequential; 10-core CPUS can have a core ID as high as 25. Increase the limit to
> 32 to be able to deal with current CPUs.
>
Acked-by: Durgadoss R <durgadoss.r@intel.com>
Thanks,
Durga
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> Cc: stable@vger.kernel.org # 3.0+
> ---
> drivers/hwmon/coretemp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 54a70fe..b9d5123 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
> MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
>
> #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp
> */
> -#define NUM_REAL_CORES 16 /* Number of Real cores per cpu
> */
> +#define NUM_REAL_CORES 32 /* Number of Real cores per cpu
> */
> #define CORETEMP_NAME_LENGTH 17 /* String Length of attrs */
> #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
> #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
> --
> 1.7.9.48.g85da4d
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit
2012-05-01 15:19 [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit Guenter Roeck
2012-05-01 15:58 ` Jean Delvare
2012-05-01 16:00 ` R, Durgadoss
@ 2012-05-01 16:14 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-05-01 16:14 UTC (permalink / raw)
To: lm-sensors
On Tue, 2012-05-01 at 11:58 -0400, Jean Delvare wrote:
> On Tue, 1 May 2012 08:19:53 -0700, Guenter Roeck wrote:
> > CPU core ID is used to index the core_data[] array. The core ID is, however, not
> > sequential; 10-core CPUS can have a core ID as high as 25. Increase the limit to
> > 32 to be able to deal with current CPUs.
> >
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > Cc: stable@vger.kernel.org # 3.0+
> > ---
> > drivers/hwmon/coretemp.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index 54a70fe..b9d5123 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
> > MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
> >
> > #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
> > -#define NUM_REAL_CORES 16 /* Number of Real cores per cpu */
> > +#define NUM_REAL_CORES 32 /* Number of Real cores per cpu */
> > #define CORETEMP_NAME_LENGTH 17 /* String Length of attrs */
> > #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
> > #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> Looking forward, it would be great if we could get rid of this
> arbitrary limit.
>
Agreed. I thought about dynamic allocation and a small hash table to
access it. If/when I have time ... or someone else, maybe.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-01 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-01 15:19 [lm-sensors] [PATCH] hwmon: (coretemp) Increase CPU core limit Guenter Roeck
2012-05-01 15:58 ` Jean Delvare
2012-05-01 16:00 ` R, Durgadoss
2012-05-01 16:14 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.