From: Ian Campbell <Ian.Campbell@citrix.com>
To: Goncalo Gomes <Goncalo.Gomes@EU.CITRIX.COM>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 4 of 6] xl: move vncviewer function closer to the start of file so it can be seen by create_domain
Date: Tue, 8 May 2012 11:00:49 +0100 [thread overview]
Message-ID: <1336471249.14542.39.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <0663afbb57f586cea07f.1336353619@dt29.uk.xensource.com>
On Mon, 2012-05-07 at 02:20 +0100, Goncalo Gomes wrote:
> Signed-off-by: Goncalo Gomes <Goncalo.Gomes@EU.CITRIX.COM>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> diff -r 497a6061df08 -r 0663afbb57f5 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c Mon May 07 01:10:58 2012 +0000
> +++ b/tools/libxl/xl_cmdimpl.c Mon May 07 01:10:58 2012 +0000
> @@ -186,6 +186,14 @@ static void find_domain(const char *p)
> common_domname = was_name ? p : libxl_domid_to_name(ctx, domid);
> }
>
> +static int vncviewer(const char *domain_spec, int autopass)
> +{
> + find_domain(domain_spec);
> + libxl_vncviewer_exec(ctx, domid, autopass);
> + fprintf(stderr, "Unable to execute vncviewer\n");
> + return 1;
> +}
> +
> static int acquire_lock(void)
> {
> int rc;
> @@ -2170,14 +2178,6 @@ int main_console(int argc, char **argv)
> return 1;
> }
>
> -static int vncviewer(const char *domain_spec, int autopass)
> -{
> - find_domain(domain_spec);
> - libxl_vncviewer_exec(ctx, domid, autopass);
> - fprintf(stderr, "Unable to execute vncviewer\n");
> - return 1;
> -}
> -
> int main_vncviewer(int argc, char **argv)
> {
> static const struct option long_options[] = {
next prev parent reply other threads:[~2012-05-08 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 1:20 [PATCH 0 of 6] Add vncviewer xm compatibility options Goncalo Gomes
2012-05-07 1:20 ` [PATCH 1 of 6] Update xl man page to include vncviewer options Goncalo Gomes
2012-05-08 9:58 ` Ian Campbell
2012-05-08 10:13 ` Goncalo Gomes
2012-05-07 1:20 ` [PATCH 2 of 6] Update xl.cfg man page to introduce new config option Goncalo Gomes
2012-05-10 15:47 ` Ian Jackson
2012-05-07 1:20 ` [PATCH 3 of 6] libxl: add vncviewer boolean options Goncalo Gomes
2012-05-08 10:00 ` Ian Campbell
2012-05-07 1:20 ` [PATCH 4 of 6] xl: move vncviewer function closer to the start of file so it can be seen by create_domain Goncalo Gomes
2012-05-08 10:00 ` Ian Campbell [this message]
2012-05-07 1:20 ` [PATCH 5 of 6] xl: Add vncviewer options to create and restore Goncalo Gomes
2012-05-08 10:04 ` Ian Campbell
2012-05-07 1:20 ` [PATCH 6 of 6] xl: extend the help options of the create and restore commands Goncalo Gomes
2012-05-10 15:48 ` Ian Jackson
2012-05-08 10:30 ` [PATCH 0 of 6] Add vncviewer xm compatibility options Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336471249.14542.39.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Goncalo.Gomes@EU.CITRIX.COM \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.