All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Goncalo Gomes <Goncalo.Gomes@EU.CITRIX.COM>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 5 of 6] xl: Add vncviewer options to create and restore
Date: Tue, 8 May 2012 11:04:20 +0100	[thread overview]
Message-ID: <1336471460.14542.42.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <ed41714d9ce9bc73b792.1336353620@dt29.uk.xensource.com>

On Mon, 2012-05-07 at 02:20 +0100, Goncalo Gomes wrote:
> @@ -1734,6 +1739,14 @@ start:
>      if (!daemonize && !monitor)
>          goto out;
>  
> +    if (vnc || (libxl_defbool_val(d_config.b_info.vncviewer) == 1)) {

I think this can be just "if (vnc)", per my previous comment about
including this in the libxl API.

> +        char *domspec = libxl_domid_to_name(ctx, domid);

Error out if this fails? But...

vncviewer will immediately call "find_domain(domain_spec)" to turn this
back into a domid. I think you'd be better to make that function take a
domid and pull the find_domain call up into main_vncviewer.

> +        if (domspec) {
> +            vncviewer(domspec, vncautopass);
> +            free(domsec);
> +        }
> +    }
> +
>      if (need_daemon) {
>          char *fullname, *name;
>          pid_t child1, got_child;

Ian.

  reply	other threads:[~2012-05-08 10:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07  1:20 [PATCH 0 of 6] Add vncviewer xm compatibility options Goncalo Gomes
2012-05-07  1:20 ` [PATCH 1 of 6] Update xl man page to include vncviewer options Goncalo Gomes
2012-05-08  9:58   ` Ian Campbell
2012-05-08 10:13     ` Goncalo Gomes
2012-05-07  1:20 ` [PATCH 2 of 6] Update xl.cfg man page to introduce new config option Goncalo Gomes
2012-05-10 15:47   ` Ian Jackson
2012-05-07  1:20 ` [PATCH 3 of 6] libxl: add vncviewer boolean options Goncalo Gomes
2012-05-08 10:00   ` Ian Campbell
2012-05-07  1:20 ` [PATCH 4 of 6] xl: move vncviewer function closer to the start of file so it can be seen by create_domain Goncalo Gomes
2012-05-08 10:00   ` Ian Campbell
2012-05-07  1:20 ` [PATCH 5 of 6] xl: Add vncviewer options to create and restore Goncalo Gomes
2012-05-08 10:04   ` Ian Campbell [this message]
2012-05-07  1:20 ` [PATCH 6 of 6] xl: extend the help options of the create and restore commands Goncalo Gomes
2012-05-10 15:48   ` Ian Jackson
2012-05-08 10:30 ` [PATCH 0 of 6] Add vncviewer xm compatibility options Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336471460.14542.42.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Goncalo.Gomes@EU.CITRIX.COM \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.