All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Felipe Balbi <balbi@ti.com>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	Russ Dill <Russ.Dill@ti.com>,
	Igor Grinberg <grinberg@compulab.co.il>
Subject: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path
Date: Wed,  9 May 2012 10:31:35 +0300	[thread overview]
Message-ID: <1336548695-6412-1-git-send-email-grinberg@compulab.co.il> (raw)
In-Reply-To: <20120508162436.GA10200@kroah.com>

When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
 drivers/usb/host/ehci-omap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 5c78f9e..26e9241 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 		udelay(10);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[0]))
-			gpio_set_value(pdata->reset_gpio_port[0], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[1]))
-			gpio_set_value(pdata->reset_gpio_port[1], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
 	}
 
 	return 0;
-- 
1.7.3.4


      parent reply	other threads:[~2012-05-09  7:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 14:08 [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path Igor Grinberg
2012-03-28  8:52 ` Felipe Balbi
2012-03-28 10:53   ` Raja, Govindraj
     [not found]     ` <CAMrsUdJjwAN4haHOkrGfrpb9HnbsMLyUE4a5aLnCPKC2JdUt_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-28 11:33       ` Igor Grinberg
2012-03-28 12:01     ` Munegowda, Keshava
     [not found] ` <4F72E1F9.3020400@ti.com>
2012-03-28 11:13   ` Igor Grinberg
2012-03-28 13:04     ` Shubhrajyoti Datta
2012-04-19 14:10 ` Igor Grinberg
     [not found]   ` <4F901CCC.9000703-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-04-19 15:01     ` Alan Stern
2012-04-20 11:57       ` Felipe Balbi
2012-05-06  6:25         ` Igor Grinberg
2012-05-07  8:09           ` Samuel Ortiz
2012-05-07 11:46             ` Igor Grinberg
     [not found]               ` <4FA7B61B.3020604-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 12:17                 ` Samuel Ortiz
     [not found]           ` <4FA61941.5080603-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 14:04             ` Alan Stern
2012-05-07 14:27               ` Igor Grinberg
     [not found]                 ` <4FA7DBE6.3060809-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 14:48                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1205071046350.1602-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-05-08  7:53                       ` Igor Grinberg
     [not found]                         ` <4FA8D108.7090004-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-08 16:24                           ` Greg Kroah-Hartman
2012-05-09  6:25                             ` Igor Grinberg
2012-05-09  7:31                             ` Igor Grinberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336548695-6412-1-git-send-email-grinberg@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=Russ.Dill@ti.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.