All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
To: "Raja, Govindraj" <govindraj.raja-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path
Date: Wed, 28 Mar 2012 13:33:49 +0200	[thread overview]
Message-ID: <4F72F71D.5080406@compulab.co.il> (raw)
In-Reply-To: <CAMrsUdJjwAN4haHOkrGfrpb9HnbsMLyUE4a5aLnCPKC2JdUt_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 03/28/12 12:53, Raja, Govindraj wrote:
> On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
>> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote:
>>> When PHY reset pin is connected to a GPIO on external GPIO chip
>>> (e.g. I2C), we should not call the gpio_set_value() function, but
>>> gpio_set_value_cansleep().
>>>
>>> Signed-off-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>>
>> Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>>
>> Keshava, please give us your tested-by. Patch looks fine to me.
> 
> Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller
> relies gpio nreset sequence for initialization.
> 
> Both hub + Ethernet controller get enumerated even after this patch.
> 
> Tested-by: Govindraj.R <govindraj.raja-l0cyMroinI0@public.gmane.org>

Thanks Raja.


-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-03-28 11:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 14:08 [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path Igor Grinberg
2012-03-28  8:52 ` Felipe Balbi
2012-03-28 10:53   ` Raja, Govindraj
     [not found]     ` <CAMrsUdJjwAN4haHOkrGfrpb9HnbsMLyUE4a5aLnCPKC2JdUt_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-28 11:33       ` Igor Grinberg [this message]
2012-03-28 12:01     ` Munegowda, Keshava
     [not found] ` <4F72E1F9.3020400@ti.com>
2012-03-28 11:13   ` Igor Grinberg
2012-03-28 13:04     ` Shubhrajyoti Datta
2012-04-19 14:10 ` Igor Grinberg
     [not found]   ` <4F901CCC.9000703-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-04-19 15:01     ` Alan Stern
2012-04-20 11:57       ` Felipe Balbi
2012-05-06  6:25         ` Igor Grinberg
2012-05-07  8:09           ` Samuel Ortiz
2012-05-07 11:46             ` Igor Grinberg
     [not found]               ` <4FA7B61B.3020604-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 12:17                 ` Samuel Ortiz
     [not found]           ` <4FA61941.5080603-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 14:04             ` Alan Stern
2012-05-07 14:27               ` Igor Grinberg
     [not found]                 ` <4FA7DBE6.3060809-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-07 14:48                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1205071046350.1602-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-05-08  7:53                       ` Igor Grinberg
     [not found]                         ` <4FA8D108.7090004-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2012-05-08 16:24                           ` Greg Kroah-Hartman
2012-05-09  6:25                             ` Igor Grinberg
2012-05-09  7:31                             ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F72F71D.5080406@compulab.co.il \
    --to=grinberg-utxizqzc01rs1mouv/rt9w@public.gmane.org \
    --cc=Keshava_mgowda-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=govindraj.raja-l0cyMroinI0@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.