All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, Heinz.Egger@linutronix.de,
	tim.bird@am.sony.com
Subject: Re: [RFC v4] UBI: Fastmap support (aka checkpointing)
Date: Wed, 16 May 2012 14:18:03 +0300	[thread overview]
Message-ID: <1337167083.24809.49.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1337166556.24809.42.camel@sauron.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Wed, 2012-05-16 at 14:09 +0300, Artem Bityutskiy wrote:
> > The maximum size of a fastmap is limited to UBI_FM_MAX_BLOCKS.
> > As I said, in worst case we'd have to scan 192 PEBs, which is a constant.
> 
> In this case you cannot use O notation at all because it is just used
> when talking about asymptotic things.

OK, we are talking about different things. It is fine that you need to
scan 192 eraseblocks, this is kind of your journal. And this part may be
O(1). But there is another part as well.

But as I already explained, you have a _table_ on the flash, and this
table stores Erase Counter and LEB number for (roughly) each PEB. The
more PEBs, the large is the table, linerarly.

As I explained, you have to _read_ and _interpret_ each record in this
table when attaching. And the more of these records you have, the longer
it takes to attach. And this is where you have your O(N).

So basically fastmap makes UBI's linerar dependency multiplier a lot
smaller, so it is still a great improvement.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: Heinz.Egger@linutronix.de, tglx@linutronix.de,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	tim.bird@am.sony.com
Subject: Re: [RFC v4] UBI: Fastmap support (aka checkpointing)
Date: Wed, 16 May 2012 14:18:03 +0300	[thread overview]
Message-ID: <1337167083.24809.49.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1337166556.24809.42.camel@sauron.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

On Wed, 2012-05-16 at 14:09 +0300, Artem Bityutskiy wrote:
> > The maximum size of a fastmap is limited to UBI_FM_MAX_BLOCKS.
> > As I said, in worst case we'd have to scan 192 PEBs, which is a constant.
> 
> In this case you cannot use O notation at all because it is just used
> when talking about asymptotic things.

OK, we are talking about different things. It is fine that you need to
scan 192 eraseblocks, this is kind of your journal. And this part may be
O(1). But there is another part as well.

But as I already explained, you have a _table_ on the flash, and this
table stores Erase Counter and LEB number for (roughly) each PEB. The
more PEBs, the large is the table, linerarly.

As I explained, you have to _read_ and _interpret_ each record in this
table when attaching. And the more of these records you have, the longer
it takes to attach. And this is where you have your O(N).

So basically fastmap makes UBI's linerar dependency multiplier a lot
smaller, so it is still a great improvement.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-05-16 11:14 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 17:11 [RFC v4] UBI: Fastmap support (aka checkpointing) Richard Weinberger
2012-05-15 17:11 ` Richard Weinberger
2012-05-15 17:11 ` [PATCH 1/7] [RFC] UBI: Export next_sqnum() Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-16 13:01   ` Artem Bityutskiy
2012-05-16 13:01     ` Artem Bityutskiy
2012-05-21 13:34     ` Richard Weinberger
2012-05-21 13:34       ` Richard Weinberger
2012-05-21 14:00       ` Artem Bityutskiy
2012-05-21 14:00         ` Artem Bityutskiy
2012-05-21 14:16         ` Richard Weinberger
2012-05-21 14:16           ` Richard Weinberger
2012-05-22  8:23           ` Artem Bityutskiy
2012-05-22  8:23             ` Artem Bityutskiy
2012-05-22 10:58       ` Artem Bityutskiy
2012-05-22 10:58         ` Artem Bityutskiy
2012-05-16 14:03   ` Shmulik Ladkani
2012-05-16 14:03     ` Shmulik Ladkani
2012-05-16 14:27     ` Artem Bityutskiy
2012-05-16 14:27       ` Artem Bityutskiy
2012-05-17  9:45       ` Shmulik Ladkani
2012-05-17  9:45         ` Shmulik Ladkani
2012-05-17 11:44         ` Artem Bityutskiy
2012-05-17 11:44           ` Artem Bityutskiy
2012-05-17 11:47           ` Richard Weinberger
2012-05-17 11:47             ` Richard Weinberger
2012-05-17 12:34             ` Artem Bityutskiy
2012-05-17 12:34               ` Artem Bityutskiy
2012-05-15 17:11 ` [PATCH 2/7] [RFC] UBI: Export compare_lebs() Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-16 14:09   ` Shmulik Ladkani
2012-05-16 14:09     ` Shmulik Ladkani
2012-05-15 17:11 ` [PATCH 3/7] [RFC] UBI: Add fastmap on-flash layout Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-15 17:11 ` [PATCH 4/7] [RFC] UBI: Add fastmap structs to ubi_device Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-15 17:11 ` [PATCH 5/7] [RFC] UBI: Make wl subsystem fastmap aware Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-15 17:11 ` [PATCH 6/7] [RFC] UBI: Implement fastmapping support Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-15 17:11 ` [PATCH 7/7] [RFC] UBI: Wire up fastmap support Richard Weinberger
2012-05-15 17:11   ` Richard Weinberger
2012-05-15 17:48 ` [RFC v4] UBI: Fastmap support (aka checkpointing) Subodh Nijsure
2012-05-15 17:48   ` Subodh Nijsure
2012-05-15 18:10   ` Richard Weinberger
2012-05-15 18:10     ` Richard Weinberger
2012-05-15 18:02 ` Richard Weinberger
2012-05-15 18:02   ` Richard Weinberger
2012-05-15 19:46 ` Shmulik Ladkani
2012-05-15 19:46   ` Shmulik Ladkani
2012-05-16  6:54   ` Fastmap - please, review and test Artem Bityutskiy
2012-05-16  6:54     ` Artem Bityutskiy
2012-05-16 11:51     ` Richard Weinberger
2012-05-16 11:51       ` Richard Weinberger
2012-05-16  9:38 ` [RFC v4] UBI: Fastmap support (aka checkpointing) Artem Bityutskiy
2012-05-16  9:38   ` Artem Bityutskiy
2012-05-16  9:42   ` Artem Bityutskiy
2012-05-16  9:42     ` Artem Bityutskiy
2012-05-16 10:50   ` Richard Weinberger
2012-05-16 10:50     ` Richard Weinberger
2012-05-16 11:09     ` Artem Bityutskiy
2012-05-16 11:09       ` Artem Bityutskiy
2012-05-16 11:18       ` Artem Bityutskiy [this message]
2012-05-16 11:18         ` Artem Bityutskiy
2012-05-16 11:29         ` Richard Weinberger
2012-05-16 11:29           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337167083.24809.49.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=Heinz.Egger@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.