* [Buildroot] [PATCH v4 01/22] legal-info: infrastructure to collect legally-relevant material
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-21 21:21 ` Arnout Vandecappelle
2012-05-17 17:33 ` [Buildroot] [PATCH v4 02/22] gettext: warn that legal-info is not implemented Luca Ceresoli
` (23 subsequent siblings)
24 siblings, 1 reply; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
This allows to automatically collect material that may be needed to comply with
the license of packages that Buildroot prepares for the target device.
The core of the implementation is made by the following parts:
- in package/pkg-utils.mk some helper functions are defined for common actions
such as generating a warning, producing info about a package etc;
- in package/pkg-gentargets.mk, within the GENTARGETS framework, a new
<PKG>-legal-info target produces all the info for a given package;
- Makefile implements the top-level targets:
- legal-info-prepare creates the output directory and produces legal info
about Buildroot itself and the toolchain, which mostly means just warning
the user that this is not implemented;
- legal-info, the only target that is supposed to be used directly, depends
on all of the above and finishes things by producing the README files from
the various pieces.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
Makefile | 42 ++++++++++++++++++--
package/pkg-gentargets.mk | 61 +++++++++++++++++++++++++++++
package/pkg-utils.mk | 25 ++++++++++++
| 24 ++++++++++++
| 4 ++
5 files changed, 153 insertions(+), 3 deletions(-)
create mode 100644 support/legal-info/README.header
create mode 100644 support/legal-info/README.warnings-header
diff --git a/Makefile b/Makefile
index 96f9412..28af586 100644
--- a/Makefile
+++ b/Makefile
@@ -250,6 +250,14 @@ TARGET_DIR:=$(BASE_DIR)/target
TOOLCHAIN_DIR=$(BASE_DIR)/toolchain
TARGET_SKELETON=$(TOPDIR)/fs/skeleton
+LEGAL_INFO_DIR=$(BASE_DIR)/legal-info
+REDIST_SOURCES_DIR=$(LEGAL_INFO_DIR)/sources
+LICENSE_FILES_DIR=$(LEGAL_INFO_DIR)/licenses
+LEGAL_MANIFEST_CSV=$(LEGAL_INFO_DIR)/manifest.csv
+LEGAL_LICENSES_TXT=$(LEGAL_INFO_DIR)/licenses.txt
+LEGAL_WARNINGS=$(LEGAL_INFO_DIR)/.warnings
+LEGAL_REPORT=$(LEGAL_INFO_DIR)/README
+
ifeq ($(BR2_CCACHE),y)
CCACHE:=$(HOST_DIR)/usr/bin/ccache
CCACHE_CACHE_DIR=$(HOME)/.buildroot-ccache
@@ -330,6 +338,9 @@ HOST_DEPS = $(sort $(foreach dep,\
$($(dep))))
HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
+TARGETS_LEGAL_INFO:=$(patsubst %,%-legal-info,\
+ $(TARGETS) $(BASE_TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
+
# all targets depend on the crosscompiler and it's prerequisites
$(TARGETS_ALL): __real_tgt_%: $(BASE_TARGETS) %
@@ -346,8 +357,9 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
.PHONY: all world dirs clean distclean source outputmakefile \
+ legal-info legal-info-prepare legal-info-clean \
$(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \
- $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) \
+ $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
$(DL_DIR) $(TOOLCHAIN_DIR) $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
$(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)
@@ -357,7 +369,7 @@ world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
# dependencies anywhere else
#
#############################################################
-$(DL_DIR) $(TOOLCHAIN_DIR) $(BUILD_DIR) $(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR):
+$(DL_DIR) $(TOOLCHAIN_DIR) $(BUILD_DIR) $(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR) $(LEGAL_INFO_DIR) $(REDIST_SOURCES_DIR):
@mkdir -p $@
$(STAGING_DIR):
@@ -484,6 +496,28 @@ source: dirs $(TARGETS_SOURCE) $(HOST_SOURCE)
external-deps:
@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u
+legal-info-clean:
+ @rm -fr $(LEGAL_INFO_DIR)
+
+legal-info-prepare: $(LEGAL_INFO_DIR)
+ @$(call MESSAGE,"Collecting legal info")
+ @$(call legal-license-file,buildroot,COPYING,COPYING)
+ @$(call legal-manifest,PACKAGE,VERSION,LICENSE,LICENSE FILES,SOURCE ARCHIVE)
+ @$(call legal-manifest,buildroot,$(BR2_VERSION_FULL),GPLv2+,COPYING,not saved)
+ @$(call legal-warning,the Buildroot source code has not been saved)
+ @$(call legal-warning,the toolchain has not been saved)
+ @cp $(CONFIG_DIR)/.config $(LEGAL_INFO_DIR)/buildroot.config
+
+legal-info: dirs legal-info-clean legal-info-prepare $(REDIST_SOURCES_DIR) \
+ $(TARGETS_LEGAL_INFO)
+ @cat support/legal-info/README.header >>$(LEGAL_REPORT)
+ @if [ -r $(LEGAL_WARNINGS) ]; then \
+ cat support/legal-info/README.warnings-header \
+ $(LEGAL_WARNINGS) >>$(LEGAL_REPORT); \
+ cat $(LEGAL_WARNINGS); fi
+ @echo "Legal info produced in $(LEGAL_INFO_DIR)"
+ @rm -f $(LEGAL_WARNINGS)
+
show-targets:
@echo $(TARGETS)
@@ -605,7 +639,8 @@ endif
clean:
rm -rf $(STAGING_DIR) $(TARGET_DIR) $(BINARIES_DIR) $(HOST_DIR) \
- $(STAMP_DIR) $(BUILD_DIR) $(TOOLCHAIN_DIR) $(BASE_DIR)/staging
+ $(STAMP_DIR) $(BUILD_DIR) $(TOOLCHAIN_DIR) $(BASE_DIR)/staging \
+ $(LEGAL_INFO_DIR)
distclean: clean
ifeq ($(DL_DIR),$(TOPDIR)/dl)
@@ -673,6 +708,7 @@ endif
@echo ' source - download all sources needed for offline-build'
@echo ' source-check - check all packages for valid download URLs'
@echo ' external-deps - list external packages used'
+ @echo ' legal-info - generate info about license compliance'
@echo
@echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build'
@echo ' make O=dir - Locate all output files in "dir", including .config'
diff --git a/package/pkg-gentargets.mk b/package/pkg-gentargets.mk
index 1c9b458..80e6a3e 100644
--- a/package/pkg-gentargets.mk
+++ b/package/pkg-gentargets.mk
@@ -180,6 +180,7 @@ define GENTARGETS_INNER
$(2)_TYPE = $(5)
$(2)_NAME = $(1)
+$(2)_RAWNAME = $(patsubst host-%,%,$(1))
# Keep the package version that may contain forward slashes in the _DL_VERSION
# variable, then replace all forward slashes ('/') by underscores ('_') to
@@ -245,6 +246,20 @@ $(2)_OVERRIDE_SRCDIR = $($(2)_SITE)
endif
endif
+ifndef $(2)_LICENSE
+ ifdef $(3)_LICENSE
+ $(2)_LICENSE = $($(3)_LICENSE)
+ endif
+endif
+
+ifndef $(2)_LICENSE_FILES
+ ifdef $(3)_LICENSE_FILES
+ $(2)_LICENSE_FILES = $($(3)_LICENSE_FILES)
+ endif
+endif
+
+$(2)_LICENSE ?= unknown
+
$(2)_DEPENDENCIES ?= $(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES)))
$(2)_INSTALL_STAGING ?= NO
@@ -412,6 +427,52 @@ else
$(2)_KCONFIG_VAR = BR2_PACKAGE_$(2)
endif
+# legal-info: declare dependencies and set values used later for the manifest
+ifneq ($$($(2)_LICENSE),PROPRIETARY)
+ifneq ($$($(2)_SITE_METHOD),local)
+ifneq ($$($(2)_SITE_METHOD),override)
+# Packages that have a tarball need it downloaded and extracted beforehand
+$(1)-legal-info: $(1)-extract $(REDIST_SOURCES_DIR)
+$(2)_MANIFEST_TARBALL = $$($(2)_SOURCE)
+ifneq ($$($(2)_LICENSE_FILES),)
+$(2)_MANIFEST_LICENSE_FILES = $$($(2)_LICENSE_FILES)
+endif
+endif
+endif
+endif
+# defaults for packages without tarball or license files
+$(2)_MANIFEST_TARBALL ?= not saved
+$(2)_MANIFEST_LICENSE_FILES ?= not saved
+
+# legal-info: produce legally relevant info.
+$(1)-legal-info:
+# Packages without a source are assumed to be part of Buildroot, skip them.
+ifneq ($(call qstrip,$$($(2)_SOURCE)),)
+ifeq ($$($(2)_LICENSE),PROPRIETARY)
+# Proprietary packages: nothing to save
+else ifeq ($$($(2)_SITE_METHOD),local)
+# Packages without a tarball: don't save and warn
+ @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
+else ifeq ($$($(2)_SITE_METHOD),override)
+ @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
+else
+# Other packages
+# Save license files if defined
+ifeq ($(call qstrip,$$($(2)_LICENSE_FILES)),)
+ @$(call legal-license-nofiles,$$($(2)_RAWNAME))
+ @$(call legal-warning-pkg,$$($(2)_RAWNAME),cannot save license ($(2)_LICENSE_FILES not defined))
+else
+ @for F in $$($(2)_LICENSE_FILES); do \
+ $(call legal-license-file,$$($(2)_RAWNAME),$$$${F},$$($(2)_DIR)/$$$${F}); \
+ done
+endif
+# Copy the source tarball (just hardlink if possible)
+ @cp -l $(DL_DIR)/$$($(2)_SOURCE) $(REDIST_SOURCES_DIR) 2>/dev/null || \
+ cp $(DL_DIR)/$$($(2)_SOURCE) $(REDIST_SOURCES_DIR)
+endif
+ @$(call legal-manifest,$$($(2)_RAWNAME),$$($(2)_VERSION),$$($(2)_LICENSE),$$($(2)_MANIFEST_LICENSE_FILES),$$($(2)_MANIFEST_TARBALL))
+endif # ifneq ($(call qstrip,$$($(2)_SOURCE)),)
+
# add package to the general list of targets if requested by the buildroot
# configuration
ifeq ($$($$($(2)_KCONFIG_VAR)),y)
diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index 953dbc9..43cc76c 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -83,3 +83,28 @@ define sep
endef
+
+#
+# legal-info helper functions
+#
+LEGAL_INFO_SEPARATOR="::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::"
+legal-warning=echo "WARNING: $(1)" >>$(LEGAL_WARNINGS)
+legal-warning-pkg=echo "WARNING: $(1): $(2)" >>$(LEGAL_WARNINGS)
+define legal-warning-pkg-savednothing # pkg, {local|override}
+ $(call legal-warning-pkg,$(1),sources and license files not saved ($(2) packages not handled))
+endef
+legal-manifest=echo "$(1),$(2),$(3),$(4),$(5)" >>$(LEGAL_MANIFEST_CSV)
+define legal-license-header
+ echo -e "$(LEGAL_INFO_SEPARATOR)\n\t$(1):" \
+ "$(2)\n$(LEGAL_INFO_SEPARATOR)\n\n" >>$(LEGAL_LICENSES_TXT)
+endef
+define legal-license-nofiles
+ $(call legal-license-header,$(1),unknown license file(s))
+endef
+define legal-license-file # pkg, filename, file-fullpath
+ $(call legal-license-header,$(1),$(2) file) && \
+ cat $(3) >>$(LEGAL_LICENSES_TXT) && \
+ echo >>$(LEGAL_LICENSES_TXT) && \
+ mkdir -p $(LICENSE_FILES_DIR)/$(1)/ && \
+ cp $(3) $(LICENSE_FILES_DIR)/$(1)/
+endef
--git a/support/legal-info/README.header b/support/legal-info/README.header
new file mode 100644
index 0000000..3321adb
--- /dev/null
+++ b/support/legal-info/README.header
@@ -0,0 +1,24 @@
+Most of the packages that were used by Buildroot to produce the image files,
+including Buildroot itself, have open-source licenses. It is your
+responsibility to comply to the requirements of these licenses.
+To make this easier for you, Buildroot collected in this directory some
+material you may need to get it done.
+
+This material is composed of the following items.
+ * The scripts used to control compilation of the packages and the generation
+ of image files, i.e. the Buildroot sources.
+ Note: this has not been saved due to technical limitations, you must
+ collect it manually.
+ * The Buildroot configuration file; this has been saved in buildroot.config.
+ * The toolchain (cross-compiler and related tools) used to generate all the
+ compiled programs.
+ Note: this has not been saved due to technical limitations, you must
+ collect it manually.
+ * The source code for all packages; this has been saved in the sources/
+ subdirectory (except for the proprietary packages, which have not been
+ saved); patches applied to some packages by Buildroot are included in the
+ Buildroot sources and were not duplicated in the sources/ subdirectory.
+ * A manifest file listing the configured packages and related information.
+ * The license text of the packages; they have been saved in the licenses/
+ subdirectory.
+
--git a/support/legal-info/README.warnings-header b/support/legal-info/README.warnings-header
new file mode 100644
index 0000000..cd08290
--- /dev/null
+++ b/support/legal-info/README.warnings-header
@@ -0,0 +1,4 @@
+Due to technical limitations or lack of license definition in the package
+makefile, some of the material listed above could not been saved, as the
+following list details.
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 01/22] legal-info: infrastructure to collect legally-relevant material
2012-05-17 17:33 ` [Buildroot] [PATCH v4 01/22] legal-info: infrastructure to collect legally-relevant material Luca Ceresoli
@ 2012-05-21 21:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 37+ messages in thread
From: Arnout Vandecappelle @ 2012-05-21 21:21 UTC (permalink / raw)
To: buildroot
On 05/17/12 19:33, Luca Ceresoli wrote:
> This allows to automatically collect material that may be needed to comply with
> the license of packages that Buildroot prepares for the target device.
>
> The core of the implementation is made by the following parts:
> - in package/pkg-utils.mk some helper functions are defined for common actions
> such as generating a warning, producing info about a package etc;
> - in package/pkg-gentargets.mk, within the GENTARGETS framework, a new
> <PKG>-legal-info target produces all the info for a given package;
> - Makefile implements the top-level targets:
> - legal-info-prepare creates the output directory and produces legal info
> about Buildroot itself and the toolchain, which mostly means just warning
> the user that this is not implemented;
> - legal-info, the only target that is supposed to be used directly, depends
> on all of the above and finishes things by producing the README files from
> the various pieces.
>
> Signed-off-by: Luca Ceresoli<luca@lucaceresoli.net>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 02/22] gettext: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 01/22] legal-info: infrastructure to collect legally-relevant material Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 03/22] netkitbase: " Luca Ceresoli
` (22 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/gettext/gettext.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk
index f3605da..9778007 100644
--- a/package/gettext/gettext.mk
+++ b/package/gettext/gettext.mk
@@ -113,6 +113,9 @@ $(STAGING_DIR)/$(GETTEXT_TARGET_BINARY): $(GETTEXT_DIR)/$(GETTEXT_BINARY)
autopoint envsubst gettext.sh gettextize msg* ?gettext)
touch -c $@
+gettext-legal-info:
+ @$(call legal-warning-pkg,gettext,legal-info not yet implemented)
+
gettext: host-pkg-config $(if $(BR2_PACKAGE_LIBICONV),libiconv) $(STAGING_DIR)/$(GETTEXT_TARGET_BINARY)
gettext-unpacked: $(GETTEXT_DIR)/.unpacked
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 03/22] netkitbase: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 01/22] legal-info: infrastructure to collect legally-relevant material Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 02/22] gettext: warn that legal-info is not implemented Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 04/22] netkittelnet: " Luca Ceresoli
` (21 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/netkitbase/netkitbase.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/netkitbase/netkitbase.mk b/package/netkitbase/netkitbase.mk
index 83991f2..56480fc 100644
--- a/package/netkitbase/netkitbase.mk
+++ b/package/netkitbase/netkitbase.mk
@@ -47,6 +47,9 @@ $(TARGET_DIR)/$(NETKITBASE_TARGET_BINARY): $(NETKITBASE_DIR)/$(NETKITBASE_BINARY
fi
touch -c $(TARGET_DIR)/$(NETKITBASE_TARGET_BINARY)
+netkitbase-legal-info:
+ @$(call legal-warning-pkg,netkitbase,legal-info not yet implemented)
+
netkitbase: $(TARGET_DIR)/$(NETKITBASE_TARGET_BINARY)
netkitbase-clean:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 04/22] netkittelnet: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (2 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 03/22] netkitbase: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 05/22] newt: " Luca Ceresoli
` (20 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/netkittelnet/netkittelnet.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/netkittelnet/netkittelnet.mk b/package/netkittelnet/netkittelnet.mk
index ff05318..43ba324 100644
--- a/package/netkittelnet/netkittelnet.mk
+++ b/package/netkittelnet/netkittelnet.mk
@@ -48,6 +48,9 @@ $(TARGET_DIR)/$(NETKITTELNET_TARGET_BINARY): $(NETKITTELNET_DIR)/$(NETKITTELNET_
#rm -rf $(TARGET_DIR)/share/locale $(TARGET_DIR)/usr/info \
# $(TARGET_DIR)/usr/man $(TARGET_DIR)/usr/share/doc
+netkittelnet-legal-info:
+ @$(call legal-warning-pkg,netkittelnet,legal-info not yet implemented)
+
netkittelnet: netkitbase $(TARGET_DIR)/$(NETKITTELNET_TARGET_BINARY)
netkittelnet-clean:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 05/22] newt: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (3 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 04/22] netkittelnet: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 06/22] ttcp: " Luca Ceresoli
` (19 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/newt/newt.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/newt/newt.mk b/package/newt/newt.mk
index ac450e0..b10e4f8 100644
--- a/package/newt/newt.mk
+++ b/package/newt/newt.mk
@@ -58,6 +58,9 @@ $(TARGET_DIR)/usr/lib/libnewt.so.$(NEWT_VERSION): $(STAGING_DIR)/usr/lib/libnewt
-$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/lib/libnewt.so*
touch -c $@
+newt-legal-info:
+ @$(call legal-warning-pkg,newt,legal-info not yet implemented)
+
newt: slang $(TARGET_DIR)/usr/lib/libnewt.so.$(NEWT_VERSION)
newt-source: $(DL_DIR)/$(NEWT_SOURCE)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 06/22] ttcp: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (4 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 05/22] newt: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 07/22] vpnc: " Luca Ceresoli
` (18 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/ttcp/ttcp.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/ttcp/ttcp.mk b/package/ttcp/ttcp.mk
index 1acf120..080286b 100644
--- a/package/ttcp/ttcp.mk
+++ b/package/ttcp/ttcp.mk
@@ -27,6 +27,9 @@ $(TTCP_DIR)/ttcp: $(TTCP_DIR)/.configured
$(TARGET_DIR)/usr/bin/ttcp: $(TTCP_DIR)/ttcp
cp -af $(TTCP_DIR)/ttcp $(TARGET_DIR)/usr/bin/
+ttcp-legal-info:
+ @$(call legal-warning-pkg,ttcp,legal-info not yet implemented)
+
ttcp: $(TARGET_DIR)/usr/bin/ttcp
ttcp-source: $(DL_DIR)/$(TTCP_SOURCE)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 07/22] vpnc: warn that legal-info is not implemented
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (5 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 06/22] ttcp: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 08/22] manual: document usage of the legal-info feature Luca Ceresoli
` (17 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/vpnc/vpnc.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/vpnc/vpnc.mk b/package/vpnc/vpnc.mk
index d8d9654..f585dc4 100644
--- a/package/vpnc/vpnc.mk
+++ b/package/vpnc/vpnc.mk
@@ -42,6 +42,9 @@ $(VPNC_TARGET_BINARY): $(VPNC_BINARY)
-C $(VPNC_DIR) install
$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(VPNC_TARGET_BINARY)
+vpnc-legal-info:
+ @$(call legal-warning-pkg,vpnc,legal-info not yet implemented)
+
vpnc: libgcrypt $(VPNC_TARGET_BINARY)
vpnc-source: $(DL_DIR)/$(VPNC_SOURCE)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 08/22] manual: document usage of the legal-info feature
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (6 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 07/22] vpnc: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot Luca Ceresoli
` (16 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
docs/manual/adding-packages-gentargets.txt | 21 ++++++
docs/manual/using.txt | 103 ++++++++++++++++++++++++++++
2 files changed, 124 insertions(+)
diff --git a/docs/manual/adding-packages-gentargets.txt b/docs/manual/adding-packages-gentargets.txt
index cfcee8c..7a7889e 100644
--- a/docs/manual/adding-packages-gentargets.txt
+++ b/docs/manual/adding-packages-gentargets.txt
@@ -218,6 +218,27 @@ information is (assuming the package name is +libfoo+) :
You can find some documentation for this syntax in the xref:makedev-syntax[].
This variable is optional.
+* +LIBFOO_LICENSE+ defines the license (or licenses) under which the package
+ is released.
+ This name will appear in the manifest file produced by +make legal-info+.
+ If the license is one of those listed in xref:legal-info[],
+ use the same string to make the manifest file uniform.
+ Otherwise, describe the license in a precise and concise way, avoiding
+ ambiguous names such as +BSD+ which actually name a family of licenses.
+ If the root filesystem you generate contains non-opensource packages, you
+ can define their license as +PROPRIETARY+: Buildroot will not save any
+ licensing info or source code for this package.
+ This variable is optional. If it is not defined, +unknown+ will appear in
+ the +license+ field of the manifest file for this package.
+
+* +LIBFOO_LICENSE_FILES+ is a space-separated list of files in the package
+ tarball that contain the license(s) under which the package is released.
+ +make legal-info+ copies all of these files in the +legal-info+ directory.
+ See xref:legal-info[] for more information.
+ This variable is optional. If it is not defined, a warning will be produced
+ to let you know, and +not saved+ will appear in the +license files+ field
+ of the manifest file for this package.
+
The recommended way to define these variables is to use the following
syntax:
diff --git a/docs/manual/using.txt b/docs/manual/using.txt
index a5dc9e1..42d4061 100644
--- a/docs/manual/using.txt
+++ b/docs/manual/using.txt
@@ -181,3 +181,106 @@ or +g+++ for building helper-binaries on your host, then do
--------------------
$ make HOSTCXX=g++-4.3-HEAD HOSTCC=gcc-4.3-HEAD
--------------------
+
+Complying with opensource licenses
+----------------------------------
+[[legal-info]]
+
+All of the end products of Buildroot (toolchain, root filesystem, kernel,
+bootloaders) contain opensource software, released under various licenses.
+
+Using opensource software gives you the freedom to build rich embedded
+systems choosing from a wide range of packages, but also gives some
+obligations that you must know and honour.
+Some licenses require you to publish the license text in the documentation of
+your product. Other require you to redistribute the source code of the
+software to those that receive your product.
+
+The exact requirements of each license is documented in each package, and it is
+your (or your legal office's) responsibility to comply with these requirements.
+To make this easier for you, Buildroot can collect for you some material you
+will probably need. To produce this material, after you configured Buildroot
+with +make menuconfig+, +make xconfig+ or +make gconfig+, run:
+
+--------------------
+make legal-info
+--------------------
+
+Buildroot will collect legally-relevant material in your output directory,
+under the +legal-info/+ subdirectory.
+There you will find:
+
+* A +README+ file, that summarizes the produced material and contains warnings
+ about material that Buildroot could not produce.
+* +buildroot.config+: this is the Buildroot configuration file that is usually
+ produced with +make menuconfig+, and which is necessary to reproduce the
+ build.
+* The source code for all packages; this is saved in the +sources/+
+ subdirectory (except for proprietary packages, whose source code is not
+ saved);
+ patches applied to some packages by Buildroot are distributed with the
+ Buildroot sources and are not duplicated in the +sources/+ subdirectory.
+* A manifest file listing the configured packages, their version, license and
+ related information.
+ Some of these information might be not defined in Buildroot; in this case
+ they are clearly marked as "unknown" or similar.
+* A +licenses/+ subdirectory, which contains the license text of packages.
+ If the license file(s) are not defined in Buildroot, the file is not produced
+ and a warning in the +README+ indicates this.
+
+Please note that the aim of the +legal-info+ feature of Buildroot is to
+produce all the material that is somehow relevant for legal compliance with the
+package licenses. Buildroot does not try to produce the exact material that
+you must somehow make public. It does surely produce some more material than is
+needed for a strict legal compliance. For example, it produces the source code
+for packages released under BSD-like licenses, that you might not want to
+redistribute in source form.
+
+Moreover, due to technical limitations, Buildroot does not produce some
+material that you will or may need, such as the toolchain source code and the
+Buildroot source code itself.
+When you run +make legal-info+, Buildroot produces warnings in the +README+
+file to inform you of relevant material that could not be saved.
+
+Here is a list of the licenses that are most widely used by packages in
+Buildroot, with the name used in the manifest file:
+
+* +GPLv2+:
+ http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[
+ GNU General Public License, version 2];
+* +GPLv2++:
+ http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[
+ GNU General Public License, version 2]
+ or (at your option) any later version;
+* +GPLv3+:
+ http://www.gnu.org/licenses/gpl.html[
+ GNU General Public License, version 3];
+* +GPLv3++:
+ http://www.gnu.org/licenses/gpl.html[
+ GNU General Public License, version 3]
+ or (at your option) any later version;
+* +GPL+:
+ http://www.gnu.org/licenses/gpl.html[
+ GNU General Public License] (any version);
+* +LGPLv2.1+:
+ http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html[
+ GNU Lesser General Public License, version 2.1];
+* +LGPLv2.1++:
+ http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html[
+ GNU Lesser General Public License, version 2.1]
+ or (at your option) any later version;
+* +LGPLv3+:
+ http://www.gnu.org/licenses/lgpl.html[
+ GNU Lesser General Public License, version 3];
+* +LGPLv3++:
+ http://www.gnu.org/licenses/lgpl.html[
+ GNU Lesser General Public License, version 3]
+ or (at your option) any later version;
+* +LGPL+:
+ http://www.gnu.org/licenses/lgpl.html[
+ GNU Lesser General Public License] (any version);
+* +BSD-4c+: Original BSD 4-clause license;
+* +BSD-3c+: BSD 3-clause license;
+* +BSD-2c+: BSD 2-clause license;
+* +PROPRIETARY+: marks a non-opensource package;
+ Buildroot does not save any licensing info or source code for these packages.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (7 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 08/22] manual: document usage of the legal-info feature Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 20:56 ` Thomas De Schampheleire
` (2 more replies)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 10/22] linux: define license Luca Ceresoli
` (15 subsequent siblings)
24 siblings, 3 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
docs/manual/using.txt | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/docs/manual/using.txt b/docs/manual/using.txt
index 42d4061..fcbd24b 100644
--- a/docs/manual/using.txt
+++ b/docs/manual/using.txt
@@ -284,3 +284,30 @@ Buildroot, with the name used in the manifest file:
* +BSD-2c+: BSD 2-clause license;
* +PROPRIETARY+: marks a non-opensource package;
Buildroot does not save any licensing info or source code for these packages.
+
+Complying with the Buildroot license
+------------------------------------
+
+Buildroot itself is an opensource software, released under the
+http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU General Public
+License, version 2] or (at your option) any later version.
+However, being a build system, it is not normally part of the end product:
+if you develop the root filesystem, kernel, bootloader or toolchain for a
+device, the code of Buildroot is only present on the development machine, not
+in the device storage.
+
+Nevertheless, the general view of the Buildroot developers is that you should
+release the Buildroot source code along with the source code of other packages
+when releasing a product that contains GPL-licensed software.
+This is because the
+http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU GPL]
+defines the "'complete source code'" for an executable work as "'all the
+source code for all modules it contains, plus any associated interface
+definition files, plus the scripts used to control compilation and installation
+of the executable'".
+Buildroot is part of the 'scripts used to control compilation and
+installation of the executable', and as such it is considered part of the
+material that must be redistributed.
+
+Keep in mind this is only the Buildroot developers' opinion, and you should
+consult your legal department or lawyer in case of any doubt.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot
2012-05-17 17:33 ` [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot Luca Ceresoli
@ 2012-05-17 20:56 ` Thomas De Schampheleire
2012-05-20 12:37 ` Arnout Vandecappelle
2012-07-05 13:52 ` Luca Ceresoli
2 siblings, 0 replies; 37+ messages in thread
From: Thomas De Schampheleire @ 2012-05-17 20:56 UTC (permalink / raw)
To: buildroot
Op 17 mei 2012 19:35 schreef "Luca Ceresoli" <luca@lucaceresoli.net> het
volgende:
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> docs/manual/using.txt | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/docs/manual/using.txt b/docs/manual/using.txt
> index 42d4061..fcbd24b 100644
> --- a/docs/manual/using.txt
> +++ b/docs/manual/using.txt
> @@ -284,3 +284,30 @@ Buildroot, with the name used in the manifest file:
> * +BSD-2c+: BSD 2-clause license;
> * +PROPRIETARY+: marks a non-opensource package;
> Buildroot does not save any licensing info or source code for these
packages.
> +
> +Complying with the Buildroot license
> +------------------------------------
> +
> +Buildroot itself is an opensource software, released under the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU General Public
> +License, version 2] or (at your option) any later version.
> +However, being a build system, it is not normally part of the end
product:
> +if you develop the root filesystem, kernel, bootloader or toolchain for a
> +device, the code of Buildroot is only present on the development
machine, not
> +in the device storage.
> +
> +Nevertheless, the general view of the Buildroot developers is that you
should
> +release the Buildroot source code along with the source code of other
packages
> +when releasing a product that contains GPL-licensed software.
> +This is because the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU GPL]
> +defines the "'complete source code'" for an executable work as "'all the
> +source code for all modules it contains, plus any associated interface
> +definition files, plus the scripts used to control compilation and
installation
> +of the executable'".
> +Buildroot is part of the 'scripts used to control compilation and
> +installation of the executable', and as such it is considered part of the
> +material that must be redistributed.
> +
> +Keep in mind this is only the Buildroot developers' opinion, and you
should
> +consult your legal department or lawyer in case of any doubt.
Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120517/f7dbf5b7/attachment.html>
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot
2012-05-17 17:33 ` [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot Luca Ceresoli
2012-05-17 20:56 ` Thomas De Schampheleire
@ 2012-05-20 12:37 ` Arnout Vandecappelle
2012-07-05 13:52 ` Luca Ceresoli
2 siblings, 0 replies; 37+ messages in thread
From: Arnout Vandecappelle @ 2012-05-20 12:37 UTC (permalink / raw)
To: buildroot
On 05/17/12 19:33, Luca Ceresoli wrote:
> Signed-off-by: Luca Ceresoli<luca@lucaceresoli.net>
> ---
> docs/manual/using.txt | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/docs/manual/using.txt b/docs/manual/using.txt
> index 42d4061..fcbd24b 100644
> --- a/docs/manual/using.txt
> +++ b/docs/manual/using.txt
> @@ -284,3 +284,30 @@ Buildroot, with the name used in the manifest file:
> * +BSD-2c+: BSD 2-clause license;
> * +PROPRIETARY+: marks a non-opensource package;
> Buildroot does not save any licensing info or source code for these packages.
> +
> +Complying with the Buildroot license
> +------------------------------------
> +
> +Buildroot itself is an opensource software, released under the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU General Public
> +License, version 2] or (at your option) any later version.
> +However, being a build system, it is not normally part of the end product:
> +if you develop the root filesystem, kernel, bootloader or toolchain for a
> +device, the code of Buildroot is only present on the development machine, not
> +in the device storage.
> +
> +Nevertheless, the general view of the Buildroot developers is that you should
> +release the Buildroot source code along with the source code of other packages
> +when releasing a product that contains GPL-licensed software.
> +This is because the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU GPL]
> +defines the "'complete source code'" for an executable work as "'all the
> +source code for all modules it contains, plus any associated interface
> +definition files, plus the scripts used to control compilation and installation
> +of the executable'".
> +Buildroot is part of the 'scripts used to control compilation and
> +installation of the executable', and as such it is considered part of the
> +material that must be redistributed.
> +
> +Keep in mind this is only the Buildroot developers' opinion, and you should
> +consult your legal department or lawyer in case of any doubt.
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot
2012-05-17 17:33 ` [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot Luca Ceresoli
2012-05-17 20:56 ` Thomas De Schampheleire
2012-05-20 12:37 ` Arnout Vandecappelle
@ 2012-07-05 13:52 ` Luca Ceresoli
2012-07-05 20:23 ` Arnout Vandecappelle
2 siblings, 1 reply; 37+ messages in thread
From: Luca Ceresoli @ 2012-07-05 13:52 UTC (permalink / raw)
To: buildroot
Hi,
Luca Ceresoli wrote:
> Signed-off-by: Luca Ceresoli<luca@lucaceresoli.net>
> ---
> docs/manual/using.txt | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/docs/manual/using.txt b/docs/manual/using.txt
> index 42d4061..fcbd24b 100644
> --- a/docs/manual/using.txt
> +++ b/docs/manual/using.txt
> @@ -284,3 +284,30 @@ Buildroot, with the name used in the manifest file:
> * +BSD-2c+: BSD 2-clause license;
> * +PROPRIETARY+: marks a non-opensource package;
> Buildroot does not save any licensing info or source code for these packages.
> +
> +Complying with the Buildroot license
> +------------------------------------
> +
> +Buildroot itself is an opensource software, released under the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU General Public
> +License, version 2] or (at your option) any later version.
> +However, being a build system, it is not normally part of the end product:
> +if you develop the root filesystem, kernel, bootloader or toolchain for a
> +device, the code of Buildroot is only present on the development machine, not
> +in the device storage.
> +
> +Nevertheless, the general view of the Buildroot developers is that you should
> +release the Buildroot source code along with the source code of other packages
> +when releasing a product that contains GPL-licensed software.
> +This is because the
> +http://www.gnu.org/licenses/old-licenses/gpl-2.0.html[GNU GPL]
> +defines the "'complete source code'" for an executable work as "'all the
> +source code for all modules it contains, plus any associated interface
> +definition files, plus the scripts used to control compilation and installation
> +of the executable'".
> +Buildroot is part of the 'scripts used to control compilation and
> +installation of the executable', and as such it is considered part of the
> +material that must be redistributed.
> +
> +Keep in mind this is only the Buildroot developers' opinion, and you should
> +consult your legal department or lawyer in case of any doubt.
The above text has been Acked-By two Buildroot developers and had no
negative
comments after ~6 weeks, which is good.
Nevertheless, I think it lacks some parts that I would like to be clarified.
A Buildroot tree is made up of the following parts:
1. the various makefiles and scripts that build the toolchain, handle
package compilation and generate a root filesystem, which is the heart
of Buildroot;
2. patches to packages;
3. small, proprietary, project-specific applications or libraries whose
source code resides in the Buildroot tree (not present in mainline).
The above clarification text, as well as the COPYING text, obviously applies
to point 1, but IMO points 2 and 3 need a different policy.
Patches to packages are modifications to externally-developed code, so I
think they fall under the same license as the package.
If this is correct, a clarification should be added to the above text and,
more important, to COPYING, much like the note at the beginning of the
Linux COPYING file.
Point 3 refers to the method described by Thomas Petazzoni in
http://elinux.org/images/2/2a/Using-buildroot-real-project.pdf, page 30.
The idea is that small "project-specific applications or libraries" can be
kept inside the Buildroot tree to simplify its integration.
Technically, it's how makedevs works in Buildroot. Is makedevs considered "a
part of Buildroot"? It think it is.
But one may want to develop another small utility in the same way inside the
Buildroot tree, but keeping it proprietary. As such, it should be clear
whether or not it is allowed to keep such code inside the Buildroot tree
without it falling under the Buildroot license.
My personal feeling is that Buildroot should allow to keep such proprietary
code in the tree, but with a clear way to determine that they are not
considered a derived work of Buildroot.
The discrimination could be: whatever is a package (in the Buildroot
meaning) *and* has <PKG>_LICENSE = PROPRIETARY in its .mk is considered not
to be a part of Buildroot and can have a different license.
This clause should be part of COPYING and documented in the manual too.
The legal-info code does not currently save the Buildroot tree, but when it
will be able to do so it should also be able to skip such packages.
Of course this would allow a more flexible usage of Buildroot in real life,
but at the cost of making the licensing policy more complex.
What areyour opinions?
Thanks,
Luca
^ permalink raw reply [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot
2012-07-05 13:52 ` Luca Ceresoli
@ 2012-07-05 20:23 ` Arnout Vandecappelle
0 siblings, 0 replies; 37+ messages in thread
From: Arnout Vandecappelle @ 2012-07-05 20:23 UTC (permalink / raw)
To: buildroot
On 07/05/12 15:52, Luca Ceresoli wrote:
> The above text has been Acked-By two Buildroot developers and had no negative
> comments after ~6 weeks, which is good.
>
> Nevertheless, I think it lacks some parts that I would like to be clarified.
>
> A Buildroot tree is made up of the following parts:
> 1. the various makefiles and scripts that build the toolchain, handle
> package compilation and generate a root filesystem, which is the heart
> of Buildroot;
> 2. patches to packages;
> 3. small, proprietary, project-specific applications or libraries whose
> source code resides in the Buildroot tree (not present in mainline).
>
> The above clarification text, as well as the COPYING text, obviously applies
> to point 1, but IMO points 2 and 3 need a different policy.
>
> Patches to packages are modifications to externally-developed code, so I
> think they fall under the same license as the package.
Good point. Without clarification, the patches would carry buildroot's
GPL and hence spread into the package's they're applied to. OTOH the
Signed-off-by lines in the patches could be construed to imply that the
patch follows the license of the files that it's applied to (cfr. DCO).
> If this is correct, a clarification should be added to the above text and,
> more important, to COPYING, much like the note at the beginning of the
> Linux COPYING file.
Ack.
> Point 3 refers to the method described by Thomas Petazzoni in
> http://elinux.org/images/2/2a/Using-buildroot-real-project.pdf, page 30.
> The idea is that small "project-specific applications or libraries" can be
> kept inside the Buildroot tree to simplify its integration.
>
> Technically, it's how makedevs works in Buildroot. Is makedevs considered "a
> part of Buildroot"? It think it is.
> But one may want to develop another small utility in the same way inside the
> Buildroot tree, but keeping it proprietary. As such, it should be clear
> whether or not it is allowed to keep such code inside the Buildroot tree
> without it falling under the Buildroot license.
I would say that this falls under the 'mere aggregation' clause. Whether
the source code of a proprietary program is in package/foo or in ../foo
really makes no difference at all.
That said, it would be good to clarify that point.
> My personal feeling is that Buildroot should allow to keep such proprietary
> code in the tree, but with a clear way to determine that they are not
> considered a derived work of Buildroot.
> The discrimination could be: whatever is a package (in the Buildroot
> meaning) *and* has <PKG>_LICENSE = PROPRIETARY in its .mk is considered not
> to be a part of Buildroot and can have a different license.
*Very* good point. The GPL itself is too vague to really be sure of what
constitutes a derived work of buildroot.
What about the finalize script? Is that part of the derived work? For sure,
whether it is or not should not depend on whether the file is within or
outside of the tree...
> This clause should be part of COPYING and documented in the manual too.
> The legal-info code does not currently save the Buildroot tree, but when it
> will be able to do so it should also be able to skip such packages.
>
> Of course this would allow a more flexible usage of Buildroot in real life,
> but at the cost of making the licensing policy more complex.
The licensing of buildroot _is_ complex. For the moment, it looks simple
because it is fuzzy, all the complexity is hidden.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 10/22] linux: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (8 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 09/22] manual: add advice about GPL compliance for Buildroot Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 11/22] m4: " Luca Ceresoli
` (14 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
linux/linux.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux/linux.mk b/linux/linux.mk
index f165dda..bd3e23e 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -4,6 +4,8 @@
#
###############################################################################
LINUX_VERSION=$(call qstrip,$(BR2_LINUX_KERNEL_VERSION))
+LINUX_LICENSE = GPLv2
+LINUX_LICENSE_FILES = COPYING
# Compute LINUX_SOURCE and LINUX_SITE from the configuration
ifeq ($(LINUX_VERSION),custom)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 11/22] m4: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (9 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 10/22] linux: define license Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 12/22] mpc: " Luca Ceresoli
` (13 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/m4/m4.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/m4/m4.mk b/package/m4/m4.mk
index 173bba8..1e891c5 100644
--- a/package/m4/m4.mk
+++ b/package/m4/m4.mk
@@ -7,6 +7,8 @@
M4_VERSION = 1.4.16
M4_SOURCE = m4-$(M4_VERSION).tar.bz2
M4_SITE = $(BR2_GNU_MIRROR)/m4
+M4_LICENSE = GPLv3+
+M4_LICENSE_FILES = COPYING
M4_CONF_ENV = gl_cv_func_gettimeofday_clobber=no
ifneq ($(BR2_USE_WCHAR),y)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 12/22] mpc: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (10 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 11/22] m4: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 13/22] fakeroot: " Luca Ceresoli
` (12 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/mpc/mpc.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/mpc/mpc.mk b/package/mpc/mpc.mk
index e5ee489..5ad47a9 100644
--- a/package/mpc/mpc.mk
+++ b/package/mpc/mpc.mk
@@ -6,6 +6,8 @@
MPC_VERSION = 0.9
MPC_SITE = http://www.multiprecision.org/mpc/download
+MPC_LICENSE = LGPLv2.1+
+MPC_LICENSE_FILES = COPYING.LIB
MPC_INSTALL_STAGING = YES
MPC_DEPENDENCIES = gmp mpfr
MPC_AUTORECONF = YES
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 13/22] fakeroot: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (11 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 12/22] mpc: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 14/22] bzip2: " Luca Ceresoli
` (11 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/fakeroot/fakeroot.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/fakeroot/fakeroot.mk b/package/fakeroot/fakeroot.mk
index 64203b8..a9074cb 100644
--- a/package/fakeroot/fakeroot.mk
+++ b/package/fakeroot/fakeroot.mk
@@ -6,5 +6,7 @@
FAKEROOT_VERSION = 1.18.2
FAKEROOT_SOURCE = fakeroot_$(FAKEROOT_VERSION).orig.tar.bz2
FAKEROOT_SITE = http://snapshot.debian.org/archive/debian/20111201T093630Z/pool/main/f/fakeroot/
+FAKEROOT_LICENSE = GPLv3+
+FAKEROOT_LICENSE_FILES = COPYING
$(eval $(call AUTOTARGETS,host))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 14/22] bzip2: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (12 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 13/22] fakeroot: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 15/22] directfb: " Luca Ceresoli
` (10 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/bzip2/bzip2.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/bzip2/bzip2.mk b/package/bzip2/bzip2.mk
index 1bc4449..611e5a0 100644
--- a/package/bzip2/bzip2.mk
+++ b/package/bzip2/bzip2.mk
@@ -7,6 +7,8 @@ BZIP2_VERSION:=1.0.5
BZIP2_SONAME=1.0.4
BZIP2_SOURCE:=bzip2-$(BZIP2_VERSION).tar.gz
BZIP2_SITE:=http://www.bzip.org/$(BZIP2_VERSION)
+BZIP2_LICENSE = bzip2 license
+BZIP2_LICENSE_FILES = LICENSE
BZIP2_INSTALL_STAGING=YES
define BZIP2_FIX_MAKEFILE
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 15/22] directfb: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (13 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 14/22] bzip2: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 16/22] iostat: " Luca Ceresoli
` (9 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/directfb/directfb.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 7aa0398..d0d8421 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -7,6 +7,8 @@ DIRECTFB_VERSION_MAJOR = 1.4
DIRECTFB_VERSION = $(DIRECTFB_VERSION_MAJOR).16
DIRECTFB_SITE = http://www.directfb.org/downloads/Core/DirectFB-$(DIRECTFB_VERSION_MAJOR)
DIRECTFB_SOURCE = DirectFB-$(DIRECTFB_VERSION).tar.gz
+DIRECTFB_LICENSE = LGPLv2.1+
+DIRECTFB_LICENSE_FILES = COPYING
DIRECTFB_AUTORECONF = YES
DIRECTFB_INSTALL_STAGING = YES
DIRECTFB_CONF_OPT = \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 16/22] iostat: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (14 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 15/22] directfb: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 17/22] lzo: " Luca Ceresoli
` (8 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/iostat/iostat.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/iostat/iostat.mk b/package/iostat/iostat.mk
index 83eea07..6f2e8aa 100644
--- a/package/iostat/iostat.mk
+++ b/package/iostat/iostat.mk
@@ -6,6 +6,8 @@
IOSTAT_VERSION = 2.2
IOSTAT_SITE = http://www.linuxinsight.com/files
+IOSTAT_LICENSE = GPL
+IOSTAT_LICENSE_FILES = LICENSE
iostat-source: $(DL_DIR)/$(IOSTAT_SOURCE)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 17/22] lzo: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (15 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 16/22] iostat: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 18/22] lzop: " Luca Ceresoli
` (7 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/lzo/lzo.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk
index 84f31f0..da5d6b7 100644
--- a/package/lzo/lzo.mk
+++ b/package/lzo/lzo.mk
@@ -5,6 +5,8 @@
#############################################################
LZO_VERSION = 2.06
LZO_SITE = http://www.oberhumer.com/opensource/lzo/download
+LZO_LICENSE = GPLv2+
+LZO_LICENSE_FILES = COPYING
LZO_INSTALL_STAGING = YES
$(eval $(call AUTOTARGETS))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 18/22] lzop: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (16 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 17/22] lzo: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 19/22] libusb: " Luca Ceresoli
` (6 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/lzop/lzop.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/lzop/lzop.mk b/package/lzop/lzop.mk
index 6d1d674..1e98030 100644
--- a/package/lzop/lzop.mk
+++ b/package/lzop/lzop.mk
@@ -6,6 +6,8 @@
LZOP_VERSION = 1.03
LZOP_SOURCE = lzop-$(LZOP_VERSION).tar.gz
LZOP_SITE = http://www.lzop.org/download/
+LZOP_LICENSE = GPLv2+
+LZOP_LICENSE_FILES = COPYING
LZOP_DEPENDENCIES = lzo
$(eval $(call AUTOTARGETS))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 19/22] libusb: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (17 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 18/22] lzop: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 20/22] pcre: " Luca Ceresoli
` (5 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/libusb/libusb.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/libusb/libusb.mk b/package/libusb/libusb.mk
index 9abfcfc..ac0f0d2 100644
--- a/package/libusb/libusb.mk
+++ b/package/libusb/libusb.mk
@@ -6,6 +6,8 @@
LIBUSB_VERSION = 1.0.9
LIBUSB_SOURCE = libusb-$(LIBUSB_VERSION).tar.bz2
LIBUSB_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/libusb/libusb-1.0/libusb-$(LIBUSB_VERSION)
+LIBUSB_LICENSE = LGPLv2.1+
+LIBUSB_LICENSE_FILES = COPYING
LIBUSB_DEPENDENCIES = host-pkg-config
LIBUSB_INSTALL_STAGING = YES
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 20/22] pcre: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (18 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 19/22] libusb: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 21/22] netsnmp: " Luca Ceresoli
` (4 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/pcre/pcre.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
index db896fd..d01ca84 100644
--- a/package/pcre/pcre.mk
+++ b/package/pcre/pcre.mk
@@ -6,6 +6,8 @@
PCRE_VERSION = 8.30
PCRE_SITE = ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre
+PCRE_LICENSE = BSD-3c
+PCRE_LICENSE_FILES = LICENCE
PCRE_INSTALL_STAGING = YES
ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 21/22] netsnmp: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (19 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 20/22] pcre: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-05-17 17:33 ` [Buildroot] [PATCH v4 22/22] berkeleydb: " Luca Ceresoli
` (3 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/netsnmp/netsnmp.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk
index 448e3fd..125782f 100644
--- a/package/netsnmp/netsnmp.mk
+++ b/package/netsnmp/netsnmp.mk
@@ -7,6 +7,8 @@
NETSNMP_VERSION = 5.7.1
NETSNMP_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/net-snmp
NETSNMP_SOURCE = net-snmp-$(NETSNMP_VERSION).tar.gz
+NETSNMP_LICENSE = Various BSD-like
+NETSNMP_LICENSE_FILES = COPYING
NETSNMP_INSTALL_STAGING = YES
NETSNMP_CONF_ENV = ac_cv_NETSNMP_CAN_USE_SYSCTL=yes
NETSNMP_CONF_OPT = --with-persistent-directory=/var/lib/snmp --disable-static \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 22/22] berkeleydb: define license
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (20 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 21/22] netsnmp: " Luca Ceresoli
@ 2012-05-17 17:33 ` Luca Ceresoli
2012-06-20 13:07 ` [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (2 subsequent siblings)
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-05-17 17:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
package/berkeleydb/berkeleydb.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk
index d737896..b42c000 100644
--- a/package/berkeleydb/berkeleydb.mk
+++ b/package/berkeleydb/berkeleydb.mk
@@ -7,6 +7,8 @@ BERKELEYDB_VERSION = 5.3.15
BERKELEYDB_SITE = http://download.oracle.com/berkeley-db
BERKELEYDB_SOURCE = db-$(BERKELEYDB_VERSION).NC.tar.gz
BERKELEYDB_SUBDIR = build_unix
+BERKELEYDB_LICENSE = BerkeleyDB License
+BERKELEYDB_LICENSE_FILES = LICENSE
BERKELEYDB_INSTALL_STAGING = YES
BERKELEYDB_BINARIES = db_archive db_checkpoint db_deadlock db_dump \
db_hotbackup db_load db_log_verify db_printlog db_recover db_replicate \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (21 preceding siblings ...)
2012-05-17 17:33 ` [Buildroot] [PATCH v4 22/22] berkeleydb: " Luca Ceresoli
@ 2012-06-20 13:07 ` Luca Ceresoli
2012-07-16 15:55 ` Thomas Petazzoni
2012-07-17 17:36 ` Thomas Petazzoni
24 siblings, 0 replies; 37+ messages in thread
From: Luca Ceresoli @ 2012-06-20 13:07 UTC (permalink / raw)
To: buildroot
Hi Peter,
Luca Ceresoli wrote:
> Hi,
>
> here is the third version of the legal-info feature implementation.
Meaning the fourth, of course.
>
> Links to discussion of previous versions:
> v1: http://lists.busybox.net/pipermail/buildroot/2012-January/049590.html
> v2: http://lists.busybox.net/pipermail/buildroot/2012-March/051132.html
> v3: http://lists.busybox.net/pipermail/buildroot/2012-May/053574.html
>
> This version is only a minor update to fix various issues reported by other
> developers. There are not changes to the general structure, so please see
> the link above for v3 for a detailed presentation.
>
> Let me repeat only my plea to all Buildroot developers to read and give
> feedback on patch 9.
> It gives an advice from Buildroot developers to Buildroot users about how to
> comply with both Buildroot's and the packages' licenses.
> Of course this must match as much as possible what the developers think, so
> please read it and give either your different views or your ack (preferably
> with a formal Acked-by tag).
>
> Thanks.
Peter, are you considering to merge this patchset into mainline Buildroot?
If you are, I'll submit a rebased version in the next few days, with the
addition
of the Signed-off-by tags received so far. There is no further change
required
AFAIK, and only a trivial conflict.
I also think your opinion about patch 9 is very important, since you're the
maintainer.
Thanks,
Luca
^ permalink raw reply [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (22 preceding siblings ...)
2012-06-20 13:07 ` [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
@ 2012-07-16 15:55 ` Thomas Petazzoni
2012-07-17 14:55 ` Thomas De Schampheleire
2012-07-17 17:36 ` Thomas Petazzoni
24 siblings, 1 reply; 37+ messages in thread
From: Thomas Petazzoni @ 2012-07-16 15:55 UTC (permalink / raw)
To: buildroot
Le Thu, 17 May 2012 19:32:59 +0200,
Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
> here is the third version of the legal-info feature implementation.
>
> Links to discussion of previous versions:
> v1:
> http://lists.busybox.net/pipermail/buildroot/2012-January/049590.html
> v2:
> http://lists.busybox.net/pipermail/buildroot/2012-March/051132.html
> v3: http://lists.busybox.net/pipermail/buildroot/2012-May/053574.html
>
> This version is only a minor update to fix various issues reported by
> other developers. There are not changes to the general structure, so
> please see the link above for v3 for a detailed presentation.
>
> Let me repeat only my plea to all Buildroot developers to read and
> give feedback on patch 9.
> It gives an advice from Buildroot developers to Buildroot users about
> how to comply with both Buildroot's and the packages' licenses.
> Of course this must match as much as possible what the developers
> think, so please read it and give either your different views or your
> ack (preferably with a formal Acked-by tag).
Ok, this series has been around for a while. I think that the overall
idea has been accepted by everybody, and has been discussed during the
Buildroot Developers Meeting in February.
Even though I think there might be a few possibilities to make the code
a bit nicer in patch 01/22, that's only internal implementation details
that can be improved at a later point.
Therefore, I'm now hesitating between those two solutions:
(1) Pulling all this in the current master, so that it will be part of
the next 2012.08 release. The chance of breaking seems fairly
limited to me, and this code has been around for a while, and I'd
like us to make progress on this.
(2) Be a bit safer, and wait the end of July to merge this into the
-next branch, once 2012.08-rc1 has been released.
What's the community opinion on this? At the moment, I'm leaning
towards (1), but I'd like to hear others opinion on this.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-16 15:55 ` Thomas Petazzoni
@ 2012-07-17 14:55 ` Thomas De Schampheleire
2012-07-17 15:07 ` Maxime Ripard
0 siblings, 1 reply; 37+ messages in thread
From: Thomas De Schampheleire @ 2012-07-17 14:55 UTC (permalink / raw)
To: buildroot
Op 16 jul. 2012 09:55 schreef "Thomas Petazzoni" <
thomas.petazzoni@free-electrons.com> het volgende:
>
> Le Thu, 17 May 2012 19:32:59 +0200,
> Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>
> > here is the third version of the legal-info feature implementation.
> >
> > Links to discussion of previous versions:
> > v1:
> > http://lists.busybox.net/pipermail/buildroot/2012-January/049590.html
> > v2:
> > http://lists.busybox.net/pipermail/buildroot/2012-March/051132.html
> > v3: http://lists.busybox.net/pipermail/buildroot/2012-May/053574.html
> >
> > This version is only a minor update to fix various issues reported by
> > other developers. There are not changes to the general structure, so
> > please see the link above for v3 for a detailed presentation.
> >
> > Let me repeat only my plea to all Buildroot developers to read and
> > give feedback on patch 9.
> > It gives an advice from Buildroot developers to Buildroot users about
> > how to comply with both Buildroot's and the packages' licenses.
> > Of course this must match as much as possible what the developers
> > think, so please read it and give either your different views or your
> > ack (preferably with a formal Acked-by tag).
>
> Ok, this series has been around for a while. I think that the overall
> idea has been accepted by everybody, and has been discussed during the
> Buildroot Developers Meeting in February.
>
> Even though I think there might be a few possibilities to make the code
> a bit nicer in patch 01/22, that's only internal implementation details
> that can be improved at a later point.
>
> Therefore, I'm now hesitating between those two solutions:
>
> (1) Pulling all this in the current master, so that it will be part of
> the next 2012.08 release. The chance of breaking seems fairly
> limited to me, and this code has been around for a while, and I'd
> like us to make progress on this.
>
> (2) Be a bit safer, and wait the end of July to merge this into the
> -next branch, once 2012.08-rc1 has been released.
>
> What's the community opinion on this? At the moment, I'm leaning
> towards (1), but I'd like to hear others opinion on this.
I'd go for (1). As you say, chances of breaking something is small. Plus,
if we can get this into the August release, we'll start getting further
feedback right away instead of waiting another three months.
Best regards,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120717/4e7f7ef6/attachment.html>
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-17 14:55 ` Thomas De Schampheleire
@ 2012-07-17 15:07 ` Maxime Ripard
2012-07-17 15:18 ` Samuel Martin
0 siblings, 1 reply; 37+ messages in thread
From: Maxime Ripard @ 2012-07-17 15:07 UTC (permalink / raw)
To: buildroot
Le 17/07/2012 16:55, Thomas De Schampheleire a ?crit :
> Op 16 jul. 2012 09:55 schreef "Thomas Petazzoni" <
> thomas.petazzoni at free-electrons.com> het volgende:
>>
>> Le Thu, 17 May 2012 19:32:59 +0200,
>> Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>>
>>> here is the third version of the legal-info feature implementation.
>>>
>>> Links to discussion of previous versions:
>>> v1:
>>> http://lists.busybox.net/pipermail/buildroot/2012-January/049590.html
>>> v2:
>>> http://lists.busybox.net/pipermail/buildroot/2012-March/051132.html
>>> v3: http://lists.busybox.net/pipermail/buildroot/2012-May/053574.html
>>>
>>> This version is only a minor update to fix various issues reported by
>>> other developers. There are not changes to the general structure, so
>>> please see the link above for v3 for a detailed presentation.
>>>
>>> Let me repeat only my plea to all Buildroot developers to read and
>>> give feedback on patch 9.
>>> It gives an advice from Buildroot developers to Buildroot users about
>>> how to comply with both Buildroot's and the packages' licenses.
>>> Of course this must match as much as possible what the developers
>>> think, so please read it and give either your different views or your
>>> ack (preferably with a formal Acked-by tag).
>>
>> Ok, this series has been around for a while. I think that the overall
>> idea has been accepted by everybody, and has been discussed during the
>> Buildroot Developers Meeting in February.
>>
>> Even though I think there might be a few possibilities to make the code
>> a bit nicer in patch 01/22, that's only internal implementation details
>> that can be improved at a later point.
>>
>> Therefore, I'm now hesitating between those two solutions:
>>
>> (1) Pulling all this in the current master, so that it will be part of
>> the next 2012.08 release. The chance of breaking seems fairly
>> limited to me, and this code has been around for a while, and I'd
>> like us to make progress on this.
>>
>> (2) Be a bit safer, and wait the end of July to merge this into the
>> -next branch, once 2012.08-rc1 has been released.
>>
>> What's the community opinion on this? At the moment, I'm leaning
>> towards (1), but I'd like to hear others opinion on this.
>
> I'd go for (1). As you say, chances of breaking something is small. Plus,
> if we can get this into the August release, we'll start getting further
> feedback right away instead of waiting another three months.
Agreed.
I'd go for (1) too.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-17 15:07 ` Maxime Ripard
@ 2012-07-17 15:18 ` Samuel Martin
0 siblings, 0 replies; 37+ messages in thread
From: Samuel Martin @ 2012-07-17 15:18 UTC (permalink / raw)
To: buildroot
2012/7/17 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Le 17/07/2012 16:55, Thomas De Schampheleire a ?crit :
>> Op 16 jul. 2012 09:55 schreef "Thomas Petazzoni" <
>> thomas.petazzoni at free-electrons.com> het volgende:
>>>
>>> Le Thu, 17 May 2012 19:32:59 +0200,
>>> Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>>>
>>>> here is the third version of the legal-info feature implementation.
>>>>
>>>
>>> Ok, this series has been around for a while. I think that the overall
>>> idea has been accepted by everybody, and has been discussed during the
>>> Buildroot Developers Meeting in February.
>>>
>>> Even though I think there might be a few possibilities to make the code
>>> a bit nicer in patch 01/22, that's only internal implementation details
>>> that can be improved at a later point.
>>>
>>> Therefore, I'm now hesitating between those two solutions:
>>>
>>> (1) Pulling all this in the current master, so that it will be part of
>>> the next 2012.08 release. The chance of breaking seems fairly
>>> limited to me, and this code has been around for a while, and I'd
>>> like us to make progress on this.
>>>
>>> (2) Be a bit safer, and wait the end of July to merge this into the
>>> -next branch, once 2012.08-rc1 has been released.
>>>
>>> What's the community opinion on this? At the moment, I'm leaning
>>> towards (1), but I'd like to hear others opinion on this.
>>
>> I'd go for (1). As you say, chances of breaking something is small. Plus,
>> if we can get this into the August release, we'll start getting further
>> feedback right away instead of waiting another three months.
>
> Agreed.
> I'd go for (1) too.
I second (1) too.
--
Sam
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-05-17 17:32 [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info Luca Ceresoli
` (23 preceding siblings ...)
2012-07-16 15:55 ` Thomas Petazzoni
@ 2012-07-17 17:36 ` Thomas Petazzoni
2012-07-17 18:58 ` Thomas Petazzoni
24 siblings, 1 reply; 37+ messages in thread
From: Thomas Petazzoni @ 2012-07-17 17:36 UTC (permalink / raw)
To: buildroot
Le Thu, 17 May 2012 19:32:59 +0200,
Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
> here is the third version of the legal-info feature implementation.
>
> Links to discussion of previous versions:
> v1: http://lists.busybox.net/pipermail/buildroot/2012-January/049590.html
> v2: http://lists.busybox.net/pipermail/buildroot/2012-March/051132.html
> v3: http://lists.busybox.net/pipermail/buildroot/2012-May/053574.html
>
> This version is only a minor update to fix various issues reported by other
> developers. There are not changes to the general structure, so please see
> the link above for v3 for a detailed presentation.
Following the comments of several Buildroot contributors, I have merged
the 22 patches of your series. Thanks a lot for your perseverance in
getting this merged!
Now, I'd like to point something: the SPDX standard, documented at
http://spdx.org/. It is precisely designed to describe the list of
packages that compose a system. Since it's a big XML nightmare, I'm not
sure we want to support this, but at least they have a list of
licenses, each associated with a short name, that would be good to
follow as a convention, I think. See http://www.spdx.org/licenses/.
What do you think about this?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 37+ messages in thread* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-17 17:36 ` Thomas Petazzoni
@ 2012-07-17 18:58 ` Thomas Petazzoni
2012-07-19 10:11 ` Luca Ceresoli
0 siblings, 1 reply; 37+ messages in thread
From: Thomas Petazzoni @ 2012-07-17 18:58 UTC (permalink / raw)
To: buildroot
Le Tue, 17 Jul 2012 19:36:10 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
> Following the comments of several Buildroot contributors, I have merged
> the 22 patches of your series. Thanks a lot for your perseverance in
> getting this merged!
I have also added the execution of 'make legal-info' to my autobuilder.
So all builds coming from the Free Electrons build server visible at
http://autobuild.buildroot.org will have the CSV file of the licenses.
It is not directly visible in the webpage, but if you go in the "dir"
link, and then look at the licenses-manifest.csv file, it corresponds
to the output/legal-info/manifest.csv file.
Example:
http://autobuild.buildroot.org/results/a07c8611de688b6dccbfae00ff153ad89f3e7f77/licenses-manifest.csv
This way, the legal-info machinery will be exercised on many packages.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-17 18:58 ` Thomas Petazzoni
@ 2012-07-19 10:11 ` Luca Ceresoli
2012-07-19 11:30 ` Thomas Petazzoni
0 siblings, 1 reply; 37+ messages in thread
From: Luca Ceresoli @ 2012-07-19 10:11 UTC (permalink / raw)
To: buildroot
Thomas Petazzoni wrote:
> Le Tue, 17 Jul 2012 19:36:10 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
>
>> Following the comments of several Buildroot contributors, I have merged
>> the 22 patches of your series. Thanks a lot for your perseverance in
>> getting this merged!
>
> I have also added the execution of 'make legal-info' to my autobuilder.
> So all builds coming from the Free Electrons build server visible at
> http://autobuild.buildroot.org will have the CSV file of the licenses.
> It is not directly visible in the webpage, but if you go in the "dir"
> link, and then look at the licenses-manifest.csv file, it corresponds
> to the output/legal-info/manifest.csv file.
>
> Example:
> http://autobuild.buildroot.org/results/a07c8611de688b6dccbfae00ff153ad89f3e7f77/licenses-manifest.csv
>
> This way, the legal-info machinery will be exercised on many packages.
Good!
I'm quickly looking at the latest daily autobuild e-mail reports, and I
don't see evidence of any failure. But, in order to be sure, is there a
specific error message for make legal-info? Maybe a specific string in the
"Failure reason" line?
Thanks,
Luca
^ permalink raw reply [flat|nested] 37+ messages in thread
* [Buildroot] [PATCH v4 00/22] Automatically produce legal compliance info
2012-07-19 10:11 ` Luca Ceresoli
@ 2012-07-19 11:30 ` Thomas Petazzoni
0 siblings, 0 replies; 37+ messages in thread
From: Thomas Petazzoni @ 2012-07-19 11:30 UTC (permalink / raw)
To: buildroot
Le Thu, 19 Jul 2012 12:11:51 +0200,
Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
> I'm quickly looking at the latest daily autobuild e-mail reports, and I
> don't see evidence of any failure. But, in order to be sure, is there a
> specific error message for make legal-info? Maybe a specific string in the
> "Failure reason" line?
Well, so far there doesn't seem to be any failure related to the
legal-info mechanism. I just do "make legal-info" at the end of the
build if the build was successful, and if "make legal-info" fails, the
build would be reported as failed. The failure reason would then
contain the "make error" line.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 37+ messages in thread