All of lore.kernel.org
 help / color / mirror / Atom feed
* re: gpio: add TS-4800 fpga GPIO support
@ 2016-02-09 19:26 Dan Carpenter
  2016-02-09 23:20 ` Julien Grossholtz
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-02-09 19:26 UTC (permalink / raw)
  To: julien.grossholtz; +Cc: linux-gpio

Hello Julien Grossholtz,

The patch 5041e791440a: "gpio: add TS-4800 fpga GPIO support" from
Jan 13, 2016, leads to the following static checker warning:

	drivers/gpio/gpio-ts4800.c:52 ts4800_gpio_probe()
	warn: odd binop '0x1 & 0x8'

drivers/gpio/gpio-ts4800.c
    43          retval = of_property_read_u32(node, "ngpios", &ngpios);
    44          if (retval == -EINVAL)
    45                  ngpios = DEFAULT_PIN_NUMBER;
    46          else if (retval)
    47                  return retval;
    48  
    49          retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
    50                              base_addr + OUTPUT_REG_OFFSET, NULL,
    51                              base_addr + DIRECTION_REG_OFFSET, NULL,
    52                              BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);

Probably | was intended instead of &.

    53          if (retval) {
    54                  dev_err(&pdev->dev, "bgpio_init failed\n");
    55                  return retval;
    56          }
    57  

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: gpio: add TS-4800 fpga GPIO support
  2016-02-09 19:26 gpio: add TS-4800 fpga GPIO support Dan Carpenter
@ 2016-02-09 23:20 ` Julien Grossholtz
  0 siblings, 0 replies; 2+ messages in thread
From: Julien Grossholtz @ 2016-02-09 23:20 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: linux-gpio

Hello Dan,

Thank you for pointing that out. It made me figure out there
is no need for any of those flags for this driver.

I will send a fix for this soon.

Julien Grossholtz

----- Original Message -----
From: "Dan Carpenter" <dan.carpenter@oracle.com>
To: "julien grossholtz" <julien.grossholtz@savoirfairelinux.com>
Cc: linux-gpio@vger.kernel.org
Sent: Tuesday, February 9, 2016 2:26:46 PM
Subject: re: gpio: add TS-4800 fpga GPIO support

Hello Julien Grossholtz,

The patch 5041e791440a: "gpio: add TS-4800 fpga GPIO support" from
Jan 13, 2016, leads to the following static checker warning:

	drivers/gpio/gpio-ts4800.c:52 ts4800_gpio_probe()
	warn: odd binop '0x1 & 0x8'

drivers/gpio/gpio-ts4800.c
    43          retval = of_property_read_u32(node, "ngpios", &ngpios);
    44          if (retval == -EINVAL)
    45                  ngpios = DEFAULT_PIN_NUMBER;
    46          else if (retval)
    47                  return retval;
    48  
    49          retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
    50                              base_addr + OUTPUT_REG_OFFSET, NULL,
    51                              base_addr + DIRECTION_REG_OFFSET, NULL,
    52                              BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);

Probably | was intended instead of &.

    53          if (retval) {
    54                  dev_err(&pdev->dev, "bgpio_init failed\n");
    55                  return retval;
    56          }
    57  

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-09 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 19:26 gpio: add TS-4800 fpga GPIO support Dan Carpenter
2016-02-09 23:20 ` Julien Grossholtz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.