All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: x86@kernel.org,
	Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	Jean Delvare <khali@linux-fr.org>,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH v6 3/3] gpio: TS-5500 GPIO support
Date: Thu, 17 May 2012 17:40:26 -0400	[thread overview]
Message-ID: <1337290826.7033.10.camel@trivette.site> (raw)
In-Reply-To: <20120517210633.400633E0621@localhost>

On Thu, 2012-05-17 at 15:06 -0600, Grant Likely wrote:
> >  arch/x86/include/asm/ts5500.h |   62 ++++++++
> 
> Why the separate header file?  What will use these defines?  I
> normally expect driver-specific defines to be in the driver .c file
> directly; particularly for things like gpio drivers which should be a
> generic interface that doesn't need to export symbols. 

Should an intermediate driver directly use values for GPIOs instead of
these symbols? For example, how should a temperature sensor plugged on
this platform refer to inputs and outputs?

Thanks,
	Vivien


WARNING: multiple messages have this Message-ID (diff)
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: x86@kernel.org,
	Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	Jean Delvare <khali@linux-fr.org>,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [lm-sensors] [PATCH v6 3/3] gpio: TS-5500 GPIO support
Date: Thu, 17 May 2012 21:40:26 +0000	[thread overview]
Message-ID: <1337290826.7033.10.camel@trivette.site> (raw)
In-Reply-To: <20120517210633.400633E0621@localhost>

On Thu, 2012-05-17 at 15:06 -0600, Grant Likely wrote:
> >  arch/x86/include/asm/ts5500.h |   62 ++++++++
> 
> Why the separate header file?  What will use these defines?  I
> normally expect driver-specific defines to be in the driver .c file
> directly; particularly for things like gpio drivers which should be a
> generic interface that doesn't need to export symbols. 

Should an intermediate driver directly use values for GPIOs instead of
these symbols? For example, how should a temperature sensor plugged on
this platform refer to inputs and outputs?

Thanks,
	Vivien


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2012-05-17 21:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  0:28 [PATCH v6 0/3] TS-5500 platform support Vivien Didelot
2012-04-13  0:28 ` [lm-sensors] " Vivien Didelot
2012-04-13  0:28 ` [PATCH v6 1/3] hwmon: Maxim MAX197 support Vivien Didelot
2012-04-13  0:28   ` [lm-sensors] " Vivien Didelot
2012-04-14  0:46   ` Guenter Roeck
2012-04-14  0:46     ` [lm-sensors] " Guenter Roeck
2012-04-13  0:28 ` [PATCH v6 2/3] x86/platform: TS-5500 basic platform support Vivien Didelot
2012-04-13  0:28   ` [lm-sensors] " Vivien Didelot
2012-04-13 10:37   ` Thomas Gleixner
2012-04-13 10:37     ` [lm-sensors] " Thomas Gleixner
2012-04-13 20:46     ` Vivien Didelot
2012-04-13 20:46       ` [lm-sensors] " Vivien Didelot
2012-04-13  0:28 ` [PATCH v6 3/3] gpio: TS-5500 GPIO support Vivien Didelot
2012-04-13  0:28   ` [lm-sensors] " Vivien Didelot
2012-04-13 19:04   ` Mark Brown
2012-04-13 19:04     ` [lm-sensors] " Mark Brown
2012-05-17 21:06   ` Grant Likely
2012-05-17 21:06     ` [lm-sensors] " Grant Likely
2012-05-17 21:14     ` Joe Perches
2012-05-17 21:14       ` [lm-sensors] " Joe Perches
2012-05-17 21:40     ` Vivien Didelot [this message]
2012-05-17 21:40       ` Vivien Didelot
2012-05-17 22:59       ` Grant Likely
2012-05-17 22:59         ` [lm-sensors] " Grant Likely
2012-05-18 14:37         ` Vivien Didelot
2012-05-18 14:37           ` [lm-sensors] " Vivien Didelot
2012-05-18 19:59           ` Grant Likely
2012-05-18 19:59             ` [lm-sensors] " Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337290826.7033.10.camel@trivette.site \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=grant.likely@secretlab.ca \
    --cc=guenter.roeck@ericsson.com \
    --cc=hpa@zytor.com \
    --cc=jerome.oufella@savoirfairelinux.com \
    --cc=khali@linux-fr.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.