* [PATCH][conntrack-tools] conntrack: flush stdout for each expectation event, too
@ 2012-05-18 11:36 Florian Westphal
2012-05-20 20:21 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2012-05-18 11:36 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal
else, piping "conntrack -E expect" output will be buffered/delayed,
which is not what users expect. Normal conntrack events are already
flushed.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/conntrack.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conntrack.c b/src/conntrack.c
index b065211..0920bc5 100644
--- a/src/conntrack.c
+++ b/src/conntrack.c
@@ -1380,6 +1380,7 @@ static int event_exp_cb(enum nf_conntrack_msg_type type,
nfexp_snprintf(buf,sizeof(buf), exp, type, op_type, op_flags);
printf("%s\n", buf);
+ fflush(stdout);
counter++;
return NFCT_CB_CONTINUE;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][conntrack-tools] conntrack: flush stdout for each expectation event, too
2012-05-18 11:36 [PATCH][conntrack-tools] conntrack: flush stdout for each expectation event, too Florian Westphal
@ 2012-05-20 20:21 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2012-05-20 20:21 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On Fri, May 18, 2012 at 01:36:49PM +0200, Florian Westphal wrote:
> else, piping "conntrack -E expect" output will be buffered/delayed,
> which is not what users expect. Normal conntrack events are already
> flushed.
applied, thanks Florian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-20 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-18 11:36 [PATCH][conntrack-tools] conntrack: flush stdout for each expectation event, too Florian Westphal
2012-05-20 20:21 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.