* Add option to oe-buildenv-internal script to change bitbake location.
@ 2012-05-09 16:44 Philip Balister
2012-05-09 17:03 ` Marko Lindqvist
2012-05-16 18:23 ` Saul Wold
0 siblings, 2 replies; 7+ messages in thread
From: Philip Balister @ 2012-05-09 16:44 UTC (permalink / raw)
To: openembedded-core
Having bitbake inside the oe-core is annoying to some people. This commit
adds a second option to the oe-init-build-env script.
Run like this:
. ./oe-init-build-env ../build ../bitbake
for example. Without the second option, the old behavior is preserved.
Signed-off-by: Philip Balister <philip@balister.org>
---
scripts/oe-buildenv-internal | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
index 9de7b05..05c6cd8 100755
--- a/scripts/oe-buildenv-internal
+++ b/scripts/oe-buildenv-internal
@@ -54,7 +54,11 @@ else
fi
unset BDIR
-BITBAKEDIR="$OEROOT/bitbake$BBEXTRA/"
+if [ "x$2" = "x" ]; then
+ BITBAKEDIR="$OEROOT/bitbake$BBEXTRA/"
+else
+ BITBAKEDIR="$2"
+fi
BITBAKEDIR=`readlink -f "$BITBAKEDIR"`
BUILDDIR=`readlink -f "$BUILDDIR"`
--
1.7.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-09 16:44 Add option to oe-buildenv-internal script to change bitbake location Philip Balister
@ 2012-05-09 17:03 ` Marko Lindqvist
2012-05-21 13:07 ` Philip Balister
2012-05-16 18:23 ` Saul Wold
1 sibling, 1 reply; 7+ messages in thread
From: Marko Lindqvist @ 2012-05-09 17:03 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
> Having bitbake inside the oe-core is annoying to some people. This commit
> adds a second option to the oe-init-build-env script.
>
> Run like this:
>
> . ./oe-init-build-env ../build ../bitbake
>
> for example. Without the second option, the old behavior is preserved.
>
> Signed-off-by: Philip Balister <philip@balister.org>
Maybe you should update comment in oe-init-build-env describing
typical use to contain this parameter.
- ML
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-09 16:44 Add option to oe-buildenv-internal script to change bitbake location Philip Balister
2012-05-09 17:03 ` Marko Lindqvist
@ 2012-05-16 18:23 ` Saul Wold
1 sibling, 0 replies; 7+ messages in thread
From: Saul Wold @ 2012-05-16 18:23 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 05/09/2012 07:44 PM, Philip Balister wrote:
> Having bitbake inside the oe-core is annoying to some people. This commit
> adds a second option to the oe-init-build-env script.
>
> Run like this:
>
> . ./oe-init-build-env ../build ../bitbake
>
> for example. Without the second option, the old behavior is preserved.
>
> Signed-off-by: Philip Balister<philip@balister.org>
> ---
> scripts/oe-buildenv-internal | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
> index 9de7b05..05c6cd8 100755
> --- a/scripts/oe-buildenv-internal
> +++ b/scripts/oe-buildenv-internal
> @@ -54,7 +54,11 @@ else
> fi
> unset BDIR
>
> -BITBAKEDIR="$OEROOT/bitbake$BBEXTRA/"
> +if [ "x$2" = "x" ]; then
> + BITBAKEDIR="$OEROOT/bitbake$BBEXTRA/"
> +else
> + BITBAKEDIR="$2"
> +fi
>
> BITBAKEDIR=`readlink -f "$BITBAKEDIR"`
> BUILDDIR=`readlink -f "$BUILDDIR"`
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-09 17:03 ` Marko Lindqvist
@ 2012-05-21 13:07 ` Philip Balister
2012-05-21 13:25 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Philip Balister @ 2012-05-21 13:07 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 05/09/2012 01:03 PM, Marko Lindqvist wrote:
> On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
>> Having bitbake inside the oe-core is annoying to some people. This commit
>> adds a second option to the oe-init-build-env script.
>>
>> Run like this:
>>
>> . ./oe-init-build-env ../build ../bitbake
>>
>> for example. Without the second option, the old behavior is preserved.
>>
>> Signed-off-by: Philip Balister <philip@balister.org>
>
> Maybe you should update comment in oe-init-build-env describing
> typical use to contain this parameter.
Richard, do you want me to se-send this with Marko's suggestions added?
Philip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-21 13:07 ` Philip Balister
@ 2012-05-21 13:25 ` Richard Purdie
2012-05-21 13:41 ` Philip Balister
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2012-05-21 13:25 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Mon, 2012-05-21 at 09:07 -0400, Philip Balister wrote:
> On 05/09/2012 01:03 PM, Marko Lindqvist wrote:
> > On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
> >> Having bitbake inside the oe-core is annoying to some people. This commit
> >> adds a second option to the oe-init-build-env script.
> >>
> >> Run like this:
> >>
> >> . ./oe-init-build-env ../build ../bitbake
> >>
> >> for example. Without the second option, the old behavior is preserved.
> >>
> >> Signed-off-by: Philip Balister <philip@balister.org>
> >
> > Maybe you should update comment in oe-init-build-env describing
> > typical use to contain this parameter.
>
> Richard, do you want me to se-send this with Marko's suggestions added?
I'm happy to have a follow up patch, I did merge the original. It broke
various assumptions being made by for example the autobuilder scripts so
I had to add some other changes already.
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-21 13:25 ` Richard Purdie
@ 2012-05-21 13:41 ` Philip Balister
2012-05-21 13:48 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Philip Balister @ 2012-05-21 13:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 05/21/2012 09:25 AM, Richard Purdie wrote:
> On Mon, 2012-05-21 at 09:07 -0400, Philip Balister wrote:
>> On 05/09/2012 01:03 PM, Marko Lindqvist wrote:
>>> On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
>>>> Having bitbake inside the oe-core is annoying to some people. This commit
>>>> adds a second option to the oe-init-build-env script.
>>>>
>>>> Run like this:
>>>>
>>>> . ./oe-init-build-env ../build ../bitbake
>>>>
>>>> for example. Without the second option, the old behavior is preserved.
>>>>
>>>> Signed-off-by: Philip Balister <philip@balister.org>
>>>
>>> Maybe you should update comment in oe-init-build-env describing
>>> typical use to contain this parameter.
>>
>> Richard, do you want me to se-send this with Marko's suggestions added?
>
> I'm happy to have a follow up patch, I did merge the original. It broke
> various assumptions being made by for example the autobuilder scripts so
> I had to add some other changes already.
Thanks.
I'm curious how it could break things since it should not have had any
effect unless a second argument was present.
Philip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Add option to oe-buildenv-internal script to change bitbake location.
2012-05-21 13:41 ` Philip Balister
@ 2012-05-21 13:48 ` Richard Purdie
0 siblings, 0 replies; 7+ messages in thread
From: Richard Purdie @ 2012-05-21 13:48 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Mon, 2012-05-21 at 09:41 -0400, Philip Balister wrote:
> On 05/21/2012 09:25 AM, Richard Purdie wrote:
> > On Mon, 2012-05-21 at 09:07 -0400, Philip Balister wrote:
> >> On 05/09/2012 01:03 PM, Marko Lindqvist wrote:
> >>> On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
> >>>> Having bitbake inside the oe-core is annoying to some people. This commit
> >>>> adds a second option to the oe-init-build-env script.
> >>>>
> >>>> Run like this:
> >>>>
> >>>> . ./oe-init-build-env ../build ../bitbake
> >>>>
> >>>> for example. Without the second option, the old behavior is preserved.
> >>>>
> >>>> Signed-off-by: Philip Balister <philip@balister.org>
> >>>
> >>> Maybe you should update comment in oe-init-build-env describing
> >>> typical use to contain this parameter.
> >>
> >> Richard, do you want me to se-send this with Marko's suggestions added?
> >
> > I'm happy to have a follow up patch, I did merge the original. It broke
> > various assumptions being made by for example the autobuilder scripts so
> > I had to add some other changes already.
>
> Thanks.
>
> I'm curious how it could break things since it should not have had any
> effect unless a second argument was present.
Think about another script sourcing the internal build environment
script. You'd then see that script's second option...
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-05-21 13:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-09 16:44 Add option to oe-buildenv-internal script to change bitbake location Philip Balister
2012-05-09 17:03 ` Marko Lindqvist
2012-05-21 13:07 ` Philip Balister
2012-05-21 13:25 ` Richard Purdie
2012-05-21 13:41 ` Philip Balister
2012-05-21 13:48 ` Richard Purdie
2012-05-16 18:23 ` Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.