* [U-Boot] undefined reference to `net_set_upd_handler'
@ 2012-05-23 22:46 Stephan Linz
2012-05-23 22:50 ` Joe Hershberger
0 siblings, 1 reply; 4+ messages in thread
From: Stephan Linz @ 2012-05-23 22:46 UTC (permalink / raw)
To: u-boot
Hello Joe,
just I've tried out your custodian network tree at a99acb7 and run in
the link error below:
net/libnet.o: In function `NetLoop':
net/net.c:539: undefined reference to `net_set_upd_handler'
I think it is a typo in commit 6476b33, or not?
The patch snipped below would fix it. It works to me.
diff --git a/net/net.c b/net/net.c
index 159b91a..9de7d92 100644
--- a/net/net.c
+++ b/net/net.c
@@ -536,7 +536,7 @@ restart:
done:
#ifdef CONFIG_CMD_TFTPPUT
/* Clear out the handlers */
- net_set_upd_handler(NULL);
+ net_set_udp_handler(NULL);
net_set_icmp_handler(NULL);
#endif
return ret;
br,
Stephan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] undefined reference to `net_set_upd_handler'
2012-05-23 22:46 [U-Boot] undefined reference to `net_set_upd_handler' Stephan Linz
@ 2012-05-23 22:50 ` Joe Hershberger
2012-05-23 22:54 ` Joe Hershberger
0 siblings, 1 reply; 4+ messages in thread
From: Joe Hershberger @ 2012-05-23 22:50 UTC (permalink / raw)
To: u-boot
Hi Stephan,
On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
> Hello Joe,
>
> just I've tried out your custodian network tree at a99acb7 and run in
> the link error below:
>
> net/libnet.o: In function `NetLoop':
> net/net.c:539: undefined reference to `net_set_upd_handler'
>
> I think it is a typo in commit 6476b33, or not?
Thanks for trying it out. It seems I typo'd that in a feature that is
not enabled on anything but microblaze.
Thanks for catching it.
-Joe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] undefined reference to `net_set_upd_handler'
2012-05-23 22:50 ` Joe Hershberger
@ 2012-05-23 22:54 ` Joe Hershberger
2012-05-23 23:20 ` Stephan Linz
0 siblings, 1 reply; 4+ messages in thread
From: Joe Hershberger @ 2012-05-23 22:54 UTC (permalink / raw)
To: u-boot
Hi Stephan,
On Wed, May 23, 2012 at 5:50 PM, Joe Hershberger
<joe.hershberger@gmail.com> wrote:
> Hi Stephan,
>
> On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
>> Hello Joe,
>>
>> just I've tried out your custodian network tree at a99acb7 and run in
>> the link error below:
>>
>> net/libnet.o: In function `NetLoop':
>> net/net.c:539: undefined reference to `net_set_upd_handler'
>>
>> I think it is a typo in commit 6476b33, or not?
I've pushed a fixed version.
-Joe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] undefined reference to `net_set_upd_handler'
2012-05-23 22:54 ` Joe Hershberger
@ 2012-05-23 23:20 ` Stephan Linz
0 siblings, 0 replies; 4+ messages in thread
From: Stephan Linz @ 2012-05-23 23:20 UTC (permalink / raw)
To: u-boot
Hi Joe,
thanks, now it compiles without error, tftpput works too.
br,
Stephan
Am Mittwoch, den 23.05.2012, 17:54 -0500 schrieb Joe Hershberger:
> Hi Stephan,
>
> On Wed, May 23, 2012 at 5:50 PM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
> > Hi Stephan,
> >
> > On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
> >> Hello Joe,
> >>
> >> just I've tried out your custodian network tree at a99acb7 and run in
> >> the link error below:
> >>
> >> net/libnet.o: In function `NetLoop':
> >> net/net.c:539: undefined reference to `net_set_upd_handler'
> >>
> >> I think it is a typo in commit 6476b33, or not?
>
> I've pushed a fixed version.
>
> -Joe
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Viele Gr??e,
Stephan Linz
______________________________________________________________________________
MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
Sourceforge: http://sourceforge.net/users/slz
Gitorious: https://gitorious.org/~slz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-23 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-23 22:46 [U-Boot] undefined reference to `net_set_upd_handler' Stephan Linz
2012-05-23 22:50 ` Joe Hershberger
2012-05-23 22:54 ` Joe Hershberger
2012-05-23 23:20 ` Stephan Linz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.