* [PATCH] drm/radeon/si: check for CE ucode as well when loading ucode
@ 2012-06-12 19:33 alexdeucher
2012-06-13 7:40 ` Michel Dänzer
0 siblings, 1 reply; 2+ messages in thread
From: alexdeucher @ 2012-06-12 19:33 UTC (permalink / raw)
To: airlied, dri-devel; +Cc: Alex Deucher, stable
From: Alex Deucher <alexander.deucher@amd.com>
Fixes possible segfault if the CE ucode is missing.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/radeon/si.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
index 9248a91..d500911 100644
--- a/drivers/gpu/drm/radeon/si.c
+++ b/drivers/gpu/drm/radeon/si.c
@@ -1825,7 +1825,7 @@ static int si_cp_load_microcode(struct radeon_device *rdev)
const __be32 *fw_data;
int i;
- if (!rdev->me_fw || !rdev->pfp_fw)
+ if (!rdev->me_fw || !rdev->pfp_fw || !rdev->ce_fw)
return -EINVAL;
si_cp_enable(rdev, false);
--
1.7.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon/si: check for CE ucode as well when loading ucode
2012-06-12 19:33 [PATCH] drm/radeon/si: check for CE ucode as well when loading ucode alexdeucher
@ 2012-06-13 7:40 ` Michel Dänzer
0 siblings, 0 replies; 2+ messages in thread
From: Michel Dänzer @ 2012-06-13 7:40 UTC (permalink / raw)
To: alexdeucher; +Cc: dri-devel
On Die, 2012-06-12 at 15:33 -0400, alexdeucher@gmail.com wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> Fixes possible segfault if the CE ucode is missing.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/radeon/si.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
> index 9248a91..d500911 100644
> --- a/drivers/gpu/drm/radeon/si.c
> +++ b/drivers/gpu/drm/radeon/si.c
> @@ -1825,7 +1825,7 @@ static int si_cp_load_microcode(struct radeon_device *rdev)
> const __be32 *fw_data;
> int i;
>
> - if (!rdev->me_fw || !rdev->pfp_fw)
> + if (!rdev->me_fw || !rdev->pfp_fw || !rdev->ce_fw)
> return -EINVAL;
>
> si_cp_enable(rdev, false);
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-13 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-12 19:33 [PATCH] drm/radeon/si: check for CE ucode as well when loading ucode alexdeucher
2012-06-13 7:40 ` Michel Dänzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.