[PATCH] x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

[PATCH] x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

[Shuah Khan]

Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted
simple_strtoul().

Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
---
 arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mtrr/cleanup.c b/arch/x86/kernel/cpu/mtrr/cleanup.c
index ac140c7..601aa4e 100644
--- a/arch/x86/kernel/cpu/mtrr/cleanup.c
+++ b/arch/x86/kernel/cpu/mtrr/cleanup.c
@@ -465,7 +465,7 @@ static unsigned long nr_mtrr_spare_reg __initdata =
 static int __init parse_mtrr_spare_reg(char *arg)
 {
 	if (arg)
-		nr_mtrr_spare_reg = simple_strtoul(arg, NULL, 0);
+		kstrtoul(arg, 0, &nr_mtrr_spare_reg);
 	return 0;
 }
 early_param("mtrr_spare_reg_nr", parse_mtrr_spare_reg);
-- 
1.7.9.5

Re: [PATCH] x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

[Ingo Molnar]

* Shuah Khan <shuahkhan@gmail.com> wrote:

> Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted
> simple_strtoul().
> 
> Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
> ---
>  arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

There's about 22 simple_strto*() uses remaining in arch/x86/ - 
please send a single patch that addresses them in one go, 
instead of these peacemail patches...

Thanks,

	Ingo

Re: [PATCH] x86: kernel/cpu/mtrr/cleanup.c simple_strtoul cleanup

[Shuah Khan]

On Thu, 2012-06-14 at 12:48 +0200, Ingo Molnar wrote:
> * Shuah Khan <shuahkhan@gmail.com> wrote:
> 
> > Change parse_mtrr_spare_reg() to call kstrtoul() instead of calling obsoleted
> > simple_strtoul().
> > 
> > Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
> > ---
> >  arch/x86/kernel/cpu/mtrr/cleanup.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> There's about 22 simple_strto*() uses remaining in arch/x86/ - 
> please send a single patch that addresses them in one go, 
> instead of these peacemail patches...
> 
Since I use my personal spare time doing this type of work it is easier
for me to work on one patch at a time, however I understand it will be
easier for you to pull in a single large patch as opposed to multiple. I
will pool my changes and send them in a single patch.

-- Shuah