All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, kvm-ppc@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/3] msi/msix: added functions to API to set up message address and data
Date: Wed, 13 Jun 2012 23:38:37 -0600	[thread overview]
Message-ID: <1339652317.24818.13.camel@ul30vt> (raw)
In-Reply-To: <4FD973F7.7080207@ozlabs.ru>

On Thu, 2012-06-14 at 15:17 +1000, Alexey Kardashevskiy wrote:
> On 14/06/12 14:56, Alex Williamson wrote:
> > On Thu, 2012-06-14 at 14:31 +1000, Alexey Kardashevskiy wrote:
> >> Normally QEMU expects the guest to initialize MSI/MSIX vectors.
> >> However on POWER the guest uses RTAS subsystem to configure MSI/MSIX and
> >> does not write these vectors to device's config space or MSIX BAR.
> >>
> >> On the other hand, msi_notify()/msix_notify() write to these vectors to
> >> signal the guest about an interrupt so we have to write correct vectors
> >> to the devices in order not to change every user of MSI/MSIX.
> >>
> >> The first aim is to support MSIX for virtio-pci on POWER. There is
> >> another patch for POWER coming which introduces a special memory region
> >> where MSI/MSIX vectors point to.
> >>
> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >> ---
> >>  hw/msi.c  |   14 ++++++++++++++
> >>  hw/msi.h  |    1 +
> >>  hw/msix.c |   10 ++++++++++
> >>  hw/msix.h |    3 +++
> >>  4 files changed, 28 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/msi.c b/hw/msi.c
> >> index 5d6ceb6..124878a 100644
> >> --- a/hw/msi.c
> >> +++ b/hw/msi.c
> >> @@ -358,3 +358,17 @@ unsigned int msi_nr_vectors_allocated(const PCIDevice *dev)
> >>      uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev));
> >>      return msi_nr_vectors(flags);
> >>  }
> >> +
> >> +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data)
> >> +{
> >> +    uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev));
> >> +    bool msi64bit = flags & PCI_MSI_FLAGS_64BIT;
> >> +
> >> +    if (msi64bit) {
> >> +        pci_set_quad(dev->config + msi_address_lo_off(dev), address);
> >> +    } else {
> >> +        pci_set_long(dev->config + msi_address_lo_off(dev), address);
> >> +    }
> >> +    pci_set_word(dev->config + msi_data_off(dev, msi64bit), data);
> >> +}
> > 
> > Why not make it msi_set_message() and pass MSIMessage?  I'd be great if
> > you tossed in a msi_get_message() as well, I think we need it to be able
> > to do a kvm_irqchip_add_msi_route() with MSI.  Thanks,
> 
> 
> I am missing the point. What is that MSIMessage?
> It is just an address and data, making a struct from this is a bit too much :)
> I am totally unfamiliar with kvm_irqchip_add_msi_route to see the bigger picture, sorry.

MSIVectorUseNotifier passes a MSIMessage back to the device when a
vector is unmasked.  We can then add a route in KVM for that message
with kvm_irqchip_add_msi_route.  Finally, kvm_irqchip_add_irqfd allows
us to connect that MSI route to an eventfd, such as from virtio or vfio.
Then MSI eventfds can bypass qemu and be injected directly into KVM and
on into the guest.  So we seem to already have some standardization on
passing address/data via an MSIMessage.

You need a "set" interface, I need a "get" interface.  msix already has
a static msix_get_message().  So I'd suggest that an exported
get/set_message for each seems like the right way to go.  Thanks,

Alex

  reply	other threads:[~2012-06-14  5:38 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14  4:29 [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER Alexey Kardashevskiy
2012-06-14  4:31 ` [Qemu-devel] [PATCH 1/3] msi/msix: added functions to API to set up message address and data Alexey Kardashevskiy
2012-06-14  4:56   ` Alex Williamson
2012-06-14  5:17     ` Alexey Kardashevskiy
2012-06-14  5:38       ` Alex Williamson [this message]
2012-06-14  5:44         ` Alexey Kardashevskiy
2012-06-14 18:37           ` Alex Williamson
2012-06-14  5:45       ` Jan Kiszka
2012-06-21  6:46         ` [Qemu-devel] [PATCH] msi/msix: added functions to API to set up message address, " Alexey Kardashevskiy
2012-06-21  6:53           ` Jan Kiszka
2012-06-21  7:18             ` [Qemu-devel] [PATCH] msi/msix: added public API to set/get MSI " Alexey Kardashevskiy
2012-06-21  7:39               ` Jan Kiszka
2012-06-21 10:28                 ` Alexey Kardashevskiy
2012-06-21 10:38                   ` Jan Kiszka
2012-06-21 10:50                     ` Alexey Kardashevskiy
2012-06-21 10:56                       ` Jan Kiszka
2012-06-21 11:39                         ` [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address " Alexey Kardashevskiy
2012-06-21 11:49                           ` Jan Kiszka
2012-06-22  1:03                             ` Alexey Kardashevskiy
2012-06-22  1:15                               ` Alexey Kardashevskiy
2012-07-02  4:28                                 ` Alexey Kardashevskiy
2012-07-02  7:24                                   ` Jan Kiszka
2012-07-06 15:36                                     ` Alexander Graf
2012-07-06 15:58                                       ` Jan Kiszka
2012-07-11 18:22                                         ` Alexander Graf
2012-07-18 12:43                           ` Michael S. Tsirkin
2012-07-18 13:17                             ` Alexey Kardashevskiy
2012-07-18 15:23                               ` Michael S. Tsirkin
2012-07-19  0:32                                 ` Alexey Kardashevskiy
2012-07-19  9:27                                   ` Michael S. Tsirkin
2012-07-19 14:24                                     ` Alexey Kardashevskiy
2012-07-19 14:43                                       ` Michael S. Tsirkin
2012-07-19 14:50                                         ` Alexey Kardashevskiy
2012-07-19 14:56                                           ` Michael S. Tsirkin
2012-07-19  0:35                                 ` Alexey Kardashevskiy
2012-07-19  9:27                                   ` Michael S. Tsirkin
2012-06-21 15:44                         ` [Qemu-devel] [PATCH] msi/msix: added public API to set/get MSI message address, " Alex Williamson
2012-06-14  4:33 ` [Qemu-devel] [PATCH 2/3] pseries: added allocator for a block of IRQs Alexey Kardashevskiy
2012-06-14  4:34 ` [Qemu-devel] [PATCH 3/3] pseries pci: added MSI/MSIX support Alexey Kardashevskiy
2012-06-14  4:42 ` [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339652317.24818.13.camel@ul30vt \
    --to=alex.williamson@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.