All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 12:41 ` Wanpeng Li
  0 siblings, 0 replies; 12+ messages in thread
From: Wanpeng Li @ 2012-06-14 12:41 UTC (permalink / raw)
  To: linux-mm
  Cc: Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman, Minchan Kim,
	linux-kernel, trivial, Gavin Shan, Wanpeng Li

From: Wanpeng Li <liwp@linux.vnet.ibm.com>

Since there are five lists in LRU cache, the array nr in get_scan_count
should be:

nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
nr[2] = file inactive pages to scan; nr[3] = file active pages to scan

Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
---
 mm/vmscan.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeb3bc9..ed823df 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc)
  * by looking at the fraction of the pages scanned we did rotate back
  * onto the active list instead of evict.
  *
- * nr[0] = anon pages to scan; nr[1] = file pages to scan
+ * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
+ * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
  */
 static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
 			   unsigned long *nr)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 12:41 ` Wanpeng Li
  0 siblings, 0 replies; 12+ messages in thread
From: Wanpeng Li @ 2012-06-14 12:41 UTC (permalink / raw)
  To: linux-mm
  Cc: Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman, Minchan Kim,
	linux-kernel, trivial, Gavin Shan, Wanpeng Li

From: Wanpeng Li <liwp@linux.vnet.ibm.com>

Since there are five lists in LRU cache, the array nr in get_scan_count
should be:

nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
nr[2] = file inactive pages to scan; nr[3] = file active pages to scan

Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
---
 mm/vmscan.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeb3bc9..ed823df 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc)
  * by looking at the fraction of the pages scanned we did rotate back
  * onto the active list instead of evict.
  *
- * nr[0] = anon pages to scan; nr[1] = file pages to scan
+ * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
+ * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
  */
 static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
 			   unsigned long *nr)
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
  2012-06-14 12:41 ` Wanpeng Li
@ 2012-06-14 15:02   ` Minchan Kim
  -1 siblings, 0 replies; 12+ messages in thread
From: Minchan Kim @ 2012-06-14 15:02 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On Thu, Jun 14, 2012 at 08:41:02PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> 
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
> 
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
> 
> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks!
 

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 15:02   ` Minchan Kim
  0 siblings, 0 replies; 12+ messages in thread
From: Minchan Kim @ 2012-06-14 15:02 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On Thu, Jun 14, 2012 at 08:41:02PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> 
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
> 
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
> 
> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks!
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
  2012-06-14 12:41 ` Wanpeng Li
@ 2012-06-14 17:51   ` Rik van Riel
  -1 siblings, 0 replies; 12+ messages in thread
From: Rik van Riel @ 2012-06-14 17:51 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On 06/14/2012 08:41 AM, Wanpeng Li wrote:
> From: Wanpeng Li<liwp@linux.vnet.ibm.com>
>
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
>
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
>
> Signed-off-by: Wanpeng Li<liwp.linux@gmail.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 17:51   ` Rik van Riel
  0 siblings, 0 replies; 12+ messages in thread
From: Rik van Riel @ 2012-06-14 17:51 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On 06/14/2012 08:41 AM, Wanpeng Li wrote:
> From: Wanpeng Li<liwp@linux.vnet.ibm.com>
>
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
>
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
>
> Signed-off-by: Wanpeng Li<liwp.linux@gmail.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
  2012-06-14 12:41 ` Wanpeng Li
@ 2012-06-16  7:18   ` Kamezawa Hiroyuki
  -1 siblings, 0 replies; 12+ messages in thread
From: Kamezawa Hiroyuki @ 2012-06-16  7:18 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, Mel Gorman, Minchan Kim, linux-kernel,
	trivial, Gavin Shan

(2012/06/14 21:41), Wanpeng Li wrote:
> From: Wanpeng Li<liwp@linux.vnet.ibm.com>
> 
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
> 
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
> 
> Signed-off-by: Wanpeng Li<liwp.linux@gmail.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
@ 2012-06-16  7:18   ` Kamezawa Hiroyuki
  0 siblings, 0 replies; 12+ messages in thread
From: Kamezawa Hiroyuki @ 2012-06-16  7:18 UTC (permalink / raw)
  To: Wanpeng Li
  Cc: linux-mm, Andrew Morton, Mel Gorman, Minchan Kim, linux-kernel,
	trivial, Gavin Shan

(2012/06/14 21:41), Wanpeng Li wrote:
> From: Wanpeng Li<liwp@linux.vnet.ibm.com>
> 
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
> 
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
> 
> Signed-off-by: Wanpeng Li<liwp.linux@gmail.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
  2012-06-14 12:38 ` ^[[A
@ 2012-06-14 15:20   ` KOSAKI Motohiro
  -1 siblings, 0 replies; 12+ messages in thread
From: KOSAKI Motohiro @ 2012-06-14 15:20 UTC (permalink / raw)
  To: [A
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On Thu, Jun 14, 2012 at 8:38 AM, [A <liwp.linux@gmail.com> wrote:
> From: Wanpeng Li <liwp.linux@gmail.com>
>
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
>
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
>
> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 15:20   ` KOSAKI Motohiro
  0 siblings, 0 replies; 12+ messages in thread
From: KOSAKI Motohiro @ 2012-06-14 15:20 UTC (permalink / raw)
  To: [A
  Cc: linux-mm, Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman,
	Minchan Kim, linux-kernel, trivial, Gavin Shan

On Thu, Jun 14, 2012 at 8:38 AM, [A <liwp.linux@gmail.com> wrote:
> From: Wanpeng Li <liwp.linux@gmail.com>
>
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
>
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
>
> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 12:38 ` ^[[A
  0 siblings, 0 replies; 12+ messages in thread
From: ^[[A @ 2012-06-14 12:38 UTC (permalink / raw)
  To: linux-mm
  Cc: Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman, Minchan Kim,
	linux-kernel, trivial, Gavin Shan, Wanpeng Li

From: Wanpeng Li <liwp.linux@gmail.com>

From: Wanpeng Li <liwp@linux.vnet.ibm.com>

Since there are five lists in LRU cache, the array nr in get_scan_count
should be:

nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
nr[2] = file inactive pages to scan; nr[3] = file active pages to scan

Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
---
 mm/vmscan.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeb3bc9..ed823df 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc)
  * by looking at the fraction of the pages scanned we did rotate back
  * onto the active list instead of evict.
  *
- * nr[0] = anon pages to scan; nr[1] = file pages to scan
+ * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
+ * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
  */
 static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
 			   unsigned long *nr)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] mm: fix page reclaim comment error
@ 2012-06-14 12:38 ` ^[[A
  0 siblings, 0 replies; 12+ messages in thread
From: ^[[A @ 2012-06-14 12:38 UTC (permalink / raw)
  To: linux-mm
  Cc: Andrew Morton, KAMEZAWA Hiroyuki, Mel Gorman, Minchan Kim,
	linux-kernel, trivial, Gavin Shan, Wanpeng Li

From: Wanpeng Li <liwp.linux@gmail.com>

From: Wanpeng Li <liwp@linux.vnet.ibm.com>

Since there are five lists in LRU cache, the array nr in get_scan_count
should be:

nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
nr[2] = file inactive pages to scan; nr[3] = file active pages to scan

Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
---
 mm/vmscan.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeb3bc9..ed823df 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc)
  * by looking at the fraction of the pages scanned we did rotate back
  * onto the active list instead of evict.
  *
- * nr[0] = anon pages to scan; nr[1] = file pages to scan
+ * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
+ * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
  */
 static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
 			   unsigned long *nr)
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-06-16  7:20 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-14 12:41 [PATCH] mm: fix page reclaim comment error Wanpeng Li
2012-06-14 12:41 ` Wanpeng Li
2012-06-14 15:02 ` Minchan Kim
2012-06-14 15:02   ` Minchan Kim
2012-06-14 17:51 ` Rik van Riel
2012-06-14 17:51   ` Rik van Riel
2012-06-16  7:18 ` Kamezawa Hiroyuki
2012-06-16  7:18   ` Kamezawa Hiroyuki
  -- strict thread matches above, loose matches on Subject: below --
2012-06-14 12:38 ^[[A
2012-06-14 12:38 ` ^[[A
2012-06-14 15:20 ` KOSAKI Motohiro
2012-06-14 15:20   ` KOSAKI Motohiro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.