From: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Subject: [PATCHv9 2/8] I2C: OMAP: Optimise the remove code
Date: Thu, 21 Jun 2012 15:38:43 +0530 [thread overview]
Message-ID: <1340273329-8319-3-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1340273329-8319-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
The omap_i2c_remove function may not be needed after
device exit so the memory could be freed.
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
drivers/i2c/busses/i2c-omap.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 9a54e88..d704f64 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1106,8 +1106,7 @@ err_release_region:
return r;
}
-static int
-omap_i2c_remove(struct platform_device *pdev)
+static int __devexit omap_i2c_remove(struct platform_device *pdev)
{
struct omap_i2c_dev *dev = platform_get_drvdata(pdev);
struct resource *mem;
@@ -1204,7 +1203,7 @@ static struct dev_pm_ops omap_i2c_pm_ops = {
static struct platform_driver omap_i2c_driver = {
.probe = omap_i2c_probe,
- .remove = omap_i2c_remove,
+ .remove = __devexit_p(omap_i2c_remove),
.driver = {
.name = "omap_i2c",
.owner = THIS_MODULE,
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti D)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv9 2/8] I2C: OMAP: Optimise the remove code
Date: Thu, 21 Jun 2012 15:38:43 +0530 [thread overview]
Message-ID: <1340273329-8319-3-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1340273329-8319-1-git-send-email-shubhrajyoti@ti.com>
The omap_i2c_remove function may not be needed after
device exit so the memory could be freed.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 9a54e88..d704f64 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1106,8 +1106,7 @@ err_release_region:
return r;
}
-static int
-omap_i2c_remove(struct platform_device *pdev)
+static int __devexit omap_i2c_remove(struct platform_device *pdev)
{
struct omap_i2c_dev *dev = platform_get_drvdata(pdev);
struct resource *mem;
@@ -1204,7 +1203,7 @@ static struct dev_pm_ops omap_i2c_pm_ops = {
static struct platform_driver omap_i2c_driver = {
.probe = omap_i2c_probe,
- .remove = omap_i2c_remove,
+ .remove = __devexit_p(omap_i2c_remove),
.driver = {
.name = "omap_i2c",
.owner = THIS_MODULE,
--
1.7.5.4
next prev parent reply other threads:[~2012-06-21 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 10:08 [PATCHv9 0/8] I2C cleanups Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 1/8] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
[not found] ` <1340273329-8319-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-21 10:08 ` Shubhrajyoti D [this message]
2012-06-21 10:08 ` [PATCHv9 2/8] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 3/8] I2C: OMAP: use devm_* functions Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-25 9:51 ` Felipe Balbi
2012-06-25 9:51 ` Felipe Balbi
2012-06-25 10:27 ` Shubhrajyoti Datta
2012-06-25 10:27 ` Shubhrajyoti Datta
2012-06-21 10:08 ` [PATCHv9 4/8] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 5/8] I2C: OMAP: Do not initialise the completion everytime Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 6/8] I2C: OMAP: Remove the definition of SYSS_RESETDONE_MASK Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 7/8] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
2012-06-21 10:08 ` [PATCHv9 8/8] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
2012-06-21 10:08 ` Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340273329-8319-3-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti-l0cymroini0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.