All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings
@ 2012-06-22 13:39 Richard Purdie
  2012-06-22 14:17 ` Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2012-06-22 13:39 UTC (permalink / raw)
  To: openembedded-core

Many people are seeing issues from the empty path warnings from BBPATH.
The empty path entry corresponding to the current working directory is a
problem since if cwd changes, so does BBPATH and build reproducibility.

Simply removing the empty element causes problems since the build
directory then isn't listed in BBPATH which means local.conf isn't found
and this gives an extremely confusing error message about bbappends
being unsatisfied.

The build directory in bitbake terms is TOPDIR. The correct way to fix
things is to add in TOPDIR into bblayers.conf itself. This means the
layers can happily append/prepend to BBPATH at will as its no longer
empty hence neatly solving all the various problems. Since the file has
changed, the version is also changed.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

---
 meta/conf/bblayers.conf.sample |    4 +++-
 meta/conf/layer.conf           |    1 -
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample
index 222b03a..e621866 100644
--- a/meta/conf/bblayers.conf.sample
+++ b/meta/conf/bblayers.conf.sample
@@ -1,8 +1,10 @@
 # LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
 # changes incompatibly
-LCONF_VERSION = "4"
+LCONF_VERSION = "5"
 
+BBPATH = "${TOPDIR}"
 BBFILES ?= ""
+
 BBLAYERS ?= " \
   ##COREBASE##/meta \
   "
diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 43e4295..090c8e2 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -1,4 +1,3 @@
-BBPATH ?= ""
 # We have a conf and classes directory, add to BBPATH
 BBPATH .= ":${LAYERDIR}"
 # We have a packages directory, add to BBFILES




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings
  2012-06-22 13:39 [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings Richard Purdie
@ 2012-06-22 14:17 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2012-06-22 14:17 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Fri, Jun 22, 2012 at 6:39 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Many people are seeing issues from the empty path warnings from BBPATH.
> The empty path entry corresponding to the current working directory is a
> problem since if cwd changes, so does BBPATH and build reproducibility.
>
> Simply removing the empty element causes problems since the build
> directory then isn't listed in BBPATH which means local.conf isn't found
> and this gives an extremely confusing error message about bbappends
> being unsatisfied.
>
> The build directory in bitbake terms is TOPDIR. The correct way to fix
> things is to add in TOPDIR into bblayers.conf itself. This means the
> layers can happily append/prepend to BBPATH at will as its no longer
> empty hence neatly solving all the various problems. Since the file has
> changed, the version is also changed.


thanks this is fine


>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> ---
>  meta/conf/bblayers.conf.sample |    4 +++-
>  meta/conf/layer.conf           |    1 -
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample
> index 222b03a..e621866 100644
> --- a/meta/conf/bblayers.conf.sample
> +++ b/meta/conf/bblayers.conf.sample
> @@ -1,8 +1,10 @@
>  # LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
>  # changes incompatibly
> -LCONF_VERSION = "4"
> +LCONF_VERSION = "5"
>
> +BBPATH = "${TOPDIR}"
>  BBFILES ?= ""
> +
>  BBLAYERS ?= " \
>   ##COREBASE##/meta \
>   "
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index 43e4295..090c8e2 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -1,4 +1,3 @@
> -BBPATH ?= ""
>  # We have a conf and classes directory, add to BBPATH
>  BBPATH .= ":${LAYERDIR}"
>  # We have a packages directory, add to BBFILES
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-22 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-22 13:39 [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings Richard Purdie
2012-06-22 14:17 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.