* [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address
@ 2012-06-25 16:37 Luke Lowrey
2012-06-26 6:37 ` Prafulla Wadaskar
2012-07-03 10:45 ` Heiko Schocher
0 siblings, 2 replies; 3+ messages in thread
From: Luke Lowrey @ 2012-06-25 16:37 UTC (permalink / raw)
To: u-boot
Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x)
returns the correct address.
Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the
address for port 0 and vice versa.
Doesn't have any knock on effects to the u-boot code as the only
time they're used is to do the same function to both addresses
Signed-off-by: Luke Lowrey <luke@chamsys.co.uk>
---
arch/arm/include/asm/arch-kirkwood/cpu.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h b/arch/arm/include/asm/arch-kirkwood/cpu.h
index d28c51a..784ba87 100644
--- a/arch/arm/include/asm/arch-kirkwood/cpu.h
+++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
@@ -33,7 +33,7 @@
| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
#define KWGBE_PORT_SERIAL_CONTROL1_REG(_x) \
- ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
+ ((_x ? KW_EGIGA1_BASE : KW_EGIGA0_BASE) + 0x44c)
#define KW_REG_PCIE_DEVID (KW_REG_PCIE_BASE + 0x00)
#define KW_REG_PCIE_REVID (KW_REG_PCIE_BASE + 0x08)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address
2012-06-25 16:37 [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address Luke Lowrey
@ 2012-06-26 6:37 ` Prafulla Wadaskar
2012-07-03 10:45 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Prafulla Wadaskar @ 2012-06-26 6:37 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Luke Lowrey
> Sent: 25 June 2012 22:07
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning
> incorrect address
>
> Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x)
> returns the correct address.
>
> Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the
> address for port 0 and vice versa.
>
> Doesn't have any knock on effects to the u-boot code as the only
> time they're used is to do the same function to both addresses
>
> Signed-off-by: Luke Lowrey <luke@chamsys.co.uk>
> ---
> arch/arm/include/asm/arch-kirkwood/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> b/arch/arm/include/asm/arch-kirkwood/cpu.h
> index d28c51a..784ba87 100644
> --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> @@ -33,7 +33,7 @@
> | (attr << 8) | (kw_winctrl_calcsize(size) << 16))
>
> #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x) \
> - ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
> + ((_x ? KW_EGIGA1_BASE : KW_EGIGA0_BASE) + 0x44c)
>
> #define KW_REG_PCIE_DEVID (KW_REG_PCIE_BASE + 0x00)
> #define KW_REG_PCIE_REVID (KW_REG_PCIE_BASE + 0x08)
> --
Acked-by: Prafulla Wadaskar <Prafulla@marvell.com>
Regards..
Prafulla . . .
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address
2012-06-25 16:37 [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address Luke Lowrey
2012-06-26 6:37 ` Prafulla Wadaskar
@ 2012-07-03 10:45 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2012-07-03 10:45 UTC (permalink / raw)
To: u-boot
Hello Luke,
On 25.06.2012 18:37, Luke Lowrey wrote:
> Modified the arch-kirkwood header so KWGBE_PORT_SERIAL_CONTROL1_REG(x)
> returns the correct address.
>
> Originally calling KWGBE_PORT_SERIAL_CONTROL1_REG(1) returned the
> address for port 0 and vice versa.
>
> Doesn't have any knock on effects to the u-boot code as the only
> time they're used is to do the same function to both addresses
>
> Signed-off-by: Luke Lowrey<luke@chamsys.co.uk>
> ---
> arch/arm/include/asm/arch-kirkwood/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-03 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-25 16:37 [U-Boot] [PATCH] arch-kirkwood: Ethernet port macro returning incorrect address Luke Lowrey
2012-06-26 6:37 ` Prafulla Wadaskar
2012-07-03 10:45 ` Heiko Schocher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.