* [PATCH] mtd: chips: reorganize Kconfig help on swapping
@ 2012-06-19 11:52 Paul Bolle
2012-06-27 12:57 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2012-06-19 11:52 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd, linux-kernel
The Kconfig help on "Flash cmd/query data swapping" still mentions
LART_ENDIAN_BYTE. That option used to be relevant for setting
CONFIG_MTD_CFI_LART_BIT_SWAP. That option and macro got both removed in
v2.4.11-pre4. So, although LART endianness sounds intriguing, that part
of the help text can be removed.
And, while we're touching this choice, move the help text up one level.
Currently it's available under the "NO" option, while it's relevant for
all three options.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested only with "make menuconfig".
1) Triggers a checkpatch warning: "please write a paragraph that
describes the config symbol fully". That's a bit of a false positive
here (also see the comment starting at line 1708 in checkpatch.pl).
drivers/mtd/chips/Kconfig | 11 ++---------
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
index b1e3c26..e469b01 100644
--- a/drivers/mtd/chips/Kconfig
+++ b/drivers/mtd/chips/Kconfig
@@ -43,9 +43,6 @@ choice
prompt "Flash cmd/query data swapping"
depends on MTD_CFI_ADV_OPTIONS
default MTD_CFI_NOSWAP
-
-config MTD_CFI_NOSWAP
- bool "NO"
---help---
This option defines the way in which the CPU attempts to arrange
data bits when writing the 'magic' commands to the chips. Saying
@@ -55,12 +52,8 @@ config MTD_CFI_NOSWAP
Specific arrangements are possible with the BIG_ENDIAN_BYTE and
LITTLE_ENDIAN_BYTE, if the bytes are reversed.
- If you have a LART, on which the data (and address) lines were
- connected in a fashion which ensured that the nets were as short
- as possible, resulting in a bit-shuffling which seems utterly
- random to the untrained eye, you need the LART_ENDIAN_BYTE option.
-
- Yes, there really exists something sicker than PDP-endian :)
+config MTD_CFI_NOSWAP
+ bool "NO"
config MTD_CFI_BE_BYTE_SWAP
bool "BIG_ENDIAN_BYTE"
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: chips: reorganize Kconfig help on swapping
2012-06-19 11:52 [PATCH] mtd: chips: reorganize Kconfig help on swapping Paul Bolle
@ 2012-06-27 12:57 ` Artem Bityutskiy
0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-06-27 12:57 UTC (permalink / raw)
To: Paul Bolle; +Cc: David Woodhouse, linux-mtd, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Tue, 2012-06-19 at 13:52 +0200, Paul Bolle wrote:
> The Kconfig help on "Flash cmd/query data swapping" still mentions
> LART_ENDIAN_BYTE. That option used to be relevant for setting
> CONFIG_MTD_CFI_LART_BIT_SWAP. That option and macro got both removed in
> v2.4.11-pre4. So, although LART endianness sounds intriguing, that part
> of the help text can be removed.
>
> And, while we're touching this choice, move the help text up one level.
> Currently it's available under the "NO" option, while it's relevant for
> all three options.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: chips: reorganize Kconfig help on swapping
@ 2012-06-27 12:57 ` Artem Bityutskiy
0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-06-27 12:57 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-mtd, David Woodhouse, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Tue, 2012-06-19 at 13:52 +0200, Paul Bolle wrote:
> The Kconfig help on "Flash cmd/query data swapping" still mentions
> LART_ENDIAN_BYTE. That option used to be relevant for setting
> CONFIG_MTD_CFI_LART_BIT_SWAP. That option and macro got both removed in
> v2.4.11-pre4. So, although LART endianness sounds intriguing, that part
> of the help text can be removed.
>
> And, while we're touching this choice, move the help text up one level.
> Currently it's available under the "NO" option, while it's relevant for
> all three options.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-27 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-19 11:52 [PATCH] mtd: chips: reorganize Kconfig help on swapping Paul Bolle
2012-06-27 12:57 ` Artem Bityutskiy
2012-06-27 12:57 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.