All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Matt Wilson <msw@amazon.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xl: rename "list-vm" command to "vm-list"
Date: Thu, 28 Jun 2012 08:41:25 +0100	[thread overview]
Message-ID: <1340869285.5210.19.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20120628073758.GB9080@US-SEA-R8XVZTX>

On Thu, 2012-06-28 at 08:37 +0100, Matt Wilson wrote:
> On Thu, Jun 28, 2012 at 12:36:17AM -0700, Ian Campbell wrote:
> > > > On Thu, 2012-06-28 at 07:46 +0100, Matt Wilson wrote:
> > > > > All of the other "list" verbs are of the form "$noun-list". For
> > > > > example: "pci-list", "vcpu-list", "network-list", "block-list", etc.
> > > > > Additionally, many people have well trained muscle memory from years
> > > > > of typing "xm li". "xl li" was ambiguous due to "xl list-vm" resulted
> > > > > in "command not implemented".
> > > > 
> > > > Which did xm have list-vm or vm-list (or neither?) 
> > > 
> > > Neither.
> > 
> > In which case I would ack the patch except you forgot to update
> > docs/man/xl*.pod.? (hrm, somehow list-vm isn't there -- can you add
> > vm-list anyway?)
> 
> I grepped for list-vm in the whole xen source tree, trying to make
> sure that I updated any corresponding docs. I guess that means I
> didn't notice it not being documented at all. :-P

I only double checked because I'm pretty sure xl.pod.1 was started with
a grep over xl_cmdtable.c so I can't see how we missed it...

> v2 in a moment.

Thanks!

  reply	other threads:[~2012-06-28  7:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  6:46 [PATCH] xl: rename "list-vm" command to "vm-list" Matt Wilson
2012-06-28  6:59 ` Ian Campbell
2012-06-28  7:28   ` Matt Wilson
2012-06-28  7:36     ` Ian Campbell
2012-06-28  7:37       ` Matt Wilson
2012-06-28  7:41         ` Ian Campbell [this message]
2012-06-28  7:59 Matt Wilson
2012-06-28  8:35 ` Ian Campbell
2012-06-28 15:08 ` Ian Jackson
2012-06-28 15:14   ` Ian Campbell
2012-06-28 16:18     ` Ian Jackson
2012-06-28 17:07   ` Matt Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340869285.5210.19.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=msw@amazon.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.