From: Matt Wilson <msw@amazon.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: [PATCH] xl: rename "list-vm" command to "vm-list"
Date: Thu, 28 Jun 2012 07:59:22 +0000 [thread overview]
Message-ID: <5b1ed71c74d675866513.1340870362@kaos-source-31003.sea31.amazon.com> (raw)
All of the other "list" verbs are of the form "$noun-list". For
example: "pci-list", "vcpu-list", "network-list", "block-list", etc.
Additionally, many people have well trained muscle memory from years
of typing "xm li". "xl li" was ambiguous due to "xl list-vm" resulted
in "command not implemented".
Finally, this command was missing from the xl man page.
Signed-off-by: Matt Wilson <msw@amazon.com>
diff -r 32034d1914a6 -r 5b1ed71c74d6 docs/man/xl.pod.1
--- a/docs/man/xl.pod.1 Thu Jun 07 19:46:57 2012 +0100
+++ b/docs/man/xl.pod.1 Thu Jun 28 06:34:26 2012 +0000
@@ -617,6 +617,18 @@ different run state is appropriate. Pin
this, by ensuring certain VCPUs can only run on certain physical
CPUs.
+=item B<vm-list>
+
+Prints information about all domains except for dom0.
+
+B<EXAMPLE>
+
+An example format for the list is as follows:
+
+UUID ID name
+59e1cf6c-6ab9-4879-90e7-adc8d1c63bf5 2 win
+50bc8f75-81d0-4d53-b2e6-95cb44e2682e 3 linux
+
=item B<vncviewer> [I<OPTIONS>] I<domain-id>
Attach to domain's VNC server, forking a vncviewer process.
diff -r 32034d1914a6 -r 5b1ed71c74d6 tools/libxl/xl.h
--- a/tools/libxl/xl.h Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl.h Thu Jun 28 06:34:26 2012 +0000
@@ -54,7 +54,7 @@ int main_destroy(int argc, char **argv);
int main_shutdown(int argc, char **argv);
int main_reboot(int argc, char **argv);
int main_list(int argc, char **argv);
-int main_list_vm(int argc, char **argv);
+int main_vm_list(int argc, char **argv);
int main_create(int argc, char **argv);
int main_config_update(int argc, char **argv);
int main_button_press(int argc, char **argv);
diff -r 32034d1914a6 -r 5b1ed71c74d6 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl_cmdimpl.c Thu Jun 28 06:34:26 2012 +0000
@@ -3623,11 +3623,11 @@ int main_list(int argc, char **argv)
return 0;
}
-int main_list_vm(int argc, char **argv)
+int main_vm_list(int argc, char **argv)
{
int opt;
- if ((opt = def_getopt(argc, argv, "", "list-vm", 0)) != -1)
+ if ((opt = def_getopt(argc, argv, "", "vm-list", 0)) != -1)
return opt;
list_vm();
diff -r 32034d1914a6 -r 5b1ed71c74d6 tools/libxl/xl_cmdtable.c
--- a/tools/libxl/xl_cmdtable.c Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl_cmdtable.c Thu Jun 28 06:34:26 2012 +0000
@@ -214,9 +214,9 @@ struct cmd_spec cmd_table[] = {
"Set the number of active VCPUs allowed for the domain",
"<Domain> <vCPUs>",
},
- { "list-vm",
- &main_list_vm, 0, 0,
- "List the VMs,without DOM0",
+ { "vm-list",
+ &main_vm_list, 0, 0,
+ "List the VMs, without DOM0",
"",
},
{ "info",
next reply other threads:[~2012-06-28 7:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 7:59 Matt Wilson [this message]
2012-06-28 8:35 ` [PATCH] xl: rename "list-vm" command to "vm-list" Ian Campbell
2012-06-28 15:08 ` Ian Jackson
2012-06-28 15:14 ` Ian Campbell
2012-06-28 16:18 ` Ian Jackson
2012-06-28 17:07 ` Matt Wilson
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 6:46 Matt Wilson
2012-06-28 6:59 ` Ian Campbell
2012-06-28 7:28 ` Matt Wilson
2012-06-28 7:36 ` Ian Campbell
2012-06-28 7:37 ` Matt Wilson
2012-06-28 7:41 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b1ed71c74d675866513.1340870362@kaos-source-31003.sea31.amazon.com \
--to=msw@amazon.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.