* [PATCH] i2c-s3c2410: Use plain pm_runtime_put()
@ 2012-06-28 13:08 Mark Brown
2012-06-29 9:30 ` Shubhrajyoti Datta
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-06-28 13:08 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-samsung-soc, linux-i2c, Mark Brown
There's no point in using _sync() as we don't really care if the suspend
has completed immediately.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index ddd5797..c4a4494 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -608,7 +608,7 @@ static int s3c24xx_i2c_xfer(struct i2c_adapter *adap,
if (ret != -EAGAIN) {
clk_disable(i2c->clk);
- pm_runtime_put_sync(&adap->dev);
+ pm_runtime_put(&adap->dev);
return ret;
}
@@ -618,7 +618,7 @@ static int s3c24xx_i2c_xfer(struct i2c_adapter *adap,
}
clk_disable(i2c->clk);
- pm_runtime_put_sync(&adap->dev);
+ pm_runtime_put(&adap->dev);
return -EREMOTEIO;
}
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c-s3c2410: Use plain pm_runtime_put()
2012-06-28 13:08 [PATCH] i2c-s3c2410: Use plain pm_runtime_put() Mark Brown
@ 2012-06-29 9:30 ` Shubhrajyoti Datta
0 siblings, 0 replies; 2+ messages in thread
From: Shubhrajyoti Datta @ 2012-06-29 9:30 UTC (permalink / raw)
To: Mark Brown; +Cc: Wolfram Sang, linux-samsung-soc, linux-i2c
Hi Mark,
On Thu, Jun 28, 2012 at 6:38 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> There's no point in using _sync() as we don't really care if the suspend
> has completed immediately.
Agree.
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index ddd5797..c4a4494 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -608,7 +608,7 @@ static int s3c24xx_i2c_xfer(struct i2c_adapter *adap,
>
> if (ret != -EAGAIN) {
> clk_disable(i2c->clk);
> - pm_runtime_put_sync(&adap->dev);
> + pm_runtime_put(&adap->dev);
Especially if we are retrying in 100us :-)
> return ret;
> }
>
> @@ -618,7 +618,7 @@ static int s3c24xx_i2c_xfer(struct i2c_adapter *adap,
> }
>
> clk_disable(i2c->clk);
> - pm_runtime_put_sync(&adap->dev);
> + pm_runtime_put(&adap->dev);
> return -EREMOTEIO;
> }
>
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-29 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-28 13:08 [PATCH] i2c-s3c2410: Use plain pm_runtime_put() Mark Brown
2012-06-29 9:30 ` Shubhrajyoti Datta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.