* [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars
@ 2012-06-28 15:10 Roger Pau Monne
2012-06-29 14:39 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2012-06-28 15:10 UTC (permalink / raw)
To: xen-devel; +Cc: Christoph Egger, Ian Jackson, Roger Pau Monne
Parse those options correctly, since the "+=" operator is not valid.
Also added CPPFLAGS, so headers checks don't give strange results.
Please rerun configure after applying.
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>
Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
---
tools/m4/set_cflags_ldflags.m4 | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/m4/set_cflags_ldflags.m4 b/tools/m4/set_cflags_ldflags.m4
index 7e357ba..cbad3c1 100644
--- a/tools/m4/set_cflags_ldflags.m4
+++ b/tools/m4/set_cflags_ldflags.m4
@@ -1,20 +1,20 @@
AC_DEFUN([AX_SET_FLAGS],
-[for cflag in $PREPEND_INCLUDES
+[for cppflag in $PREPEND_INCLUDES
do
- PREPEND_CFLAGS+=" -I$cflag"
+ PREPEND_CPPFLAGS="$PREPEND_CPPFLAGS -I$cppflag"
done
for ldflag in $PREPEND_LIB
do
- PREPEND_LDFLAGS+=" -L$ldflag"
+ PREPEND_LDFLAGS="$PREPEND_LDFLAGS -L$ldflag"
done
-for cflag in $APPEND_INCLUDES
+for cppflag in $APPEND_INCLUDES
do
- APPEND_CFLAGS+=" -I$cflag"
+ APPEND_CPPFLAGS="$APPEND_CPPFLAGS -I$cppflag"
done
for ldflag in $APPEND_LIB
do
- APPEND_LDFLAGS+=" -L$ldflag"
+ APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
done
-CFLAGS="$PREPEND_CFLAGS $CFLAGS $APPEND_CFLAGS"
+CPPFLAGS="$PREPEND_CPPFLAGS $CPPFLAGS $APPEND_CPPFLAGS"
LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPEND_LDFLAGS"])
--
1.7.7.5 (Apple Git-26)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars
2012-06-28 15:10 [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars Roger Pau Monne
@ 2012-06-29 14:39 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2012-06-29 14:39 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Christoph Egger, xen-devel
Roger Pau Monne writes ("[Xen-devel] [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars"):
> Parse those options correctly, since the "+=" operator is not valid.
> Also added CPPFLAGS, so headers checks don't give strange results.
>
> Please rerun configure after applying.
>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Christoph Egger <Christoph.Egger@amd.com>
> Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-29 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-28 15:10 [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars Roger Pau Monne
2012-06-29 14:39 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.