From: Shubhrajyoti D <shubhrajyoti@ti.com> To: linux-omap@vger.kernel.org Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org, tony@atomide.com, w.sang@pengutronix.de, Shubhrajyoti D <shubhrajyoti@ti.com> Subject: [PATCHv11 1/6] i2c: omap: Optimise the remove code Date: Thu, 28 Jun 2012 20:41:27 +0530 [thread overview] Message-ID: <1340896292-12112-2-git-send-email-shubhrajyoti@ti.com> (raw) In-Reply-To: <1340896292-12112-1-git-send-email-shubhrajyoti@ti.com> The omap_i2c_remove function may not be needed after device exit so the memory could be freed. Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> --- drivers/i2c/busses/i2c-omap.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 9895fa7..b086076 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1102,8 +1102,7 @@ err_release_region: return r; } -static int -omap_i2c_remove(struct platform_device *pdev) +static int __devexit omap_i2c_remove(struct platform_device *pdev) { struct omap_i2c_dev *dev = platform_get_drvdata(pdev); struct resource *mem; @@ -1187,7 +1186,7 @@ static struct dev_pm_ops omap_i2c_pm_ops = { static struct platform_driver omap_i2c_driver = { .probe = omap_i2c_probe, - .remove = omap_i2c_remove, + .remove = __devexit_p(omap_i2c_remove), .driver = { .name = "omap_i2c", .owner = THIS_MODULE, -- 1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti D) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv11 1/6] i2c: omap: Optimise the remove code Date: Thu, 28 Jun 2012 20:41:27 +0530 [thread overview] Message-ID: <1340896292-12112-2-git-send-email-shubhrajyoti@ti.com> (raw) In-Reply-To: <1340896292-12112-1-git-send-email-shubhrajyoti@ti.com> The omap_i2c_remove function may not be needed after device exit so the memory could be freed. Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> --- drivers/i2c/busses/i2c-omap.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 9895fa7..b086076 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1102,8 +1102,7 @@ err_release_region: return r; } -static int -omap_i2c_remove(struct platform_device *pdev) +static int __devexit omap_i2c_remove(struct platform_device *pdev) { struct omap_i2c_dev *dev = platform_get_drvdata(pdev); struct resource *mem; @@ -1187,7 +1186,7 @@ static struct dev_pm_ops omap_i2c_pm_ops = { static struct platform_driver omap_i2c_driver = { .probe = omap_i2c_probe, - .remove = omap_i2c_remove, + .remove = __devexit_p(omap_i2c_remove), .driver = { .name = "omap_i2c", .owner = THIS_MODULE, -- 1.7.5.4
next prev parent reply other threads:[~2012-06-28 15:11 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-28 15:11 [PATCHv11 0/6] I2C cleanups Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D [this message] 2012-06-28 15:11 ` [PATCHv11 1/6] i2c: omap: Optimise the remove code Shubhrajyoti D [not found] ` <1340896292-12112-2-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-07-12 12:18 ` Wolfram Sang 2012-07-12 12:18 ` Wolfram Sang 2012-07-13 11:21 ` Shubhrajyoti 2012-07-13 11:21 ` Shubhrajyoti 2012-06-28 15:11 ` [PATCHv11 2/6] i2c: omap: Use SET_RUNTIME_PM_OPS Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D 2012-07-12 12:19 ` Wolfram Sang 2012-07-12 12:19 ` Wolfram Sang 2012-06-28 15:11 ` [PATCHv11 3/6] i2c: omap: Do not initialise the completion everytime Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D [not found] ` <1340896292-12112-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-06-28 16:03 ` ABRAHAM, KISHON VIJAY 2012-06-28 16:03 ` ABRAHAM, KISHON VIJAY [not found] ` <CAAe_U6Jtoj3mixvp+vqNmkr-RC28AfNqZ0syEE5voEr+Odv3zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2012-06-29 1:34 ` Zhang, Shijie 2012-06-29 1:34 ` Zhang, Shijie 2012-07-12 12:19 ` Wolfram Sang 2012-07-12 12:19 ` Wolfram Sang [not found] ` <20120712121928.GC2194-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 11:05 ` Shubhrajyoti 2012-07-13 11:05 ` Shubhrajyoti [not found] ` <1340896292-12112-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-06-28 15:11 ` [PATCHv11 4/6] i2c: omap: Remove the definition of SYSS_RESETDONE_MASK Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D [not found] ` <1340896292-12112-5-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-07-12 12:20 ` Wolfram Sang 2012-07-12 12:20 ` Wolfram Sang [not found] ` <20120712122053.GD2194-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 11:05 ` Shubhrajyoti 2012-07-13 11:05 ` Shubhrajyoti 2012-06-28 15:11 ` [PATCHv11 6/6] i2c: omap: Recover from Bus Busy condition Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D [not found] ` <1340896292-12112-7-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-07-12 12:22 ` Wolfram Sang 2012-07-12 12:22 ` Wolfram Sang [not found] ` <20120712122208.GF2194-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 11:04 ` Shubhrajyoti 2012-07-13 11:04 ` Shubhrajyoti 2012-06-28 15:11 ` [PATCHv11 5/6] i2c: omap: Correct I2C revision for OMAP3 Shubhrajyoti D 2012-06-28 15:11 ` Shubhrajyoti D [not found] ` <1340896292-12112-6-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-07-12 12:21 ` Wolfram Sang 2012-07-12 12:21 ` Wolfram Sang 2012-07-13 11:04 ` Shubhrajyoti 2012-07-13 11:04 ` Shubhrajyoti 2012-07-09 11:47 ` [PATCHv11 0/6] I2C cleanups Shubhrajyoti Datta 2012-07-09 11:47 ` Shubhrajyoti Datta 2012-07-12 12:52 ` Wolfram Sang 2012-07-12 12:52 ` Wolfram Sang [not found] ` <20120712125229.GG2194-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 11:25 ` Shubhrajyoti 2012-07-13 11:25 ` Shubhrajyoti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1340896292-12112-2-git-send-email-shubhrajyoti@ti.com \ --to=shubhrajyoti@ti.com \ --cc=ben-linux@fluff.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ --cc=w.sang@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.