From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, linux-pci <linux-pci@vger.kernel.org>,
iommu <iommu@lists.linux-foundation.org>,
qemu-devel <qemu-devel@nongnu.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Gibson <david@gibson.dropbear.id.au>,
chrisw <chrisw@sous-sol.org>,
"Roedel, Joerg" <Joerg.Roedel@amd.com>,
linux-next@vger.kernel.org
Subject: Re: Request VFIO inclusion in linux-next
Date: Sun, 01 Jul 2012 22:14:20 -0600 [thread overview]
Message-ID: <1341202460.1207.384.camel@bling.home> (raw)
In-Reply-To: <4FF11855.2060605@ozlabs.ru>
On Mon, 2012-07-02 at 13:41 +1000, Alexey Kardashevskiy wrote:
> On 27/06/12 22:37, Dan Carpenter wrote:
> > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote:
> >> Hi,
> >>
> >> VFIO has been kicking around for well over a year now and has been
> >> posted numerous times for review. The pre-requirements are finally
> >> available in linux-next (or will be in the 20120626 build) so I'd like
> >> to request a new branch be included in linux-next with a goal of being
> >> accepted into v3.6.
> >>
> >
> > Could you run Sparse over the driver?
> > http://lwn.net/Articles/205624/
> >
> > It reports a bunch of endian problems. Some are definitely bugs
> > like:
> > *prev |= cpu_to_le32((u32)epos << 20);
>
>
> What is wrong here?
I believe the only thing wrong here was that prev was a u32* instead of
a __le32*. The new version in my tree has much better endian annotation
after going through all the sparse errors. The only bug I found in the
cleanup was the handling of rbar. It was missing the le32_to_cpu as we
copied it out of vconfig. This is later used with
pci_user_write_config_dword, so it needs to be in native endian.
Thanks,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexey Kardashevskiy <aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
kvm <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
qemu-devel <qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org>,
chrisw <chrisw-69jw2NvuJkxg9hUCZPvPmw@public.gmane.org>,
iommu
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci <linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Subject: Re: Request VFIO inclusion in linux-next
Date: Sun, 01 Jul 2012 22:14:20 -0600 [thread overview]
Message-ID: <1341202460.1207.384.camel@bling.home> (raw)
In-Reply-To: <4FF11855.2060605-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>
On Mon, 2012-07-02 at 13:41 +1000, Alexey Kardashevskiy wrote:
> On 27/06/12 22:37, Dan Carpenter wrote:
> > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote:
> >> Hi,
> >>
> >> VFIO has been kicking around for well over a year now and has been
> >> posted numerous times for review. The pre-requirements are finally
> >> available in linux-next (or will be in the 20120626 build) so I'd like
> >> to request a new branch be included in linux-next with a goal of being
> >> accepted into v3.6.
> >>
> >
> > Could you run Sparse over the driver?
> > http://lwn.net/Articles/205624/
> >
> > It reports a bunch of endian problems. Some are definitely bugs
> > like:
> > *prev |= cpu_to_le32((u32)epos << 20);
>
>
> What is wrong here?
I believe the only thing wrong here was that prev was a u32* instead of
a __le32*. The new version in my tree has much better endian annotation
after going through all the sparse errors. The only bug I found in the
cleanup was the handling of rbar. It was missing the le32_to_cpu as we
copied it out of vconfig. This is later used with
pci_user_write_config_dword, so it needs to be in native endian.
Thanks,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
kvm <kvm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Roedel, Joerg" <Joerg.Roedel@amd.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>, chrisw <chrisw@sous-sol.org>,
iommu <iommu@lists.linux-foundation.org>,
linux-next@vger.kernel.org, linux-pci <linux-pci@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] Request VFIO inclusion in linux-next
Date: Sun, 01 Jul 2012 22:14:20 -0600 [thread overview]
Message-ID: <1341202460.1207.384.camel@bling.home> (raw)
In-Reply-To: <4FF11855.2060605@ozlabs.ru>
On Mon, 2012-07-02 at 13:41 +1000, Alexey Kardashevskiy wrote:
> On 27/06/12 22:37, Dan Carpenter wrote:
> > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote:
> >> Hi,
> >>
> >> VFIO has been kicking around for well over a year now and has been
> >> posted numerous times for review. The pre-requirements are finally
> >> available in linux-next (or will be in the 20120626 build) so I'd like
> >> to request a new branch be included in linux-next with a goal of being
> >> accepted into v3.6.
> >>
> >
> > Could you run Sparse over the driver?
> > http://lwn.net/Articles/205624/
> >
> > It reports a bunch of endian problems. Some are definitely bugs
> > like:
> > *prev |= cpu_to_le32((u32)epos << 20);
>
>
> What is wrong here?
I believe the only thing wrong here was that prev was a u32* instead of
a __le32*. The new version in my tree has much better endian annotation
after going through all the sparse errors. The only bug I found in the
cleanup was the handling of rbar. It was missing the le32_to_cpu as we
copied it out of vconfig. This is later used with
pci_user_write_config_dword, so it needs to be in native endian.
Thanks,
Alex
next prev parent reply other threads:[~2012-07-02 4:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 4:55 Request VFIO inclusion in linux-next Alex Williamson
2012-06-26 4:55 ` Alex Williamson
2012-06-26 21:17 ` Benjamin Herrenschmidt
2012-06-26 21:17 ` Benjamin Herrenschmidt
2012-06-26 23:50 ` Stephen Rothwell
2012-06-27 12:37 ` Dan Carpenter
2012-06-27 12:37 ` Dan Carpenter
2012-06-27 19:23 ` Alex Williamson
2012-06-27 19:23 ` Alex Williamson
2012-06-28 6:44 ` Dan Carpenter
2012-06-28 6:44 ` Dan Carpenter
2012-07-02 3:41 ` Alexey Kardashevskiy
2012-07-02 3:41 ` [Qemu-devel] " Alexey Kardashevskiy
2012-07-02 4:14 ` Alex Williamson [this message]
2012-07-02 4:14 ` Alex Williamson
2012-07-02 4:14 ` Alex Williamson
2012-06-28 6:44 ` [patch 1/3] vfio: signedness bug in vfio_config_do_rw() Dan Carpenter
2012-06-28 6:44 ` Dan Carpenter
2012-06-28 7:15 ` walter harms
2012-06-28 8:07 ` [patch 1/3 v2] " Dan Carpenter
2012-06-28 8:07 ` Dan Carpenter
2012-06-28 22:24 ` Alex Williamson
2012-06-28 22:24 ` Alex Williamson
2012-06-28 8:05 ` [patch 1/3] " Dan Carpenter
2012-06-28 6:44 ` [patch 2/3] vfio: make count unsigned to prevent integer underflow Dan Carpenter
2012-06-28 6:44 ` Dan Carpenter
2012-06-28 22:24 ` Alex Williamson
2012-06-28 22:24 ` Alex Williamson
2012-06-28 6:45 ` [patch 3/3] vfio: return -EFAULT on failure Dan Carpenter
2012-06-28 6:45 ` Dan Carpenter
2012-06-28 22:25 ` Alex Williamson
2012-06-28 22:25 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341202460.1207.384.camel@bling.home \
--to=alex.williamson@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chrisw@sous-sol.org \
--cc=dan.carpenter@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.