is the PRIORITY variable actually used anywhere?

is the PRIORITY variable actually used anywhere?

[Robert P. J. Day]

  noticed this in bitbake.conf:

PRIORITY = "optional"

but i've seen no actual usage of that variable anywhere.  is anyone or
anything actually making use of it?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is the PRIORITY variable actually used anywhere?

[Martin Jansa]

http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc

so can be dropped from bitbake.conf too AFAIK


On Sat, Jun 30, 2012 at 3:02 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>   noticed this in bitbake.conf:
>
> PRIORITY = "optional"
>
> but i've seen no actual usage of that variable anywhere.  is anyone or
> anything actually making use of it?
>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: is the PRIORITY variable actually used anywhere?

[Robert P. J. Day]

On Sat, 30 Jun 2012, Martin Jansa wrote:

> http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
> http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc
>
> so can be dropped from bitbake.conf too AFAIK
>
>
> On Sat, Jun 30, 2012 at 3:02 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> >   noticed this in bitbake.conf:
> >
> > PRIORITY = "optional"
> >
> > but i've seen no actual usage of that variable anywhere.  is anyone or
> > anything actually making use of it?

  ok, i'll just make a note of that as i'm currently cross-checking
variables and i'll likely run across more that can be cleaned (unless
someone has a burning desire to get rid of it sooner, which i'm
guessing is unlikely :-).

rday

p.s.  there are a couple typoes in bitbake.conf comments, so i'll
bundle them all into a single patch later with anything else i find.

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is the PRIORITY variable actually used anywhere?

[Robert P. J. Day]

On Sat, 30 Jun 2012, Martin Jansa wrote:

> http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
> http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc
>
> so can be dropped from bitbake.conf too AFAIK

  actually, there are still a number of lines that refer to that
variable:

$ grep -rw PRIORITY *
meta/conf/bitbake.conf:PRIORITY = "optional"
meta/conf/documentation.conf:PRIORITY[doc] = "Importance of package, default values are 'optional' or 'needed'."
meta/classes/package_deb.bbclass:        fields.append(["Priority: %s\n", ['PRIORITY']])
meta/classes/package_ipk.bbclass:		fields.append(["Priority: %s\n", ['PRIORITY']])
meta/classes/oelint.bbclass:	# Test for valid PRIORITY
meta/classes/oelint.bbclass:	s = testVar("PRIORITY")
meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended" % s)
meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended, better use '%s'" % (s, newprio))
meta/classes/oelint.bbclass:			bb.note("PRIORITY '%s' is not recommended" % s)
meta/classes/oelint.bbclass:			bb.error("PRIORITY should only use lower case")
$

  if i can assume that all of that can be removed, i can do that as a
single patch, again unless someone else wants to handle it if there
are subtleties involved.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is the PRIORITY variable actually used anywhere?

[Richard Purdie]

On Sat, 2012-06-30 at 06:20 -0400, Robert P. J. Day wrote:
> On Sat, 30 Jun 2012, Martin Jansa wrote:
> 
> > http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
> > http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc
> >
> > so can be dropped from bitbake.conf too AFAIK
> 
>   actually, there are still a number of lines that refer to that
> variable:
> 
> $ grep -rw PRIORITY *
> meta/conf/bitbake.conf:PRIORITY = "optional"
> meta/conf/documentation.conf:PRIORITY[doc] = "Importance of package, default values are 'optional' or 'needed'."
> meta/classes/package_deb.bbclass:        fields.append(["Priority: %s\n", ['PRIORITY']])
> meta/classes/package_ipk.bbclass:		fields.append(["Priority: %s\n", ['PRIORITY']])
> meta/classes/oelint.bbclass:	# Test for valid PRIORITY
> meta/classes/oelint.bbclass:	s = testVar("PRIORITY")
> meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended" % s)
> meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended, better use '%s'" % (s, newprio))
> meta/classes/oelint.bbclass:			bb.note("PRIORITY '%s' is not recommended" % s)
> meta/classes/oelint.bbclass:			bb.error("PRIORITY should only use lower case")
> $
> 
>   if i can assume that all of that can be removed, i can do that as a
> single patch, again unless someone else wants to handle it if there
> are subtleties involved.

I think this one is best left alone as the code stands. We did remove
the variable from standard usage, it doesn't obsolete the above code
which someone could in theory still use from say a distro configuration
perspective.

The line in documentation.conf look wrong though, I think "needed"
should be "required".

Cheers,

Richard

Re: is the PRIORITY variable actually used anywhere?

[Robert P. J. Day]

On Mon, 2 Jul 2012, Richard Purdie wrote:

> On Sat, 2012-06-30 at 06:20 -0400, Robert P. J. Day wrote:
> > On Sat, 30 Jun 2012, Martin Jansa wrote:
> >
> > > http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
> > > http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc
> > >
> > > so can be dropped from bitbake.conf too AFAIK
> >
> >   actually, there are still a number of lines that refer to that
> > variable:
> >
> > $ grep -rw PRIORITY *
> > meta/conf/bitbake.conf:PRIORITY = "optional"
> > meta/conf/documentation.conf:PRIORITY[doc] = "Importance of package, default values are 'optional' or 'needed'."
> > meta/classes/package_deb.bbclass:        fields.append(["Priority: %s\n", ['PRIORITY']])
> > meta/classes/package_ipk.bbclass:		fields.append(["Priority: %s\n", ['PRIORITY']])
> > meta/classes/oelint.bbclass:	# Test for valid PRIORITY
> > meta/classes/oelint.bbclass:	s = testVar("PRIORITY")
> > meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended" % s)
> > meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended, better use '%s'" % (s, newprio))
> > meta/classes/oelint.bbclass:			bb.note("PRIORITY '%s' is not recommended" % s)
> > meta/classes/oelint.bbclass:			bb.error("PRIORITY should only use lower case")
> > $
> >
> >   if i can assume that all of that can be removed, i can do that as a
> > single patch, again unless someone else wants to handle it if there
> > are subtleties involved.
>
> I think this one is best left alone as the code stands. We did remove
> the variable from standard usage, it doesn't obsolete the above code
> which someone could in theory still use from say a distro configuration
> perspective.
>
> The line in documentation.conf look wrong though, I think "needed"
> should be "required".

  oelint.bbclass currently suggests it can be any of "standard",
"required", "optional" or "extra".  and perhaps a dumb question -- how
are there *two* default values?  not sure what that means.

  anyway, i'll leave this in someone else's capable hands.  it's
pretty obvious that no use is being made of this variable these days.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is the PRIORITY variable actually used anywhere?

[Paul Eggleton]

On Monday 02 July 2012 07:29:08 Robert P. J. Day wrote:
>   oelint.bbclass currently suggests it can be any of "standard",
> "required", "optional" or "extra".  and perhaps a dumb question -- how
> are there *two* default values?  not sure what that means.

It's worth pointing out that oelint.bbclass is somewhat out-of-date with 
current practice, so I would take anything you find in it with a pinch of salt.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: is the PRIORITY variable actually used anywhere?

[Robert P. J. Day]

On Mon, 2 Jul 2012, Paul Eggleton wrote:

> On Monday 02 July 2012 07:29:08 Robert P. J. Day wrote:
> >   oelint.bbclass currently suggests it can be any of "standard",
> > "required", "optional" or "extra".  and perhaps a dumb question -- how
> > are there *two* default values?  not sure what that means.
>
> It's worth pointing out that oelint.bbclass is somewhat out-of-date
> with current practice, so I would take anything you find in it with
> a pinch of salt.

  i was just about to make that observation.  :-)

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is the PRIORITY variable actually used anywhere?

[Richard Purdie]

On Mon, 2012-07-02 at 07:29 -0400, Robert P. J. Day wrote:
> On Mon, 2 Jul 2012, Richard Purdie wrote:
> 
> > On Sat, 2012-06-30 at 06:20 -0400, Robert P. J. Day wrote:
> > > On Sat, 30 Jun 2012, Martin Jansa wrote:
> > >
> > > > http://git.openembedded.org/meta-openembedded/commit/?id=040f75eca217c79fed7b881589d9bb36358cffe1
> > > > http://git.openembedded.org/openembedded-core/commit/?id=d122343362669c683acc4af295971a62cbc823fc
> > > >
> > > > so can be dropped from bitbake.conf too AFAIK
> > >
> > >   actually, there are still a number of lines that refer to that
> > > variable:
> > >
> > > $ grep -rw PRIORITY *
> > > meta/conf/bitbake.conf:PRIORITY = "optional"
> > > meta/conf/documentation.conf:PRIORITY[doc] = "Importance of package, default values are 'optional' or 'needed'."
> > > meta/classes/package_deb.bbclass:        fields.append(["Priority: %s\n", ['PRIORITY']])
> > > meta/classes/package_ipk.bbclass:		fields.append(["Priority: %s\n", ['PRIORITY']])
> > > meta/classes/oelint.bbclass:	# Test for valid PRIORITY
> > > meta/classes/oelint.bbclass:	s = testVar("PRIORITY")
> > > meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended" % s)
> > > meta/classes/oelint.bbclass:				bb.note("PRIORITY '%s' is not recommended, better use '%s'" % (s, newprio))
> > > meta/classes/oelint.bbclass:			bb.note("PRIORITY '%s' is not recommended" % s)
> > > meta/classes/oelint.bbclass:			bb.error("PRIORITY should only use lower case")
> > > $
> > >
> > >   if i can assume that all of that can be removed, i can do that as a
> > > single patch, again unless someone else wants to handle it if there
> > > are subtleties involved.
> >
> > I think this one is best left alone as the code stands. We did remove
> > the variable from standard usage, it doesn't obsolete the above code
> > which someone could in theory still use from say a distro configuration
> > perspective.
> >
> > The line in documentation.conf look wrong though, I think "needed"
> > should be "required".
> 
>   oelint.bbclass currently suggests it can be any of "standard",
> "required", "optional" or "extra".  and perhaps a dumb question -- how
> are there *two* default values?  not sure what that means.

"optional" is the default, other possible values are "standard"
"required" and "extra".

>   anyway, i'll leave this in someone else's capable hands.  it's
> pretty obvious that no use is being made of this variable these days.

In the interests of resolving this, I've patched documentation.conf. If
anyone objects or wants to improve it further, please send the patch.

Cheers,

Richard