* [PATCH] gcc-common: Don't use "is" for comparing strings, use "=="
@ 2012-07-04 3:21 Kartik Mohta
2012-07-04 6:36 ` Khem Raj
2012-07-09 17:24 ` Saul Wold
0 siblings, 2 replies; 3+ messages in thread
From: Kartik Mohta @ 2012-07-04 3:21 UTC (permalink / raw)
To: openembedded-core
Needed because the equality check was failing here even though upon
printing the LHS and RHS were the same.
As per http://stackoverflow.com/a/2987975/64537, using "is" compares the
memory addresses of the two objects which is not what we want here. We
just want to compare the values.
Signed-off-by: Kartik Mohta <kartikmohta@gmail.com>
---
meta/recipes-devtools/gcc/gcc-common.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index 45828bb..0a9324a 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -10,7 +10,7 @@ inherit autotools gettext
FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
def get_gcc_fpu_setting(bb, d):
- if d.getVar('ARMPKGSFX_EABI', True) is "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
+ if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm":
return "--with-float=hard"
if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
return "--with-float=soft"
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gcc-common: Don't use "is" for comparing strings, use "=="
2012-07-04 3:21 [PATCH] gcc-common: Don't use "is" for comparing strings, use "==" Kartik Mohta
@ 2012-07-04 6:36 ` Khem Raj
2012-07-09 17:24 ` Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2012-07-04 6:36 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, Jul 3, 2012 at 8:21 PM, Kartik Mohta <kartikmohta@gmail.com> wrote:
> Needed because the equality check was failing here even though upon
> printing the LHS and RHS were the same.
> As per http://stackoverflow.com/a/2987975/64537, using "is" compares the
> memory addresses of the two objects which is not what we want here. We
> just want to compare the values.
indeed. This looks ok
>
> Signed-off-by: Kartik Mohta <kartikmohta@gmail.com>
> ---
> meta/recipes-devtools/gcc/gcc-common.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
> index 45828bb..0a9324a 100644
> --- a/meta/recipes-devtools/gcc/gcc-common.inc
> +++ b/meta/recipes-devtools/gcc/gcc-common.inc
> @@ -10,7 +10,7 @@ inherit autotools gettext
> FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
>
> def get_gcc_fpu_setting(bb, d):
> - if d.getVar('ARMPKGSFX_EABI', True) is "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
> + if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm":
> return "--with-float=hard"
> if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
> return "--with-float=soft"
> --
> 1.7.4.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gcc-common: Don't use "is" for comparing strings, use "=="
2012-07-04 3:21 [PATCH] gcc-common: Don't use "is" for comparing strings, use "==" Kartik Mohta
2012-07-04 6:36 ` Khem Raj
@ 2012-07-09 17:24 ` Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Saul Wold @ 2012-07-09 17:24 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Kartik Mohta
On 07/03/2012 08:21 PM, Kartik Mohta wrote:
> Needed because the equality check was failing here even though upon
> printing the LHS and RHS were the same.
> As per http://stackoverflow.com/a/2987975/64537, using "is" compares the
> memory addresses of the two objects which is not what we want here. We
> just want to compare the values.
>
> Signed-off-by: Kartik Mohta <kartikmohta@gmail.com>
> ---
> meta/recipes-devtools/gcc/gcc-common.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
> index 45828bb..0a9324a 100644
> --- a/meta/recipes-devtools/gcc/gcc-common.inc
> +++ b/meta/recipes-devtools/gcc/gcc-common.inc
> @@ -10,7 +10,7 @@ inherit autotools gettext
> FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
>
> def get_gcc_fpu_setting(bb, d):
> - if d.getVar('ARMPKGSFX_EABI', True) is "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
> + if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm":
> return "--with-float=hard"
> if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
> return "--with-float=soft"
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-09 17:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-04 3:21 [PATCH] gcc-common: Don't use "is" for comparing strings, use "==" Kartik Mohta
2012-07-04 6:36 ` Khem Raj
2012-07-09 17:24 ` Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.