[PATCH] ARM: mxs: Export missing symbols from mxs-dma.c

[PATCH] ARM: mxs: Export missing symbols from mxs-dma.c

[Attila Kinali]

mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
which are used at least in mxs-mmc.c. Building mxs-mmc as module
fails due to those two symbols not being exported.

Signed-off-by: Attila Kinali <attila@kinali.ch>
---
 drivers/dma/mxs-dma.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index c96ab15..4ea1909 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -779,3 +779,6 @@ static int __init mxs_dma_module_init(void)
 	return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
 }
 subsys_initcall(mxs_dma_module_init);
+
+EXPORT_SYMBOL(mxs_dma_is_apbh);
+EXPORT_SYMBOL(mxs_dma_is_apbx);
-- 
1.7.10

[PATCH] ARM: mxs: Export missing symbols from mxs-dma.c

[Dong Aisheng]

On Fri, Jul 06, 2012 at 11:02:46AM +0200, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
>  drivers/dma/mxs-dma.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index c96ab15..4ea1909 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -779,3 +779,6 @@ static int __init mxs_dma_module_init(void)
>  	return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
>  }
>  subsys_initcall(mxs_dma_module_init);
> +
> +EXPORT_SYMBOL(mxs_dma_is_apbh);
> +EXPORT_SYMBOL(mxs_dma_is_apbx);
If i understand correctly, usually we add EXPORT_SYMBOL right below the function
exported.
And can we use EXPORT_SYMBOL_GPL?
It seems both driver using this are gpl licensed.

BTW, maybe you also need change the patch title format a bit:
dma: mxs-dma: ...

Regards
Dong Aisheng

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Attila Kinali]

mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
which are used at least in mxs-mmc.c. Building mxs-mmc as module
fails due to those two symbols not being exported.

Signed-off-by: Attila Kinali <attila@kinali.ch>
---
 drivers/dma/mxs-dma.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index c96ab15..0437f49 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
 
 	return dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL(mxs_dma_is_apbh);
 
 int mxs_dma_is_apbx(struct dma_chan *chan)
 {
@@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
 
 	return !dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL(mxs_dma_is_apbx);
 
 static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
 {
@@ -779,3 +781,4 @@ static int __init mxs_dma_module_init(void)
 	return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
 }
 subsys_initcall(mxs_dma_module_init);
+
-- 
1.7.10

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Dong Aisheng]

On Fri, Jul 06, 2012 at 07:09:52PM +0800, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
>  drivers/dma/mxs-dma.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index c96ab15..0437f49 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
>  
>  	return dma_is_apbh(mxs_dma);
>  }
> +EXPORT_SYMBOL(mxs_dma_is_apbh);

>  
>  int mxs_dma_is_apbx(struct dma_chan *chan)
>  {
> @@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
>  
>  	return !dma_is_apbh(mxs_dma);
>  }
> +EXPORT_SYMBOL(mxs_dma_is_apbx);
>  
Shawn,

Do we need this be EXPORT_SYMBOL_GPL?

>  static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
>  {
> @@ -779,3 +781,4 @@ static int __init mxs_dma_module_init(void)
>  	return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
>  }
>  subsys_initcall(mxs_dma_module_init);
> +
This line change is unneeded.

else i'm ok with the patch:
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>

Regards
Dong Aisheng

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Dong Aisheng]

On Fri, Jul 06, 2012 at 07:22:46PM +0800, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
>  drivers/dma/mxs-dma.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>

Regards
Dong Aisheng

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Attila Kinali]

On Fri, 6 Jul 2012 19:10:21 +0800
Dong Aisheng <b29396@freescale.com> wrote:

> Do we need this be EXPORT_SYMBOL_GPL?

Blub.. sorry.. forgot to change them to GPL... gimme a second.

			Attila Kinali

-- 
The trouble with you, Shev, is you don't say anything until you've saved
up a whole truckload of damned heavy brick arguments and then you dump
them all out and never look at the bleeding body mangled beneath the heap
		-- Tirin, The Dispossessed, U. Le Guin

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Attila Kinali]

mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
which are used at least in mxs-mmc.c. Building mxs-mmc as module
fails due to those two symbols not being exported.

Signed-off-by: Attila Kinali <attila@kinali.ch>
---
 drivers/dma/mxs-dma.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index c96ab15..96d8b80 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
 
 	return dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL_GPL(mxs_dma_is_apbh);
 
 int mxs_dma_is_apbx(struct dma_chan *chan)
 {
@@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
 
 	return !dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL_GPL(mxs_dma_is_apbx);
 
 static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
 {
-- 
1.7.10

[PATCH] ARM: dma: mxs-dma: Export missing symbols from mxs-dma.c

[Shawn Guo]

Only the patch touching files under arch/arm/ should have "ARM:" in
the patch subject.  So you need to drop it from there.

-- 
Regards,
Shawn

On Fri, Jul 06, 2012 at 01:22:46PM +0200, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>
> ---
>  drivers/dma/mxs-dma.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index c96ab15..96d8b80 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
>  
>  	return dma_is_apbh(mxs_dma);
>  }
> +EXPORT_SYMBOL_GPL(mxs_dma_is_apbh);
>  
>  int mxs_dma_is_apbx(struct dma_chan *chan)
>  {
> @@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
>  
>  	return !dma_is_apbh(mxs_dma);
>  }
> +EXPORT_SYMBOL_GPL(mxs_dma_is_apbx);
>  
>  static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
>  {
> -- 
> 1.7.10
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] dma: mxs-dma: Export missing symbols from mxs-dma.c

[Attila Kinali]

mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
which are used at least in mxs-mmc.c. Building mxs-mmc as module
fails due to those two symbols not being exported.

Signed-off-by: Attila Kinali <attila@kinali.ch>
---
 drivers/dma/mxs-dma.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index c96ab15..96d8b80 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -201,6 +201,7 @@ int mxs_dma_is_apbh(struct dma_chan *chan)
 
 	return dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL_GPL(mxs_dma_is_apbh);
 
 int mxs_dma_is_apbx(struct dma_chan *chan)
 {
@@ -209,6 +210,7 @@ int mxs_dma_is_apbx(struct dma_chan *chan)
 
 	return !dma_is_apbh(mxs_dma);
 }
+EXPORT_SYMBOL_GPL(mxs_dma_is_apbx);
 
 static void mxs_dma_reset_chan(struct mxs_dma_chan *mxs_chan)
 {
-- 
1.7.10

[PATCH] dma: mxs-dma: Export missing symbols from mxs-dma.c

[Shawn Guo]

On Fri, Jul 06, 2012 at 02:53:20PM +0200, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
> 
> Signed-off-by: Attila Kinali <attila@kinali.ch>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

[PATCH] dma: mxs-dma: Export missing symbols from mxs-dma.c

[Vinod Koul]

On Fri, 2012-07-06 at 14:53 +0200, Attila Kinali wrote:
> mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> which are used at least in mxs-mmc.c. Building mxs-mmc as module
> fails due to those two symbols not being exported.
Applied thanks.

Please DO NOT forget to CC maintainers, the patch can get lost
otherwise. get_maintainer.pl is your friend, use it!

-- 
~Vinod

[PATCH] dma: mxs-dma: Export missing symbols from mxs-dma.c

[Attila Kinali]

On Mon, 16 Jul 2012 12:00:46 +0530
Vinod Koul <vinod.koul@linux.intel.com> wrote:

> On Fri, 2012-07-06 at 14:53 +0200, Attila Kinali wrote:
> > mxs-dma.c provides two functions mxs_dma_is_apbh and mxs_dma_is_apbx
> > which are used at least in mxs-mmc.c. Building mxs-mmc as module
> > fails due to those two symbols not being exported.
> Applied thanks.

Thanks a lot!

> Please DO NOT forget to CC maintainers, the patch can get lost
> otherwise. get_maintainer.pl is your friend, use it!

Oki, i'll keep that in mind.

			Attila Kinali

-- 
The trouble with you, Shev, is you don't say anything until you've saved
up a whole truckload of damned heavy brick arguments and then you dump
them all out and never look at the bleeding body mangled beneath the heap
		-- Tirin, The Dispossessed, U. Le Guin