All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook
@ 2012-06-20 10:53 Laurent Pinchart
  2012-06-21  5:38 ` Kuninori Morimoto
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Laurent Pinchart @ 2012-06-20 10:53 UTC (permalink / raw)
  To: linux-sh

Since commit 21cc1b7ede3cf456cf1d51f8a906093261f7c111 ("ARM: shmobile:
use machine specific hook for late init") suspend and CPU idle are not
initialized automatically anymore. Set shmobile_init_late() as the
machine late init hook to initialize them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index c0ad535..a70993f 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -990,6 +990,7 @@ DT_MACHINE_START(ARMADILLO800EVA_DT, "armadillo800eva")
 	.init_irq	= r8a7740_init_irq,
 	.handle_irq	= shmobile_handle_irq_intc,
 	.init_machine	= eva_init,
+	.init_late	= shmobile_init_late,
 	.timer		= &shmobile_timer,
 	.dt_compat	= eva_boards_compat_dt,
 MACHINE_END
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
@ 2012-06-21  5:38 ` Kuninori Morimoto
  2012-06-21 10:22 ` Rafael J. Wysocki
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Kuninori Morimoto @ 2012-06-21  5:38 UTC (permalink / raw)
  To: linux-sh


Hi Rafael, Magnus

> Since commit 21cc1b7ede3cf456cf1d51f8a906093261f7c111 ("ARM: shmobile:
> use machine specific hook for late init") suspend and CPU idle are not
> initialized automatically anymore. Set shmobile_init_late() as the
> machine late init hook to initialize them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index c0ad535..a70993f 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -990,6 +990,7 @@ DT_MACHINE_START(ARMADILLO800EVA_DT, "armadillo800eva")
>  	.init_irq	= r8a7740_init_irq,
>  	.handle_irq	= shmobile_handle_irq_intc,
>  	.init_machine	= eva_init,
> +	.init_late	= shmobile_init_late,
>  	.timer		= &shmobile_timer,
>  	.dt_compat	= eva_boards_compat_dt,
>  MACHINE_END
> -- 

Not only armadillo800eva, but also kzm9g/kzm9d (= new board) are missing it.

Kuninori Morimoto (2):
      ARM: shmobile: kzm9g: use late init machine hook
      ARM: shmobile: kzm9d: use late init machine hook

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
  2012-06-21  5:38 ` Kuninori Morimoto
@ 2012-06-21 10:22 ` Rafael J. Wysocki
  2012-07-06 11:08 ` [PATCH] ARM: mach-shmobile: armadillo800eva: defconfig Allow use of armhf userspace Simon Horman
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Rafael J. Wysocki @ 2012-06-21 10:22 UTC (permalink / raw)
  To: linux-sh

On Wednesday, June 20, 2012, Laurent Pinchart wrote:
> Since commit 21cc1b7ede3cf456cf1d51f8a906093261f7c111 ("ARM: shmobile:
> use machine specific hook for late init") suspend and CPU idle are not
> initialized automatically anymore. Set shmobile_init_late() as the
> machine late init hook to initialize them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied to the fixes branch of the renesas.git tree.

Thanks,
Rafael


> ---
>  arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index c0ad535..a70993f 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -990,6 +990,7 @@ DT_MACHINE_START(ARMADILLO800EVA_DT, "armadillo800eva")
>  	.init_irq	= r8a7740_init_irq,
>  	.handle_irq	= shmobile_handle_irq_intc,
>  	.init_machine	= eva_init,
> +	.init_late	= shmobile_init_late,
>  	.timer		= &shmobile_timer,
>  	.dt_compat	= eva_boards_compat_dt,
>  MACHINE_END
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: defconfig Allow use of armhf userspace
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
  2012-06-21  5:38 ` Kuninori Morimoto
  2012-06-21 10:22 ` Rafael J. Wysocki
@ 2012-07-06 11:08 ` Simon Horman
  2012-07-08 22:24 ` Rafael J. Wysocki
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2012-07-06 11:08 UTC (permalink / raw)
  To: linux-sh

This allows use a Debian armhf usespace
as well as the existing ability to use a Debian armel userspace.

Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 arch/arm/configs/armadillo800eva_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
index 16bbb3f..7d87184 100644
--- a/arch/arm/configs/armadillo800eva_defconfig
+++ b/arch/arm/configs/armadillo800eva_defconfig
@@ -18,7 +18,7 @@ CONFIG_ARCH_SHMOBILE=y
 CONFIG_ARCH_R8A7740=y
 CONFIG_MACH_ARMADILLO800EVA=y
 # CONFIG_SH_TIMER_TMU is not set
-# CONFIG_ARM_THUMB is not set
+CONFIG_ARM_THUMB=y
 CONFIG_CPU_BPREDICT_DISABLE=y
 # CONFIG_CACHE_L2X0 is not set
 CONFIG_ARM_ERRATA_430973=y
@@ -36,6 +36,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_CMDLINE="console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize@96,wsize@96"
 CONFIG_CMDLINE_FORCE=y
 CONFIG_KEXEC=y
+CONFIG_VFP=y
 # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
 # CONFIG_SUSPEND is not set
 CONFIG_NET=y
-- 
1.7.10.2.484.gcd07cc5


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: defconfig Allow use of armhf userspace
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
                   ` (2 preceding siblings ...)
  2012-07-06 11:08 ` [PATCH] ARM: mach-shmobile: armadillo800eva: defconfig Allow use of armhf userspace Simon Horman
@ 2012-07-08 22:24 ` Rafael J. Wysocki
  2013-02-13 12:15   ` Simon Horman
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Rafael J. Wysocki @ 2012-07-08 22:24 UTC (permalink / raw)
  To: linux-sh

On Friday, July 06, 2012, Simon Horman wrote:
> This allows use a Debian armhf usespace
> as well as the existing ability to use a Debian armel userspace.
> 
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>

Applied to the armadillo branch of the renesas.git tree.

Thanks,
Rafael


> ---
>  arch/arm/configs/armadillo800eva_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
> index 16bbb3f..7d87184 100644
> --- a/arch/arm/configs/armadillo800eva_defconfig
> +++ b/arch/arm/configs/armadillo800eva_defconfig
> @@ -18,7 +18,7 @@ CONFIG_ARCH_SHMOBILE=y
>  CONFIG_ARCH_R8A7740=y
>  CONFIG_MACH_ARMADILLO800EVA=y
>  # CONFIG_SH_TIMER_TMU is not set
> -# CONFIG_ARM_THUMB is not set
> +CONFIG_ARM_THUMB=y
>  CONFIG_CPU_BPREDICT_DISABLE=y
>  # CONFIG_CACHE_L2X0 is not set
>  CONFIG_ARM_ERRATA_430973=y
> @@ -36,6 +36,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0
>  CONFIG_CMDLINE="console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize@96,wsize@96"
>  CONFIG_CMDLINE_FORCE=y
>  CONFIG_KEXEC=y
> +CONFIG_VFP=y
>  # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
>  # CONFIG_SUSPEND is not set
>  CONFIG_NET=y
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
@ 2013-02-13 12:15   ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2013-02-13 12:15 UTC (permalink / raw)
  To: linux-arm-kernel

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with
"ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/armadillo800eva_defconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
index 0b98100..6ceb79f 100644
--- a/arch/arm/configs/armadillo800eva_defconfig
+++ b/arch/arm/configs/armadillo800eva_defconfig
@@ -88,6 +88,8 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_DUMMY=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
@ 2013-02-13 12:15   ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2013-02-13 12:15 UTC (permalink / raw)
  To: linux-arm-kernel

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with
"ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/armadillo800eva_defconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
index 0b98100..6ceb79f 100644
--- a/arch/arm/configs/armadillo800eva_defconfig
+++ b/arch/arm/configs/armadillo800eva_defconfig
@@ -88,6 +88,8 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_DUMMY=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
  2013-02-13 12:15   ` Simon Horman
@ 2013-02-13 12:26     ` Guennadi Liakhovetski
  -1 siblings, 0 replies; 15+ messages in thread
From: Guennadi Liakhovetski @ 2013-02-13 12:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon

On Wed, 13 Feb 2013, Simon Horman wrote:

> As well as being a generally sane thing to do this
> is required for MMCIF to function in conjunction with
> "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".
> 
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/configs/armadillo800eva_defconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
> index 0b98100..6ceb79f 100644
> --- a/arch/arm/configs/armadillo800eva_defconfig
> +++ b/arch/arm/configs/armadillo800eva_defconfig
> @@ -88,6 +88,8 @@ CONFIG_I2C=y
>  CONFIG_I2C_GPIO=y
>  CONFIG_I2C_SH_MOBILE=y
>  # CONFIG_HWMON is not set
> +CONFIG_REGULATOR=y
> +CONFIG_REGULATOR_DUMMY=y

I don't think it's a good idea to enable the dummy regulator by default in 
defconfig. It has been explained to me, that that regulator is only meant 
for development / testing. For production you really should have the 
_correct_ regulators in place. So, encouraging it by default is probably 
not a very good idea.

Thanks
Guennadi

>  CONFIG_MEDIA_SUPPORT=y
>  CONFIG_VIDEO_DEV=y
>  CONFIG_MEDIA_CAMERA_SUPPORT=y
> -- 
> 1.7.10.4
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
@ 2013-02-13 12:26     ` Guennadi Liakhovetski
  0 siblings, 0 replies; 15+ messages in thread
From: Guennadi Liakhovetski @ 2013-02-13 12:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon

On Wed, 13 Feb 2013, Simon Horman wrote:

> As well as being a generally sane thing to do this
> is required for MMCIF to function in conjunction with
> "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".
> 
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/configs/armadillo800eva_defconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
> index 0b98100..6ceb79f 100644
> --- a/arch/arm/configs/armadillo800eva_defconfig
> +++ b/arch/arm/configs/armadillo800eva_defconfig
> @@ -88,6 +88,8 @@ CONFIG_I2C=y
>  CONFIG_I2C_GPIO=y
>  CONFIG_I2C_SH_MOBILE=y
>  # CONFIG_HWMON is not set
> +CONFIG_REGULATOR=y
> +CONFIG_REGULATOR_DUMMY=y

I don't think it's a good idea to enable the dummy regulator by default in 
defconfig. It has been explained to me, that that regulator is only meant 
for development / testing. For production you really should have the 
_correct_ regulators in place. So, encouraging it by default is probably 
not a very good idea.

Thanks
Guennadi

>  CONFIG_MEDIA_SUPPORT=y
>  CONFIG_VIDEO_DEV=y
>  CONFIG_MEDIA_CAMERA_SUPPORT=y
> -- 
> 1.7.10.4
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
  2013-02-13 12:26     ` Guennadi Liakhovetski
@ 2013-02-13 13:12       ` Simon Horman
  -1 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2013-02-13 13:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 13, 2013 at 01:26:55PM +0100, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 13 Feb 2013, Simon Horman wrote:
> 
> > As well as being a generally sane thing to do this
> > is required for MMCIF to function in conjunction with
> > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".
> > 
> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/configs/armadillo800eva_defconfig |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
> > index 0b98100..6ceb79f 100644
> > --- a/arch/arm/configs/armadillo800eva_defconfig
> > +++ b/arch/arm/configs/armadillo800eva_defconfig
> > @@ -88,6 +88,8 @@ CONFIG_I2C=y
> >  CONFIG_I2C_GPIO=y
> >  CONFIG_I2C_SH_MOBILE=y
> >  # CONFIG_HWMON is not set
> > +CONFIG_REGULATOR=y
> > +CONFIG_REGULATOR_DUMMY=y
> 
> I don't think it's a good idea to enable the dummy regulator by default in 
> defconfig. It has been explained to me, that that regulator is only meant 
> for development / testing. For production you really should have the 
> _correct_ regulators in place. So, encouraging it by default is probably 
> not a very good idea.

Thanks, I will fix up this and the other defconfigs accordingly.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig
@ 2013-02-13 13:12       ` Simon Horman
  0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2013-02-13 13:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 13, 2013 at 01:26:55PM +0100, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 13 Feb 2013, Simon Horman wrote:
> 
> > As well as being a generally sane thing to do this
> > is required for MMCIF to function in conjunction with
> > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".
> > 
> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/configs/armadillo800eva_defconfig |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig
> > index 0b98100..6ceb79f 100644
> > --- a/arch/arm/configs/armadillo800eva_defconfig
> > +++ b/arch/arm/configs/armadillo800eva_defconfig
> > @@ -88,6 +88,8 @@ CONFIG_I2C=y
> >  CONFIG_I2C_GPIO=y
> >  CONFIG_I2C_SH_MOBILE=y
> >  # CONFIG_HWMON is not set
> > +CONFIG_REGULATOR=y
> > +CONFIG_REGULATOR_DUMMY=y
> 
> I don't think it's a good idea to enable the dummy regulator by default in 
> defconfig. It has been explained to me, that that regulator is only meant 
> for development / testing. For production you really should have the 
> _correct_ regulators in place. So, encouraging it by default is probably 
> not a very good idea.

Thanks, I will fix up this and the other defconfigs accordingly.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
                   ` (4 preceding siblings ...)
  2013-02-13 12:15   ` Simon Horman
@ 2013-10-04  5:39 ` Nguyen Hong Ky
  2013-10-04  5:39 ` Nguyen Hong Ky
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Nguyen Hong Ky @ 2013-10-04  5:39 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

This patch will fix RX packets errors when receiving big size of data.
It was created on the top of mainline kernel v3.11.

Nguyen Hong Ky (1):
  ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth

 drivers/net/ethernet/renesas/sh_eth.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
                   ` (5 preceding siblings ...)
  2013-10-04  5:39 ` [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth Nguyen Hong Ky
@ 2013-10-04  5:39 ` Nguyen Hong Ky
  2013-10-04 19:39 ` Sergei Shtylyov
  2013-10-07  5:11 ` Nguyen Hong Ky
  8 siblings, 0 replies; 15+ messages in thread
From: Nguyen Hong Ky @ 2013-10-04  5:39 UTC (permalink / raw)
  To: linux-sh

This patch will fix RX packets errors when receiving big size
of data by set bit RNC = 1.

RNC - Receive Enable Control

0: Upon completion of reception of one frame, the E-DMAC writes
the receive status to the descriptor and clears the RR bit in
EDRRR to 0.

1: Upon completion of reception of one frame, the E-DMAC writes
(writes back) the receive status to the descriptor. In addition,
the E-DMAC reads the next descriptor and prepares for reception
of the next frame.

Signed-off-by: Nguyen Hong Ky <nh-ky@jinso.co.jp>
---
 drivers/net/ethernet/renesas/sh_eth.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index a753928..11d34f0 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = {
 	.eesr_err_check	= EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
 			  EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
 			  EESR_TDE | EESR_ECI,
+	.fdr_value	= 0x0000070f,
+	.rmcr_value	= 0x00000001,
 
 	.apr		= 1,
 	.mpr		= 1,
 	.tpauser	= 1,
 	.bculr		= 1,
 	.hw_swap	= 1,
+	.rpadir		= 1,
+	.rpadir_value   = 2 << 16,
 	.no_trimd	= 1,
 	.no_ade		= 1,
 	.tsu		= 1,
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
                   ` (6 preceding siblings ...)
  2013-10-04  5:39 ` Nguyen Hong Ky
@ 2013-10-04 19:39 ` Sergei Shtylyov
  2013-10-07  5:11 ` Nguyen Hong Ky
  8 siblings, 0 replies; 15+ messages in thread
From: Sergei Shtylyov @ 2013-10-04 19:39 UTC (permalink / raw)
  To: linux-sh

Hello.

On 04-10-2013 7:39, Nguyen Hong Ky wrote:

    The patch is wrongly named (since it's the network driver patch, not ARM 
patch) and wrongly addressed: you should have sent it to 
netdev@vger.kernel.org where David Miller could apply it.

> This patch will fix RX packets errors when receiving big size
> of data by set bit RNC = 1.

> RNC - Receive Enable Control

> 0: Upon completion of reception of one frame, the E-DMAC writes
> the receive status to the descriptor and clears the RR bit in
> EDRRR to 0.

    As far as I know, it's the setting most of the other SoC Ethers use.

> 1: Upon completion of reception of one frame, the E-DMAC writes
> (writes back) the receive status to the descriptor. In addition,
> the E-DMAC reads the next descriptor and prepares for reception
> of the next frame.

> Signed-off-by: Nguyen Hong Ky <nh-ky@jinso.co.jp>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index a753928..11d34f0 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = {
>   	.eesr_err_check	= EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
>   			  EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
>   			  EESR_TDE | EESR_ECI,
> +	.fdr_value	= 0x0000070f,
> +	.rmcr_value	= 0x00000001,
>
>   	.apr		= 1,
>   	.mpr		= 1,
>   	.tpauser	= 1,
>   	.bculr		= 1,
>   	.hw_swap	= 1,
> +	.rpadir		= 1,
> +	.rpadir_value   = 2 << 16,

   Your patch seems to change much more than is described in the changelog...

WBR, Sergei


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth
  2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
                   ` (7 preceding siblings ...)
  2013-10-04 19:39 ` Sergei Shtylyov
@ 2013-10-07  5:11 ` Nguyen Hong Ky
  8 siblings, 0 replies; 15+ messages in thread
From: Nguyen Hong Ky @ 2013-10-07  5:11 UTC (permalink / raw)
  To: linux-sh

On Sat, Oct 5, 2013 at 5:39 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 04-10-2013 7:39, Nguyen Hong Ky wrote:
>
>    The patch is wrongly named (since it's the network driver patch, not ARM
> patch) and wrongly addressed: you should have sent it to
> netdev@vger.kernel.org where David Miller could apply it.

Thanks for your help. I will change patch's name and send it to
netdev@vger.kernel.org


>> This patch will fix RX packets errors when receiving big size
>> of data by set bit RNC = 1.
>
>
>> RNC - Receive Enable Control
>
>
>> 0: Upon completion of reception of one frame, the E-DMAC writes
>> the receive status to the descriptor and clears the RR bit in
>> EDRRR to 0.
>
>
>    As far as I know, it's the setting most of the other SoC Ethers use.

You're right.


>> 1: Upon completion of reception of one frame, the E-DMAC writes
>> (writes back) the receive status to the descriptor. In addition,
>> the E-DMAC reads the next descriptor and prepares for reception
>> of the next frame.
>
>
>> Signed-off-by: Nguyen Hong Ky <nh-ky@jinso.co.jp>
>> ---
>>   drivers/net/ethernet/renesas/sh_eth.c |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index a753928..11d34f0 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = {
>>         .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
>>                           EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
>>                           EESR_TDE | EESR_ECI,
>> +       .fdr_value      = 0x0000070f,
>> +       .rmcr_value     = 0x00000001,
>>
>>         .apr            = 1,
>>         .mpr            = 1,
>>         .tpauser        = 1,
>>         .bculr          = 1,
>>         .hw_swap        = 1,
>> +       .rpadir         = 1,
>> +       .rpadir_value   = 2 << 16,
>
>
>   Your patch seems to change much more than is described in the changelog...

For get more stable when receiving packets, I set max size for the
transmit/receive FIFO
and inserts padding in receive data.
I will add more infos in the changelog.

Thanks,
Nguyen Hong Ky

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2013-10-07  5:11 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20 10:53 [PATCH] ARM: mach-shmobile: armadillo800eva: Use late init machine hook Laurent Pinchart
2012-06-21  5:38 ` Kuninori Morimoto
2012-06-21 10:22 ` Rafael J. Wysocki
2012-07-06 11:08 ` [PATCH] ARM: mach-shmobile: armadillo800eva: defconfig Allow use of armhf userspace Simon Horman
2012-07-08 22:24 ` Rafael J. Wysocki
2013-02-13 12:15 ` [PATCH] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig Simon Horman
2013-02-13 12:15   ` Simon Horman
2013-02-13 12:26   ` Guennadi Liakhovetski
2013-02-13 12:26     ` Guennadi Liakhovetski
2013-02-13 13:12     ` Simon Horman
2013-02-13 13:12       ` Simon Horman
2013-10-04  5:39 ` [PATCH] ARM: mach-shmobile: armadillo800eva: Fix RX packets errors on sh_eth Nguyen Hong Ky
2013-10-04  5:39 ` Nguyen Hong Ky
2013-10-04 19:39 ` Sergei Shtylyov
2013-10-07  5:11 ` Nguyen Hong Ky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.