[PATCH] ehci: Kick async schedule on wakeup in the non companion case

[PATCH] ehci: Kick async schedule on wakeup in the non companion case

[Hans de Goede]

Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code
to ehci_wakeup to kick the async schedule on wakeup, but the else
was positioned wrong making it trigger for devices which are routed
to the companion rather then to the ehci controller itself.

This patch fixes this. Note that the "programming style" with using the
return at the end of the companion block matches how the companion case
is handled in the other ports ops, and is done this way for consistency.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/hcd-ehci.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 401ccec..b68a8ce 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -852,10 +852,11 @@ static void ehci_wakeup(USBPort *port)
         USBPort *companion = s->companion_ports[port->index];
         if (companion->ops->wakeup) {
             companion->ops->wakeup(companion);
-        } else {
-            qemu_bh_schedule(s->async_bh);
         }
+        return;
     }
+
+    qemu_bh_schedule(s->async_bh);
 }
 
 static int ehci_register_companion(USBBus *bus, USBPort *ports[],
-- 
1.7.10.4

[Qemu-devel] [PATCH] ehci: Kick async schedule on wakeup in the non companion case

[Hans de Goede]

Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code
to ehci_wakeup to kick the async schedule on wakeup, but the else
was positioned wrong making it trigger for devices which are routed
to the companion rather then to the ehci controller itself.

This patch fixes this. Note that the "programming style" with using the
return at the end of the companion block matches how the companion case
is handled in the other ports ops, and is done this way for consistency.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/hcd-ehci.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 401ccec..b68a8ce 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -852,10 +852,11 @@ static void ehci_wakeup(USBPort *port)
         USBPort *companion = s->companion_ports[port->index];
         if (companion->ops->wakeup) {
             companion->ops->wakeup(companion);
-        } else {
-            qemu_bh_schedule(s->async_bh);
         }
+        return;
     }
+
+    qemu_bh_schedule(s->async_bh);
 }
 
 static int ehci_register_companion(USBBus *bus, USBPort *ports[],
-- 
1.7.10.4

Re: [PATCH] ehci: Kick async schedule on wakeup in the non companion case

[Gerd Hoffmann]

On 07/06/12 16:53, Hans de Goede wrote:
> Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code
> to ehci_wakeup to kick the async schedule on wakeup, but the else
> was positioned wrong making it trigger for devices which are routed
> to the companion rather then to the ehci controller itself.
> 
> This patch fixes this. Note that the "programming style" with using the
> return at the end of the companion block matches how the companion case
> is handled in the other ports ops, and is done this way for consistency.

Added to usb patch queue.

thanks,
  Gerd

Re: [Qemu-devel] [PATCH] ehci: Kick async schedule on wakeup in the non companion case

[Gerd Hoffmann]

On 07/06/12 16:53, Hans de Goede wrote:
> Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code
> to ehci_wakeup to kick the async schedule on wakeup, but the else
> was positioned wrong making it trigger for devices which are routed
> to the companion rather then to the ehci controller itself.
> 
> This patch fixes this. Note that the "programming style" with using the
> return at the end of the companion block matches how the companion case
> is handled in the other ports ops, and is done this way for consistency.

Added to usb patch queue.

thanks,
  Gerd

Issue with mouse-capture

[Veruca Salt]

I realise you guys are very busy, but I'm about to go into the Qemu-kvm code seriously for the first time; I have to try and fix an irritating little issue whereby on all settings(including maximised and no frame) our Virtual Machine requires a manual click to capture the mouse.
We're using 32 bit XP and 64 bit Windows 7 on a 64 bit linux host.

Before I start making an unholy mess of your code, can anybody point me in the direction of the most likely areas to check?
I want to do this using 1.0; we aren't planning to move to 1.1 just yet, as the USB changes would require extra integration and device-level changes/installations to our VM's.

Look forward to hearing from you.

Simon O'Riordan
 		 	   		  

RE: Issue with mouse-capture

[Veruca Salt]

DMY guys.
I've sorted it.
We're happy now.

----------------------------------------
> From: verucasaltuk@hotmail.co.uk
> To: kvm@vger.kernel.org
> Subject: Issue with mouse-capture
> Date: Mon, 9 Jul 2012 08:16:10 +0000
>
>
>
> I realise you guys are very busy, but I'm about to go into the Qemu-kvm code seriously for the first time; I have to try and fix an irritating little issue whereby on all settings(including maximised and no frame) our Virtual Machine requires a manual click to capture the mouse.
> We're using 32 bit XP and 64 bit Windows 7 on a 64 bit linux host.
>
> Before I start making an unholy mess of your code, can anybody point me in the direction of the most likely areas to check?
> I want to do this using 1.0; we aren't planning to move to 1.1 just yet, as the USB changes would require extra integration and device-level changes/installations to our VM's.
>
> Look forward to hearing from you.
>
> Simon O'Riordan
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html