From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] pseries: Add support for new KVM hash table control call
Date: Tue, 10 Jul 2012 17:25:38 +1000 [thread overview]
Message-ID: <1341905138.2561.12.camel@pasglop> (raw)
In-Reply-To: <1340799048.3732.55.camel@pasglop>
On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
>
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
>
> This also paves the way for indicating a different size hash table
> to the kernel and for the kernel to be able to impose limits on
> the requested size.
Alex, this has a bug, if you already applied it, please sneak:
> +int kvmppc_reset_htab(int shift_hint)
> +{
> + uint32_t shift = shift_hint;
> +
> + if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) {
The above shall be if (kvm_enabled() && ....
Else it will segfault in kvm_check_extension
Or let me know if I should re-submit.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call
Date: Tue, 10 Jul 2012 17:25:38 +1000 [thread overview]
Message-ID: <1341905138.2561.12.camel@pasglop> (raw)
In-Reply-To: <1340799048.3732.55.camel@pasglop>
On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
>
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
>
> This also paves the way for indicating a different size hash table
> to the kernel and for the kernel to be able to impose limits on
> the requested size.
Alex, this has a bug, if you already applied it, please sneak:
> +int kvmppc_reset_htab(int shift_hint)
> +{
> + uint32_t shift = shift_hint;
> +
> + if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) {
The above shall be if (kvm_enabled() && ....
Else it will segfault in kvm_check_extension
Or let me know if I should re-submit.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] pseries: Add support for new KVM hash table control call
Date: Tue, 10 Jul 2012 07:25:38 +0000 [thread overview]
Message-ID: <1341905138.2561.12.camel@pasglop> (raw)
In-Reply-To: <1340799048.3732.55.camel@pasglop>
On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
>
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
>
> This also paves the way for indicating a different size hash table
> to the kernel and for the kernel to be able to impose limits on
> the requested size.
Alex, this has a bug, if you already applied it, please sneak:
> +int kvmppc_reset_htab(int shift_hint)
> +{
> + uint32_t shift = shift_hint;
> +
> + if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) {
The above shall be if (kvm_enabled() && ....
Else it will segfault in kvm_check_extension
Or let me know if I should re-submit.
Cheers,
Ben.
next prev parent reply other threads:[~2012-07-10 7:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 12:10 [PATCH] pseries: Add support for new KVM hash table control call Benjamin Herrenschmidt
2012-06-27 12:10 ` Benjamin Herrenschmidt
2012-06-27 12:12 ` Benjamin Herrenschmidt
2012-06-27 12:12 ` Benjamin Herrenschmidt
2012-06-27 12:30 ` Alexander Graf
2012-06-27 12:30 ` Alexander Graf
2012-06-27 21:30 ` Benjamin Herrenschmidt
2012-06-27 21:30 ` Benjamin Herrenschmidt
2012-06-27 21:33 ` Alexander Graf
2012-06-27 21:33 ` Alexander Graf
2012-07-10 7:25 ` Benjamin Herrenschmidt [this message]
2012-07-10 7:25 ` Benjamin Herrenschmidt
2012-07-10 7:25 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-07-10 8:16 ` Benjamin Herrenschmidt
2012-07-10 8:16 ` Benjamin Herrenschmidt
2012-07-10 8:16 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-07-10 10:34 ` Alexander Graf
2012-07-10 10:34 ` Alexander Graf
2012-07-10 10:34 ` [Qemu-devel] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341905138.2561.12.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.