From: "Eilon Greenstein" <eilong@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: meravs@broadcom.com, netdev@vger.kernel.org, dmitry@broadcom.com
Subject: Re: [net-next patch v2] bnx2x: Add run-time CNIC support
Date: Tue, 10 Jul 2012 15:33:54 +0300 [thread overview]
Message-ID: <1341923634.27035.6.camel@lb-tlvb-eilong.il.broadcom.com> (raw)
In-Reply-To: <20120710.052149.792836375666491854.davem@davemloft.net>
On Tue, 2012-07-10 at 05:21 -0700, David Miller wrote:
> From: "Merav Sicron" <meravs@broadcom.com>
> Date: Tue, 10 Jul 2012 15:17:00 +0300
>
> > There are still two advantages in disabling CNIC in bnx2x: Saving
> > resources (MSI-X vector and memory) as well as reducing some latency.
>
> But, nobody does this. No end user can do this easily, this
> is therefore of zero value to him.
Most do not, but I'm aware of two customers that play with their own
kernel that do that - they can play with the driver and tweak it to
disable this mode manually, but that is similar to supporting something
outside the tree.
> > While it is true that distributions enable the CNIC Kconfig option, some
> > users that care about resources and latency compile a kernel without it.
>
> This, therefore, results in a terrible user experience.
We are using the Kconfig since it is meant for advanced users that
customize their kernel to their needs.
> > Can you please re-consider this patch?
>
> Absolutely not.
>
> Make it really dynamic, and properly configurable at run time, so
> people don't have to go through hoops to get the "advantages" you
> speak so highly of.
This is possible for the resources, but not for the latency - we cannot
change the HW mode once traffic started to run. Why is that so bad to
support Kconfig as a working mode like we did thus far? We are using it
specifically for users that wants to optimize the kernel, so Kconfig
does not sound that bad in that context.
next prev parent reply other threads:[~2012-07-10 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 10:00 [net-next patch v2] bnx2x: Add run-time CNIC support Merav Sicron
2012-07-09 21:10 ` David Miller
2012-07-10 12:17 ` Merav Sicron
2012-07-10 12:21 ` David Miller
2012-07-10 12:33 ` Eilon Greenstein [this message]
2012-07-10 12:37 ` David Miller
2012-07-10 12:41 ` Eilon Greenstein
2012-07-10 13:06 ` David Miller
2012-07-10 14:38 ` Eilon Greenstein
2012-07-10 14:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341923634.27035.6.camel@lb-tlvb-eilong.il.broadcom.com \
--to=eilong@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=meravs@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.