All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: meravs@broadcom.com, netdev@vger.kernel.org, dmitry@broadcom.com
Subject: Re: [net-next patch v2] bnx2x: Add run-time CNIC support
Date: Tue, 10 Jul 2012 06:06:16 -0700 (PDT)	[thread overview]
Message-ID: <20120710.060616.2081630953053267615.davem@davemloft.net> (raw)
In-Reply-To: <1341924089.27035.7.camel@lb-tlvb-eilong.il.broadcom.com>

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Tue, 10 Jul 2012 15:41:29 +0300

> OK. Since it blocks the ability to add SR-IOV support, is it acceptable
> to submit it as constant enabled for PF and disabled for VF (SR-IOV)?

You're not describing to me why you guys are turning on features like
the CNIC mode before you necessarily have any users of that feature.

Why can't you turn CNIC off at the start, and if a CNIC user actually
arrives and is activated, reset the entire chip and put it into CNIC
mode?

And if CNIC being on is such a latency killer, why in the world
haven't you done things more reasonably like that from the very
beginning?

Why are you making it so that lower latency with your chips is only
available to a group of users who are effectively statistically
insignificant?

  reply	other threads:[~2012-07-10 13:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 10:00 [net-next patch v2] bnx2x: Add run-time CNIC support Merav Sicron
2012-07-09 21:10 ` David Miller
2012-07-10 12:17   ` Merav Sicron
2012-07-10 12:21     ` David Miller
2012-07-10 12:33       ` Eilon Greenstein
2012-07-10 12:37         ` David Miller
2012-07-10 12:41           ` Eilon Greenstein
2012-07-10 13:06             ` David Miller [this message]
2012-07-10 14:38               ` Eilon Greenstein
2012-07-10 14:40                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120710.060616.2081630953053267615.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dmitry@broadcom.com \
    --cc=eilong@broadcom.com \
    --cc=meravs@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.