[PATCH] Bluetooth: Add MacBookPro10,1 support

[PATCH] Bluetooth: Add MacBookPro10,1 support

[Henrik Rydberg]

Add support for the 2012 15'' MacBook Pro Retina.

Patch originally written by clipcarl (forums.opensuse.org).

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
Hi Gustavo,

This patch adds support for the new retina. Picked up from the suse
forum. Getting it into 3.5 would be great, if possible.

Cheers,
Henrik

 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 83ebb24..6cc54da 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -84,6 +84,9 @@ static struct usb_device_id btusb_table[] = {
 	/* Apple MacMini5,1 */
 	{ USB_DEVICE(0x05ac, 0x8281) },
 
+	/* Apple MacBookPro10,1 */
+	{ USB_DEVICE(0x05ac, 0x8286) },
+
 	/* AVM BlueFRITZ! USB v2.0 */
 	{ USB_DEVICE(0x057c, 0x3800) },
 
-- 
1.7.11.1

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

[Johan Hedberg]

Hi Henrik,

On Mon, Jul 09, 2012, Henrik Rydberg wrote:
> Add support for the 2012 15'' MacBook Pro Retina.
> 
> Patch originally written by clipcarl (forums.opensuse.org).
> 
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
> Hi Gustavo,
> 
> This patch adds support for the new retina. Picked up from the suse
> forum. Getting it into 3.5 would be great, if possible.
> 
> Cheers,
> Henrik
> 
>  drivers/bluetooth/btusb.c | 3 +++
>  1 file changed, 3 insertions(+)

I believe the requirement is to always include a usb-devices output in
the commit message (to let maintainers confirm that no typo has occurred
in the patch itself).

Johah

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

[Henrik Rydberg]

On Mon, Jul 09, 2012 at 03:48:24PM -0300, Johan Hedberg wrote:
> Hi Henrik,
> 
> On Mon, Jul 09, 2012, Henrik Rydberg wrote:
> > Add support for the 2012 15'' MacBook Pro Retina.
> > 
> > Patch originally written by clipcarl (forums.opensuse.org).
> > 
> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> > ---
> > Hi Gustavo,
> > 
> > This patch adds support for the new retina. Picked up from the suse
> > forum. Getting it into 3.5 would be great, if possible.
> > 
> > Cheers,
> > Henrik
> > 
> >  drivers/bluetooth/btusb.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> I believe the requirement is to always include a usb-devices output in
> the commit message (to let maintainers confirm that no typo has occurred
> in the patch itself).

A patch that has been tested is obviously an even stronger indication.
Hopefully the modification below will suffice.

Thanks,
Henrik

>From 63bc0de5b431ca616557d87869f41ee22fdc5906 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg <rydberg@euromail.se>
Date: Mon, 9 Jul 2012 13:32:49 +0200
Subject: [PATCH] Bluetooth: Add MacBookPro10,1 support

Add support for the 2012 15'' MacBook Pro Retina, also known as
MacBookPro10,1. The bluetooth device presents itself as

Bus 002 Device 008: ID 05ac:8286 Apple, Inc. 

Patch originally written and tested by clipcarl (forums.opensuse.org).

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 83ebb24..6cc54da 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -84,6 +84,9 @@ static struct usb_device_id btusb_table[] = {
 	/* Apple MacMini5,1 */
 	{ USB_DEVICE(0x05ac, 0x8281) },
 
+	/* Apple MacBookPro10,1 */
+	{ USB_DEVICE(0x05ac, 0x8286) },
+
 	/* AVM BlueFRITZ! USB v2.0 */
 	{ USB_DEVICE(0x057c, 0x3800) },
 
-- 
1.7.11.1

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

[Gustavo Padovan]

Hi Henrik,

* Henrik Rydberg <rydberg@bitmath.se> [2012-07-09 21:25:29 +0200]:

> On Mon, Jul 09, 2012 at 03:48:24PM -0300, Johan Hedberg wrote:
> > Hi Henrik,
> > 
> > On Mon, Jul 09, 2012, Henrik Rydberg wrote:
> > > Add support for the 2012 15'' MacBook Pro Retina.
> > > 
> > > Patch originally written by clipcarl (forums.opensuse.org).
> > > 
> > > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> > > ---
> > > Hi Gustavo,
> > > 
> > > This patch adds support for the new retina. Picked up from the suse
> > > forum. Getting it into 3.5 would be great, if possible.
> > > 
> > > Cheers,
> > > Henrik
> > > 
> > >  drivers/bluetooth/btusb.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > I believe the requirement is to always include a usb-devices output in
> > the commit message (to let maintainers confirm that no typo has occurred
> > in the patch itself).

If you don't have access to the device I can take it without usb-devices,
otherwise just add it to the patch and then resend.

	Gustavo

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

[Henrik Rydberg]

Hi Gustavo,

> > > I believe the requirement is to always include a usb-devices output in
> > > the commit message (to let maintainers confirm that no typo has occurred
> > > in the patch itself).
> 
> If you don't have access to the device I can take it without usb-devices,
> otherwise just add it to the patch and then resend.

I don't, but I trust that this patch is authentic.

Thanks,
Henrik

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

[Marcel Holtmann]

Hi Henrik,

> > > > I believe the requirement is to always include a usb-devices output in
> > > > the commit message (to let maintainers confirm that no typo has occurred
> > > > in the patch itself).
> > 
> > If you don't have access to the device I can take it without usb-devices,
> > otherwise just add it to the patch and then resend.
> 
> I don't, but I trust that this patch is authentic.

the requirement is to have either /sys/kernel/debug/usb/devices section
or usb-devices output included in the commit message. No exceptions. I
want to have this documented in case any questions about it ever arises.

Regards

Marcel