* [Buildroot] [PATCH] libplayer: fix handling of cflags in configure
@ 2012-07-10 22:37 Arnout Vandecappelle
2012-07-11 9:25 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2012-07-10 22:37 UTC (permalink / raw)
To: buildroot
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
.../libplayer/libplayer-fix-configure-cflags.patch | 41 ++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/package/libplayer/libplayer-fix-configure-cflags.patch b/package/libplayer/libplayer-fix-configure-cflags.patch
new file mode 100644
index 0000000..186afd5
--- /dev/null
+++ b/package/libplayer/libplayer-fix-configure-cflags.patch
@@ -0,0 +1,41 @@
+From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+Subject: [PATCH] libplayer: Fix handling of cflags in configure.
+
+The cflags returned by pkg-config or another config script may consist
+of several arguments for the compiler. These should not be quoted together
+into a single argument.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
+---
+Sent upstream to devel at geexbox.org on July 11, 2012.
+---
+diff -rup libplayer-2.0.1.orig/configure libplayer-2.0.1/configure
+--- libplayer-2.0.1.orig/configure 2010-10-03 19:26:11.000000000 +0200
++++ libplayer-2.0.1/configure 2012-07-10 23:33:02.783701852 +0200
+@@ -342,7 +342,7 @@ check_libconfig(){
+ err=1
+ if `which "$config" 1>/dev/null 2>&1`; then
+ cflags=`$config $ccflags`
+- [ -n "$cflags" ] && check_cflags "$cflags"
++ [ -n "$cflags" ] && check_cflags $cflags
+ libs=`$config $clibs`
+ if [ -n "$libs" ]; then
+ temp_extralibs "$libs"
+@@ -364,7 +364,7 @@ check_libconfig_exists(){
+ err=1
+ if `which "$config" 1>/dev/null 2>&1`; then
+ cflags=`$config $ccflags`
+- [ -n "$cflags" ] && temp_cflags "$cflags"
++ [ -n "$cflags" ] && temp_cflags $cflags
+ libs=`$config $clibs`
+ if [ -n "$libs" ]; then
+ temp_extralibs "$libs"
+@@ -386,7 +386,7 @@ check_pkgconfig(){
+ err=1
+ if `which pkg-config 1>/dev/null 2>&1`; then
+ cflags=`pkg-config $pkg $ccflags`
+- [ -n "$cflags" ] && check_cflags "$cflags"
++ [ -n "$cflags" ] && check_cflags $cflags
+ libs=`pkg-config $pkg $clibs`
+ if [ -n "$libs" ]; then
+ temp_extralibs "$libs"
--
tg: (b8b57bb..) t/libplayer-cflags (depends on: master)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] libplayer: fix handling of cflags in configure
2012-07-10 22:37 [Buildroot] [PATCH] libplayer: fix handling of cflags in configure Arnout Vandecappelle
@ 2012-07-11 9:25 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2012-07-11 9:25 UTC (permalink / raw)
To: buildroot
Hello,
Le Wed, 11 Jul 2012 00:37:22 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Can you share details on which problem it fixes, and how to reproduce
it?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-11 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-10 22:37 [Buildroot] [PATCH] libplayer: fix handling of cflags in configure Arnout Vandecappelle
2012-07-11 9:25 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.