* [PATCH v2] media: mx2_camera: Don't modify non volatile parameters in try_fmt.
@ 2012-07-11 7:29 Javier Martin
2012-08-15 15:59 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martin @ 2012-07-11 7:29 UTC (permalink / raw)
To: linux-media
Cc: fabio.estevam, laurent.pinchart, g.liakhovetski, mchehab, Javier Martin
---
drivers/media/video/mx2_camera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
index d5355de..eda98fc 100644
--- a/drivers/media/video/mx2_camera.c
+++ b/drivers/media/video/mx2_camera.c
@@ -1370,6 +1370,7 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd,
__u32 pixfmt = pix->pixelformat;
struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
struct mx2_camera_dev *pcdev = ici->priv;
+ struct mx2_fmt_cfg *emma_prp;
unsigned int width_limit;
int ret;
@@ -1432,12 +1433,12 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd,
__func__, pcdev->s_width, pcdev->s_height);
/* If the sensor does not support image size try PrP resizing */
- pcdev->emma_prp = mx27_emma_prp_get_format(xlate->code,
+ emma_prp = mx27_emma_prp_get_format(xlate->code,
xlate->host_fmt->fourcc);
memset(pcdev->resizing, 0, sizeof(pcdev->resizing));
if ((mf.width != pix->width || mf.height != pix->height) &&
- pcdev->emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) {
+ emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) {
if (mx2_emmaprp_resize(pcdev, &mf, pix, false) < 0)
dev_dbg(icd->parent, "%s: can't resize\n", __func__);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] media: mx2_camera: Don't modify non volatile parameters in try_fmt.
2012-07-11 7:29 [PATCH v2] media: mx2_camera: Don't modify non volatile parameters in try_fmt Javier Martin
@ 2012-08-15 15:59 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2012-08-15 15:59 UTC (permalink / raw)
To: Javier Martin; +Cc: linux-media, fabio.estevam, laurent.pinchart, mchehab
Hi Javier
Please, resend with a Signed-off-by tag.
Thanks
Guennadi
On Wed, 11 Jul 2012, Javier Martin wrote:
> ---
> drivers/media/video/mx2_camera.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
> index d5355de..eda98fc 100644
> --- a/drivers/media/video/mx2_camera.c
> +++ b/drivers/media/video/mx2_camera.c
> @@ -1370,6 +1370,7 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd,
> __u32 pixfmt = pix->pixelformat;
> struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> struct mx2_camera_dev *pcdev = ici->priv;
> + struct mx2_fmt_cfg *emma_prp;
> unsigned int width_limit;
> int ret;
>
> @@ -1432,12 +1433,12 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd,
> __func__, pcdev->s_width, pcdev->s_height);
>
> /* If the sensor does not support image size try PrP resizing */
> - pcdev->emma_prp = mx27_emma_prp_get_format(xlate->code,
> + emma_prp = mx27_emma_prp_get_format(xlate->code,
> xlate->host_fmt->fourcc);
>
> memset(pcdev->resizing, 0, sizeof(pcdev->resizing));
> if ((mf.width != pix->width || mf.height != pix->height) &&
> - pcdev->emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) {
> + emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) {
> if (mx2_emmaprp_resize(pcdev, &mf, pix, false) < 0)
> dev_dbg(icd->parent, "%s: can't resize\n", __func__);
> }
> --
> 1.7.9.5
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-15 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-11 7:29 [PATCH v2] media: mx2_camera: Don't modify non volatile parameters in try_fmt Javier Martin
2012-08-15 15:59 ` Guennadi Liakhovetski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.